From 1571ab6d12eb37a1a7197a0f167c869cc873ccaa Mon Sep 17 00:00:00 2001
From: Fabio Formosa <fabio.formosa@gmail.com>
Date: Sat, 1 Oct 2022 16:12:26 +0200
Subject: [PATCH] #63 made as default behaviour the creation of a scheduler
 instance

---
 .../configuration/SchedulerConfig.java        |  2 +-
 ...hedulerConfigDefaultAppPropertiesTest.java | 21 +++++++++++++++++++
 .../src/main/resources/application.yml        |  9 --------
 3 files changed, 22 insertions(+), 10 deletions(-)
 create mode 100644 quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfigDefaultAppPropertiesTest.java

diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfig.java b/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfig.java
index 63b897c..c6e9905 100644
--- a/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfig.java
+++ b/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfig.java
@@ -18,7 +18,7 @@ import java.util.Properties;
 
 @ComponentScan(basePackages = {"it.fabioformosa.quartzmanager.controllers"})
 @Configuration
-@ConditionalOnProperty(name = "quartz.enabled")
+@ConditionalOnProperty(name = "quartz.enabled", matchIfMissing = true)
 public class SchedulerConfig {
 
     @Autowired(required = false)
diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfigDefaultAppPropertiesTest.java b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfigDefaultAppPropertiesTest.java
new file mode 100644
index 0000000..6afedc4
--- /dev/null
+++ b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/configuration/SchedulerConfigDefaultAppPropertiesTest.java
@@ -0,0 +1,21 @@
+package it.fabioformosa.quartzmanager.configuration;
+
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.quartz.Scheduler;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+
+@SpringBootTest
+class SchedulerConfigDefaultAppPropertiesTest {
+
+  @Autowired
+  private Scheduler scheduler;
+
+  @Test
+  void givenTheQuartzPropMissing_whenTheBootstrapOccurs_thenAQuartzInstanceShouldBeInstanciated(){
+    Assertions.assertThat(scheduler).isNotNull();
+  }
+
+
+}
diff --git a/quartz-manager-parent/quartz-manager-web-showcase/src/main/resources/application.yml b/quartz-manager-parent/quartz-manager-web-showcase/src/main/resources/application.yml
index 88a03fe..0d642cb 100644
--- a/quartz-manager-parent/quartz-manager-web-showcase/src/main/resources/application.yml
+++ b/quartz-manager-parent/quartz-manager-web-showcase/src/main/resources/application.yml
@@ -1,12 +1,3 @@
-server:
-  servlet:
-    context-path: /
-    session.timeout : 28800
-  port: 8080
-
-quartz:
-  enabled: true
-
 quartz-manager:
   jobClassPackages: it.fabioformosa.quartzmanager.jobs
   security: