From 540bdf35a51873eb1e3921add9dba5f0e62107b8 Mon Sep 17 00:00:00 2001
From: Fabio Formosa <fabio.formosa@gmail.com>
Date: Fri, 28 Oct 2022 23:53:33 +0200
Subject: [PATCH] #78 fixed sonar smells

---
 .../api/QuartManagerApplicationTests.java            |  7 +++++++
 .../api/controllers/TriggerControllerTest.java       |  2 --
 .../api/security/AbstractSecurityLoginTest.java      |  2 +-
 .../api/security/SpringApplicationTest.java          | 12 ++++++++++++
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java
index 8f0f6de..603a7b9 100644
--- a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java
+++ b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java
@@ -1,6 +1,9 @@
 package it.fabioformosa.quartzmanager.api;
 
+import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.quartz.Scheduler;
+import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.SpringBootConfiguration;
 import org.springframework.context.annotation.ComponentScan;
 
@@ -8,8 +11,12 @@ import org.springframework.context.annotation.ComponentScan;
 @SpringBootConfiguration
 public class QuartManagerApplicationTests {
 
+    @Autowired
+    private Scheduler scheduler;
+
     @Test
     public void contextLoads() {
+      Assertions.assertThat(scheduler).isNotNull();
     }
 
 }
diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/controllers/TriggerControllerTest.java b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/controllers/TriggerControllerTest.java
index 40d99be..fdc2e35 100644
--- a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/controllers/TriggerControllerTest.java
+++ b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/controllers/TriggerControllerTest.java
@@ -27,6 +27,4 @@ class TriggerControllerTest {
     Mockito.reset(triggerService);
   }
 
-
-
 }
diff --git a/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/AbstractSecurityLoginTest.java b/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/AbstractSecurityLoginTest.java
index 2f39181..7bffec9 100644
--- a/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/AbstractSecurityLoginTest.java
+++ b/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/AbstractSecurityLoginTest.java
@@ -9,7 +9,7 @@ import org.springframework.util.MultiValueMap;
 
 import static it.fabioformosa.quartzmanager.api.common.config.QuartzManagerPaths.QUARTZ_MANAGER_LOGIN_PATH;
 
-public class AbstractSecurityLoginTest {
+public abstract class AbstractSecurityLoginTest {
   @Autowired
   private TestRestTemplate testRestTemplate;
 
diff --git a/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/SpringApplicationTest.java b/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/SpringApplicationTest.java
index 9e95251..e33af5a 100644
--- a/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/SpringApplicationTest.java
+++ b/quartz-manager-parent/quartz-manager-starter-security/src/test/java/it/fabioformosa/quartzmanager/api/security/SpringApplicationTest.java
@@ -1,7 +1,19 @@
 package it.fabioformosa.quartzmanager.api.security;
 
+import it.fabioformosa.quartzmanager.api.security.controllers.TestController;
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 
 @SpringBootApplication
 public class SpringApplicationTest {
+
+  @Autowired
+  private TestController testController;
+  @Test
+  public void contextLoad(){
+    Assertions.assertThat(testController).isNotNull();
+  }
+
 }