From c190c15889feb529e84a9f7f6ba93668ed7348aa Mon Sep 17 00:00:00 2001 From: Fabio Formosa Date: Sat, 29 Oct 2022 00:04:48 +0200 Subject: [PATCH] #78 fixed sonar smells --- .../sonar-project.properties | 1 + .../api/configuration/SecurityDiscover.java | 6 ------ .../configuration/SecurityDiscoverConfig.java | 19 ------------------- .../api/QuartManagerApplicationTests.java | 12 ------------ 4 files changed, 1 insertion(+), 37 deletions(-) create mode 100644 quartz-manager-parent/quartz-manager-starter-api/sonar-project.properties delete mode 100644 quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscover.java delete mode 100644 quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscoverConfig.java diff --git a/quartz-manager-parent/quartz-manager-starter-api/sonar-project.properties b/quartz-manager-parent/quartz-manager-starter-api/sonar-project.properties new file mode 100644 index 0000000..8e1f51f --- /dev/null +++ b/quartz-manager-parent/quartz-manager-starter-api/sonar-project.properties @@ -0,0 +1 @@ +sonar.exclusions=**/QuartManagerApplicationTests.java diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscover.java b/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscover.java deleted file mode 100644 index 8c290d9..0000000 --- a/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscover.java +++ /dev/null @@ -1,6 +0,0 @@ -package it.fabioformosa.quartzmanager.api.configuration; - -public class SecurityDiscover { - public SecurityDiscover() { - } -} diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscoverConfig.java b/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscoverConfig.java deleted file mode 100644 index cb65838..0000000 --- a/quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/configuration/SecurityDiscoverConfig.java +++ /dev/null @@ -1,19 +0,0 @@ -package it.fabioformosa.quartzmanager.api.configuration; - -import lombok.extern.slf4j.Slf4j; -import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; -import org.springframework.context.annotation.Bean; -import org.springframework.context.annotation.Configuration; - -@Slf4j -@ConditionalOnClass(name = {"it.fabioformosa.quartzmanager.api.security.QuartzManagerSecurityConfig"}) -@Configuration -public class SecurityDiscoverConfig { - - @Bean - public SecurityDiscover securityIsEnabled(){ - log.info("Quartz Manager Security Layer is enabled!"); - return new SecurityDiscover(); - } - -} diff --git a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java index 603a7b9..b843cce 100644 --- a/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java +++ b/quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/QuartManagerApplicationTests.java @@ -1,9 +1,5 @@ package it.fabioformosa.quartzmanager.api; -import org.assertj.core.api.Assertions; -import org.junit.jupiter.api.Test; -import org.quartz.Scheduler; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.SpringBootConfiguration; import org.springframework.context.annotation.ComponentScan; @@ -11,12 +7,4 @@ import org.springframework.context.annotation.ComponentScan; @SpringBootConfiguration public class QuartManagerApplicationTests { - @Autowired - private Scheduler scheduler; - - @Test - public void contextLoads() { - Assertions.assertThat(scheduler).isNotNull(); - } - }