From 3cbf8c23ab327a11e5eea641a2af4aba25176f2d Mon Sep 17 00:00:00 2001
From: beaniejoy <lhb1025@gmail.com>
Date: Mon, 3 Oct 2022 18:11:28 +0900
Subject: [PATCH] =?UTF-8?q?[#15]=20modify:=20update=20=EA=B4=80=EB=A0=A8?=
 =?UTF-8?q?=20dynamic=20=EB=82=B4=EC=9A=A9=20=EC=A0=9C=EA=B1=B0?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- dynamic update 기능 제거(성능 관련 추후 살펴보기)
- Todo 주석 추가
---
 .../io/beaniejoy/dongnecafe/domain/cafe/entity/CafeMenu.kt     | 3 ---
 .../io/beaniejoy/dongnecafe/domain/cafe/entity/MenuOption.kt   | 2 --
 .../io/beaniejoy/dongnecafe/domain/cafe/entity/OptionDetail.kt | 2 --
 .../dongnecafe/domain/cafe/service/CafeMenuService.kt          | 3 +++
 .../dongnecafe/domain/cafe/service/CafeServiceTest.kt          | 1 -
 5 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/CafeMenu.kt b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/CafeMenu.kt
index faa84d4..92b8299 100644
--- a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/CafeMenu.kt
+++ b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/CafeMenu.kt
@@ -2,12 +2,9 @@ package io.beaniejoy.dongnecafe.domain.cafe.entity
 
 import io.beaniejoy.dongnecafe.common.entity.BaseTimeEntity
 import io.beaniejoy.dongnecafe.domain.cafe.model.request.MenuOptionRegisterRequest
-import io.beaniejoy.dongnecafe.domain.cafe.model.request.MenuOptionUpdateRequest
-import org.hibernate.annotations.DynamicUpdate
 import java.math.BigDecimal
 import javax.persistence.*
 
-@DynamicUpdate
 @Entity
 @Table(name = "cafe_menu")
 class CafeMenu protected constructor(
diff --git a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/MenuOption.kt b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/MenuOption.kt
index b437837..e63795a 100644
--- a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/MenuOption.kt
+++ b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/MenuOption.kt
@@ -2,10 +2,8 @@ package io.beaniejoy.dongnecafe.domain.cafe.entity
 
 import io.beaniejoy.dongnecafe.common.entity.BaseTimeEntity
 import io.beaniejoy.dongnecafe.domain.cafe.model.request.OptionDetailRegisterRequest
-import org.hibernate.annotations.DynamicUpdate
 import javax.persistence.*
 
-@DynamicUpdate
 @Entity
 @Table(name = "menu_option")
 class MenuOption protected constructor(
diff --git a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/OptionDetail.kt b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/OptionDetail.kt
index 998d149..6bf8b70 100644
--- a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/OptionDetail.kt
+++ b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/entity/OptionDetail.kt
@@ -1,11 +1,9 @@
 package io.beaniejoy.dongnecafe.domain.cafe.entity
 
 import io.beaniejoy.dongnecafe.common.entity.BaseTimeEntity
-import org.hibernate.annotations.DynamicUpdate
 import java.math.BigDecimal
 import javax.persistence.*
 
-@DynamicUpdate
 @Entity
 @Table(name = "option_detail")
 class OptionDetail protected constructor(
diff --git a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeMenuService.kt b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeMenuService.kt
index ee4b91c..bf40940 100644
--- a/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeMenuService.kt
+++ b/src/main/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeMenuService.kt
@@ -8,6 +8,9 @@ import org.springframework.data.repository.findByIdOrNull
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
 
+// TODO
+//  - cafeMenu에 대한 생성, 수정, 삭제를 단일 카페 상세 페이지 내에서 한꺼번에 수행할지 고민
+//  - front 개발 후에 CafeMenu에 대한 전체적인 로직 수정이 필요해 보임
 @Service
 @Transactional
 class CafeMenuService(
diff --git a/src/test/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeServiceTest.kt b/src/test/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeServiceTest.kt
index 5779f9c..6855a8c 100644
--- a/src/test/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeServiceTest.kt
+++ b/src/test/java/io/beaniejoy/dongnecafe/domain/cafe/service/CafeServiceTest.kt
@@ -13,7 +13,6 @@ import org.mockito.Mock
 import org.mockito.Mockito.*
 import org.mockito.junit.jupiter.MockitoExtension
 import java.util.*
-import javax.persistence.GeneratedValue
 
 // TODO: BDD 스타일로 리팩토링 해볼 것(추후 mockK도 사용해보자)
 @ExtendWith(MockitoExtension::class)