mindol1004/MangKyu-erros
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BugFix on getRandomQuizListUnderLimit

Browse Source
This commit is contained in:
MangKyu
2021-12-09 00:26:10 +09:00
parent e17b6fe82a
commit 8e84f7ac35
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/com/mangkyu/employment/interview/app/quiz/service/QuizService.java
View File

@@ -44,7 +44,7 @@ public class QuizService {
} }
public List<Quiz> getRandomQuizListUnderLimit(final List<Quiz> quizList) { public List<Quiz> getRandomQuizListUnderLimit(final List<Quiz> quizList) {
return quizList.size() < QuizConstants.MAXIMUM_QUIZ_SIZE return quizList.size() <= QuizConstants.MAXIMUM_QUIZ_SIZE
? quizList ? quizList
: createRandomQuizListUnderLimit(quizList); : createRandomQuizListUnderLimit(quizList);
} }
@@ -56,8 +56,6 @@ public class QuizService {
for (int i = 0; i < QuizConstants.MAXIMUM_QUIZ_SIZE; i++) { for (int i = 0; i < QuizConstants.MAXIMUM_QUIZ_SIZE; i++) {
final int randomIndex = rand.nextInt(quizList.size()); final int randomIndex = rand.nextInt(quizList.size());
final Quiz quiz = quizList.get(randomIndex); final Quiz quiz = quizList.get(randomIndex);
quizList.remove(randomIndex);
randomQuizList.add(quiz); randomQuizList.add(quiz);
} }