Bugfix of test and AddUser APIs

This commit is contained in:
MangKyu
2022-01-05 17:11:54 +09:00
parent 5a902af311
commit 9b46d012dc
3 changed files with 8 additions and 11 deletions

View File

@@ -14,6 +14,7 @@ import javax.validation.constraints.NotBlank;
import javax.validation.constraints.NotEmpty; import javax.validation.constraints.NotEmpty;
import javax.validation.constraints.NotNull; import javax.validation.constraints.NotNull;
import java.util.Set; import java.util.Set;
import java.util.UUID;
import static com.mangkyu.employment.interview.app.quiz.constants.QuizConstants.*; import static com.mangkyu.employment.interview.app.quiz.constants.QuizConstants.*;
@@ -23,6 +24,8 @@ import static com.mangkyu.employment.interview.app.quiz.constants.QuizConstants.
@NoArgsConstructor(force = true) @NoArgsConstructor(force = true)
public class AddUserRequest { public class AddUserRequest {
private final String resourceId = String.valueOf(UUID.randomUUID());
@Email @Email
@NotBlank @NotBlank
private final String email; private final String email;

View File

@@ -85,7 +85,7 @@ class AnswerControllerTest {
// when // when
final ResultActions result = mockMvc.perform( final ResultActions result = mockMvc.perform(
MockMvcRequestBuilders.post(url) MockMvcRequestBuilders.put(url)
.content(new Gson().toJson(addAnswerRequest)) .content(new Gson().toJson(addAnswerRequest))
.contentType(MediaType.APPLICATION_JSON) .contentType(MediaType.APPLICATION_JSON)
); );
@@ -107,13 +107,13 @@ class AnswerControllerTest {
// when // when
final ResultActions result = mockMvc.perform( final ResultActions result = mockMvc.perform(
MockMvcRequestBuilders.post(url) MockMvcRequestBuilders.put(url)
.content(new Gson().toJson(addAnswerRequest)) .content(new Gson().toJson(addAnswerRequest))
.contentType(MediaType.APPLICATION_JSON) .contentType(MediaType.APPLICATION_JSON)
); );
// then // then
result.andExpect(status().isCreated()); result.andExpect(status().isNoContent());
} }
private static Stream<Arguments> provideParameters() { private static Stream<Arguments> provideParameters() {

View File

@@ -3,6 +3,7 @@ package com.mangkyu.employment.interview.app.user.service;
import com.mangkyu.employment.interview.app.user.dto.AddUserRequest; import com.mangkyu.employment.interview.app.user.dto.AddUserRequest;
import com.mangkyu.employment.interview.app.user.entity.User; import com.mangkyu.employment.interview.app.user.entity.User;
import com.mangkyu.employment.interview.app.user.repository.UserRepository; import com.mangkyu.employment.interview.app.user.repository.UserRepository;
import com.mangkyu.employment.interview.config.modelmapper.ModelMapperConfig;
import com.mangkyu.employment.interview.enums.value.QuizDay; import com.mangkyu.employment.interview.enums.value.QuizDay;
import com.mangkyu.employment.interview.enums.value.QuizLevel; import com.mangkyu.employment.interview.enums.value.QuizLevel;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
@@ -32,17 +33,10 @@ class UserServiceTest {
@Mock @Mock
private UserRepository userRepository; private UserRepository userRepository;
@Spy @Spy
private ModelMapper modelMapper; private ModelMapper modelMapper = new ModelMapperConfig().modelMapper();
private final QuizDay quizDay = QuizDay.MONDAY; private final QuizDay quizDay = QuizDay.MONDAY;
@BeforeEach
public void init() {
modelMapper.getConfiguration()
.setFieldAccessLevel(Configuration.AccessLevel.PRIVATE)
.setFieldMatchingEnabled(true);
}
@Test @Test
public void addUserSuccess() { public void addUserSuccess() {
// given // given