From 4005dad9ac186da601b554b4bbbf276bf1512aaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=86=90=EC=B0=BD=ED=98=84?= Date: Fri, 15 Jul 2022 00:44:21 +0900 Subject: [PATCH] refactor: get movie times test --- .../movie/service/MovieTimeServiceImplTest.java | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/server/src/test/java/com/ticketing/server/movie/service/MovieTimeServiceImplTest.java b/server/src/test/java/com/ticketing/server/movie/service/MovieTimeServiceImplTest.java index 3785992..a9075b1 100644 --- a/server/src/test/java/com/ticketing/server/movie/service/MovieTimeServiceImplTest.java +++ b/server/src/test/java/com/ticketing/server/movie/service/MovieTimeServiceImplTest.java @@ -10,6 +10,7 @@ import com.ticketing.server.movie.domain.Theater; import com.ticketing.server.movie.domain.repository.MovieRepository; import com.ticketing.server.movie.domain.repository.MovieTimeRepository; import com.ticketing.server.movie.service.dto.MovieTimeDTO; +import com.ticketing.server.movie.service.dto.MovieTimeListDTO; import java.time.LocalDate; import java.time.LocalDateTime; import java.util.ArrayList; @@ -39,26 +40,26 @@ public class MovieTimeServiceImplTest { MovieTimeServiceImpl movieTimeService; @Test - @DisplayName("MovieTime Service Test - get empty list when there is no valid movie times") + @DisplayName("MovieTime Service Test - get empty list when there are no valid movie times") void shouldGetEmptyList() { // given Movie movie = new Movie(title, 106L); - when(movieRepository.findByTitle(title)) + when(movieRepository.findByIdAndDeletedAtNull(any())) .thenReturn(Optional.of(movie)); when(movieTimeRepository.findValidMovieTimes(any(), any(), any())) .thenReturn(Collections.emptyList()); // when - List movieTimeDTOList = movieTimeService.getMovieTimes(title, LocalDate.now()); + MovieTimeListDTO movieTimeListDto = movieTimeService.getMovieTimes(any(), LocalDate.now()); // then - assertTrue(movieTimeDTOList.isEmpty()); + assertTrue(movieTimeListDto.getMovieTimeDtos().isEmpty()); } @Test - @DisplayName("MovieTime Service Test - get list when there is valid movie times") + @DisplayName("MovieTime Service Test - get list when there are valid movie times") void shouldGetMovieTimeList() { // given Movie movie = new Movie(title, 106L); @@ -69,17 +70,17 @@ public class MovieTimeServiceImplTest { movieTimes.add(movieTime); - when(movieRepository.findByTitle(title)) + when(movieRepository.findByIdAndDeletedAtNull(any())) .thenReturn(Optional.of(movie)); when(movieTimeRepository.findValidMovieTimes(any(), any(), any())) .thenReturn(movieTimes); // when - List movieTimeDTOList = movieTimeService.getMovieTimes(title, LocalDate.of(2022, 07, 01)); + MovieTimeListDTO movieTimeListDto = movieTimeService.getMovieTimes(any(), LocalDate.of(2022, 07, 01)); // then - assertTrue(!movieTimeDTOList.isEmpty()); + assertTrue(!movieTimeListDto.getMovieTimeDtos().isEmpty()); } }