mindol1004/Ticketing
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: findByEmail 중복코드 제거

Browse Source
This commit is contained in:
dongHyo
2022-06-18 22:29:00 +09:00
parent 9fa7446487
commit ffa6b3f623
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/src/main/java/com/ticketing/server/user/service/UserServiceImpl.java
View File

@@ -39,13 +39,7 @@ public class UserServiceImpl implements UserService {
@Override @Override
@Transactional @Transactional
public User delete(@Valid DeleteUserDTO deleteUserDto) { public User delete(@Valid DeleteUserDTO deleteUserDto) {
User user = userRepository.findByEmail(deleteUserDto.getEmail()) User user = findByEmail(deleteUserDto.getEmail());
.orElseThrow(() -> {
log.error("존재하지 않는 이메일 입니다. :: {}", deleteUserDto.getEmail());
throw new EmailNotFoundException();
}
);
return user.delete(deleteUserDto); return user.delete(deleteUserDto);
} }
@@ -59,7 +53,11 @@ public class UserServiceImpl implements UserService {
@Override @Override
public User findByEmail(String email) { public User findByEmail(String email) {
return userRepository.findByEmail(email) return userRepository.findByEmail(email)
.orElseThrow(EmailNotFoundException::new); .orElseThrow(() -> {
log.error("존재하지 않는 이메일 입니다. :: {}", email);
throw new EmailNotFoundException();
}
);
} }
private User findNotDeletedUserByEmail(String email) { private User findNotDeletedUserByEmail(String email) {