From 83ecaa202b044c7bc7b5da01f9da5856cd4ca6a6 Mon Sep 17 00:00:00 2001
From: CHE0LIP <patrick.lisser@helvetia.ch>
Date: Fri, 9 Apr 2021 10:50:46 +0200
Subject: [PATCH] replace hardcoded package names with (unused) parameters;
 reduce redundancy

---
 .../buckpal/archunit/ArchitectureElement.java        | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/test/java/io/reflectoring/buckpal/archunit/ArchitectureElement.java b/src/test/java/io/reflectoring/buckpal/archunit/ArchitectureElement.java
index 103c870..1861b82 100644
--- a/src/test/java/io/reflectoring/buckpal/archunit/ArchitectureElement.java
+++ b/src/test/java/io/reflectoring/buckpal/archunit/ArchitectureElement.java
@@ -23,10 +23,10 @@ abstract class ArchitectureElement {
   static void denyDependency(String fromPackageName, String toPackageName, JavaClasses classes) {
     noClasses()
         .that()
-        .resideInAPackage("io.reflectoring.reviewapp.domain..")
+        .resideInAPackage(matchAllClassesInPackage(fromPackageName))
         .should()
         .dependOnClassesThat()
-        .resideInAnyPackage("io.reflectoring.reviewapp.application..")
+        .resideInAnyPackage(matchAllClassesInPackage(toPackageName))
         .check(classes);
   }
 
@@ -34,13 +34,7 @@ abstract class ArchitectureElement {
       List<String> fromPackages, List<String> toPackages, JavaClasses classes) {
     for (String fromPackage : fromPackages) {
       for (String toPackage : toPackages) {
-        noClasses()
-            .that()
-            .resideInAPackage(matchAllClassesInPackage(fromPackage))
-            .should()
-            .dependOnClassesThat()
-            .resideInAnyPackage(matchAllClassesInPackage(toPackage))
-            .check(classes);
+        denyDependency(fromPackage, toPackage, classes);
       }
     }
   }