From 28c36a589de6d8434ed2aff4b5db55437a4da248 Mon Sep 17 00:00:00 2001 From: Luc Weinbrecht Date: Mon, 27 Jun 2022 06:20:12 +0200 Subject: [PATCH] removed unnecessary fetch variable specification --- .../adapter/in/process/ApproveLoanAgreement.java | 3 +-- .../adapter/in/process/RejectionLoanAgreement.java | 3 +-- .../in/process/SendCrossSellingRecommendation.java | 8 ++------ .../adapter/in/process/SendRecommendation.java | 8 ++------ 4 files changed, 6 insertions(+), 16 deletions(-) diff --git a/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/ApproveLoanAgreement.java b/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/ApproveLoanAgreement.java index a6d7f83..f114abd 100644 --- a/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/ApproveLoanAgreement.java +++ b/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/ApproveLoanAgreement.java @@ -8,7 +8,6 @@ import lombok.RequiredArgsConstructor; import lombok.extern.slf4j.Slf4j; import org.springframework.stereotype.Component; -import static de.weinbrecht.luc.bpm.architecture.loan.agreement.adapter.common.ProcessConstants.LOAN_AGREEMENT_NUMBER; import static de.weinbrecht.luc.bpm.architecture.loan.agreement.adapter.common.ProcessConstants.LOAN_AGREEMENT_TASK; @Slf4j @@ -18,7 +17,7 @@ public class ApproveLoanAgreement { private final LoanAgreementStatusCommand loanAgreementStatusCommand; - @ZeebeWorker(type = LOAN_AGREEMENT_TASK, fetchVariables = LOAN_AGREEMENT_NUMBER, autoComplete = true) + @ZeebeWorker(type = LOAN_AGREEMENT_TASK, autoComplete = true) public void handleJobFoo(@ZeebeVariable Number loanAgreementNumber) { loanAgreementStatusCommand.accept(new LoanAgreementNumber(loanAgreementNumber.longValue())); } diff --git a/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/RejectionLoanAgreement.java b/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/RejectionLoanAgreement.java index 5c6b2a3..8707834 100644 --- a/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/RejectionLoanAgreement.java +++ b/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/RejectionLoanAgreement.java @@ -8,7 +8,6 @@ import lombok.RequiredArgsConstructor; import lombok.extern.slf4j.Slf4j; import org.springframework.stereotype.Component; -import static de.weinbrecht.luc.bpm.architecture.loan.agreement.adapter.common.ProcessConstants.LOAN_AGREEMENT_NUMBER; import static de.weinbrecht.luc.bpm.architecture.loan.agreement.adapter.common.ProcessConstants.LOAN_REJECTION_TASK; @Slf4j @@ -18,7 +17,7 @@ public class RejectionLoanAgreement { private final LoanAgreementStatusCommand loanAgreementStatusCommand; - @ZeebeWorker(type = LOAN_REJECTION_TASK, fetchVariables = LOAN_AGREEMENT_NUMBER, autoComplete = true) + @ZeebeWorker(type = LOAN_REJECTION_TASK, autoComplete = true) public void handleJobFoo(@ZeebeVariable Number loanAgreementNumber) { loanAgreementStatusCommand.reject(new LoanAgreementNumber(loanAgreementNumber.longValue())); } diff --git a/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/SendCrossSellingRecommendation.java b/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/SendCrossSellingRecommendation.java index fe15a80..552bb82 100644 --- a/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/SendCrossSellingRecommendation.java +++ b/loan-agreement/src/main/java/de/weinbrecht/luc/bpm/architecture/loan/agreement/adapter/in/process/SendCrossSellingRecommendation.java @@ -10,7 +10,7 @@ import io.camunda.zeebe.spring.client.annotation.ZeebeWorker; import lombok.RequiredArgsConstructor; import org.springframework.stereotype.Component; -import static de.weinbrecht.luc.bpm.architecture.loan.agreement.adapter.common.ProcessConstants.*; +import static de.weinbrecht.luc.bpm.architecture.loan.agreement.adapter.common.ProcessConstants.SEND_CROSS_SELLING_RECOMMENDATION_TASK; @RequiredArgsConstructor @Component @@ -19,11 +19,7 @@ public class SendCrossSellingRecommendation { private final RecommendationTrigger recommendationTrigger; private final LoanAgreementQuery loanAgreementQuery; - @ZeebeWorker( - type = SEND_CROSS_SELLING_RECOMMENDATION_TASK, - fetchVariables = { LOAN_AGREEMENT_NUMBER, BUSINESS_KEY }, - autoComplete = true - ) + @ZeebeWorker(type = SEND_CROSS_SELLING_RECOMMENDATION_TASK, autoComplete = true) public void handleJobFoo(@ZeebeVariable Number loanAgreementNumber, @ZeebeVariable String businessKey) { LoanAgreement loanAgreement = loanAgreementQuery.loadByNumber( new LoanAgreementNumber(loanAgreementNumber.longValue()) diff --git a/recommendation/src/main/java/de/weinbrecht/luc/bpm/architecture/recommendation/adapter/in/process/SendRecommendation.java b/recommendation/src/main/java/de/weinbrecht/luc/bpm/architecture/recommendation/adapter/in/process/SendRecommendation.java index 0a10424..453a787 100644 --- a/recommendation/src/main/java/de/weinbrecht/luc/bpm/architecture/recommendation/adapter/in/process/SendRecommendation.java +++ b/recommendation/src/main/java/de/weinbrecht/luc/bpm/architecture/recommendation/adapter/in/process/SendRecommendation.java @@ -12,7 +12,7 @@ import io.camunda.zeebe.spring.client.annotation.ZeebeWorker; import lombok.RequiredArgsConstructor; import org.springframework.stereotype.Component; -import static de.weinbrecht.luc.bpm.architecture.recommendation.adapter.common.ProcessConstants.*; +import static de.weinbrecht.luc.bpm.architecture.recommendation.adapter.common.ProcessConstants.SEND_RECOMMENDATION_TASK; @RequiredArgsConstructor @Component @@ -21,11 +21,7 @@ public class SendRecommendation { private final SendNotification sendNotification; private final RecommendationQuery recommendationQuery; - @ZeebeWorker( - type = SEND_RECOMMENDATION_TASK, - fetchVariables = {CONTENT_NUMBER, CUSTOMER_NUMBER}, - autoComplete = true - ) + @ZeebeWorker(type = SEND_RECOMMENDATION_TASK, autoComplete = true) public void handleJobFoo(@ZeebeVariable Number contentNumber, @ZeebeVariable String customerNumber) { Content content = recommendationQuery.findContentById(new ContentId(contentNumber.longValue())); Customer customer = recommendationQuery.findCustomerById(new CustomerId(customerNumber));