tdd : picking system - order state enum

tdd_practice/pickingTDD/src/main/java/com/example/pickingtdd/entity/Order.java

@@ -8,5 +8,5 @@ import lombok.Setter;
 public class Order {
 
     private Long orderId;
-    private String State;
+    private OrderStateEnum State;
 }

tdd_practice/pickingTDD/src/main/java/com/example/pickingtdd/entity/OrderStateEnum.java

@@ -0,0 +1,5 @@
+package com.example.pickingtdd.entity;
+
+public enum OrderStateEnum {
+    ORDERED, PENDING, PICKING, DONE
+}

tdd_practice/pickingTDD/src/main/java/com/example/pickingtdd/service/OrderServiceImpl.java

@@ -19,7 +19,7 @@ public class OrderServiceImpl implements OrderService {
         if (order.getOrderId() == null) {
             return false;
         }
-        if (order.getState() == null || order.getState().length() == 0) {
+        if (order.getState() == null) {
             return false;
         }
         return true;

tdd_practice/pickingTDD/src/test/java/com/example/pickingtdd/service/OrderDetailServiceTests.java

@@ -0,0 +1,4 @@
+package com.example.pickingtdd.service;
+
+public class OrderDetailServiceTests {
+}

tdd_practice/pickingTDD/src/test/java/com/example/pickingtdd/service/OrderServiceTests.java

@@ -1,6 +1,7 @@
 package com.example.pickingtdd.service;
 
 import com.example.pickingtdd.entity.Order;
+import com.example.pickingtdd.entity.OrderStateEnum;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -22,11 +23,11 @@ public class OrderServiceTests {
     void init() {
         orderSuccess = new Order();
         orderSuccess.setOrderId(1L);
-        orderSuccess.setState("Ordered");
+        orderSuccess.setState(OrderStateEnum.ORDERED);
 
         orderFail = new Order();
         orderFail.setOrderId(null);
-        orderFail.setState("");
+        orderFail.setState(null);
     }
 
     @Test
@@ -39,7 +40,7 @@ public class OrderServiceTests {
         }
 
         assertEquals(1L, order.getOrderId());
-        assertEquals("Ordered", order.getState());
+        assertEquals(OrderStateEnum.ORDERED, order.getState());
     }
 
     @Test
@@ -52,7 +53,7 @@ public class OrderServiceTests {
         }
 
         assertEquals(1L, order.getOrderId());
-        assertEquals("Ordered", order.getState());
+        assertEquals(OrderStateEnum.ORDERED, order.getState());
     }
 
     @Test

tdd_practice/pickingTDD/todo.txt

@@ -8,7 +8,10 @@ SKU
 주문 -> 피킹리스트 -> 피커 -> 피킹완료
 
 ------- TO-DO -------
-[] Order.state => enum 변경
+[] Order validation 에 OrderDetail 검증 추가
+[] OrderDetail validation 추가
+[] OrderDetail 생성
 
+[v] Order.state => enum 변경
 [v] ORDER 검증
 [v] ORDER 생성