From 6667bcde4dd54fdedf632522967197cf92d00200 Mon Sep 17 00:00:00 2001 From: Tom Hombergs Date: Sun, 17 Nov 2019 06:33:05 +1100 Subject: [PATCH] added @ConstructorBinding annotation --- .../io/reflectoring/staticdata/Quote.java | 24 +++++++++---------- .../staticdata/QuotesProperties.java | 6 ++--- .../staticdata/RandomQuotePrinter.java | 4 ++-- .../staticdata/StaticApplication.java | 1 - 4 files changed, 16 insertions(+), 19 deletions(-) diff --git a/spring-boot/static/src/main/java/io/reflectoring/staticdata/Quote.java b/spring-boot/static/src/main/java/io/reflectoring/staticdata/Quote.java index c0417eb..8fcc6f1 100644 --- a/spring-boot/static/src/main/java/io/reflectoring/staticdata/Quote.java +++ b/spring-boot/static/src/main/java/io/reflectoring/staticdata/Quote.java @@ -1,26 +1,24 @@ package io.reflectoring.staticdata; -public class Quote { +import org.springframework.boot.context.properties.ConstructorBinding; - private String text; - private String author; +@ConstructorBinding +class Quote { - public Quote() { + private final String text; + private final String author; + + public Quote(String text, String author) { + this.text = text; + this.author = author; } - public String getText() { + String getText() { return text; } - public String getAuthor() { + String getAuthor() { return author; } - public void setText(String text) { - this.text = text; - } - - public void setAuthor(String author) { - this.author = author; - } } diff --git a/spring-boot/static/src/main/java/io/reflectoring/staticdata/QuotesProperties.java b/spring-boot/static/src/main/java/io/reflectoring/staticdata/QuotesProperties.java index d7ad443..ac790a7 100644 --- a/spring-boot/static/src/main/java/io/reflectoring/staticdata/QuotesProperties.java +++ b/spring-boot/static/src/main/java/io/reflectoring/staticdata/QuotesProperties.java @@ -7,15 +7,15 @@ import java.util.List; @Component @ConfigurationProperties("static") -public class QuotesProperties { +class QuotesProperties { private final List quotes; - public QuotesProperties(List quotes) { + QuotesProperties(List quotes) { this.quotes = quotes; } - public List getQuotes() { + List getQuotes() { return this.quotes; } diff --git a/spring-boot/static/src/main/java/io/reflectoring/staticdata/RandomQuotePrinter.java b/spring-boot/static/src/main/java/io/reflectoring/staticdata/RandomQuotePrinter.java index 95ce27c..741b5f9 100644 --- a/spring-boot/static/src/main/java/io/reflectoring/staticdata/RandomQuotePrinter.java +++ b/spring-boot/static/src/main/java/io/reflectoring/staticdata/RandomQuotePrinter.java @@ -10,13 +10,13 @@ import java.util.Random; @Configuration @EnableScheduling -public class RandomQuotePrinter { +class RandomQuotePrinter { private static final Logger logger = LoggerFactory.getLogger(RandomQuotePrinter.class); private final Random random = new Random(); private final QuotesProperties quotesProperties; - public RandomQuotePrinter(QuotesProperties quotesProperties) { + RandomQuotePrinter(QuotesProperties quotesProperties) { this.quotesProperties = quotesProperties; } diff --git a/spring-boot/static/src/main/java/io/reflectoring/staticdata/StaticApplication.java b/spring-boot/static/src/main/java/io/reflectoring/staticdata/StaticApplication.java index 1059ac6..bc6e285 100644 --- a/spring-boot/static/src/main/java/io/reflectoring/staticdata/StaticApplication.java +++ b/spring-boot/static/src/main/java/io/reflectoring/staticdata/StaticApplication.java @@ -2,7 +2,6 @@ package io.reflectoring.staticdata; import org.springframework.boot.SpringApplication; import org.springframework.boot.autoconfigure.SpringBootApplication; -import org.springframework.boot.context.properties.EnableConfigurationProperties; @SpringBootApplication public class StaticApplication {