From 86e84589804523112d5dfcbad5073f61cd0ee69d Mon Sep 17 00:00:00 2001 From: Tom Hombergs Date: Mon, 21 Jan 2019 06:36:50 +0100 Subject: [PATCH] minor changes --- .../web/RegisterRestControllerTest.java | 19 +++++++++++++++---- .../testing/web/ResponseBodyMatchers.java | 2 +- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/RegisterRestControllerTest.java b/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/RegisterRestControllerTest.java index a06cd87..1b2cef3 100644 --- a/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/RegisterRestControllerTest.java +++ b/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/RegisterRestControllerTest.java @@ -31,6 +31,17 @@ class RegisterRestControllerTest { @MockBean private RegisterUseCase registerUseCase; + @Test + void whenValidUrlAndMethodAndContentType_thenReturns200() throws Exception { + + UserResource user = new UserResource("Zaphod", "zaphod@galaxy.net"); + + mockMvc.perform(post("/forums/42/register") + .contentType("application/json")) + .andExpect(status().isOk()); + + } + @Test void whenValidInput_thenReturns200() throws Exception { @@ -107,10 +118,10 @@ class RegisterRestControllerTest { .andExpect(status().isOk()) .andReturn(); - UserResource expectedResponseBody = user; + UserResource expected = user; UserResource actualResponseBody = objectMapper.readValue(mvcResult.getResponse().getContentAsString(), UserResource.class); - assertThat(expectedResponseBody.getName()).isEqualTo(actualResponseBody.getName()); - assertThat(expectedResponseBody.getEmail()).isEqualTo(actualResponseBody.getEmail()); + assertThat(expected.getName()).isEqualTo(actualResponseBody.getName()); + assertThat(expected.getEmail()).isEqualTo(actualResponseBody.getEmail()); } @@ -154,7 +165,7 @@ class RegisterRestControllerTest { .param("sendWelcomeMail", "true") .content(objectMapper.writeValueAsString(user))) .andExpect(status().isBadRequest()) - .andExpect(responseBody().containsErrorMessageForField("name", "must not be null")); + .andExpect(responseBody().containsError("name", "must not be null")); } } \ No newline at end of file diff --git a/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/ResponseBodyMatchers.java b/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/ResponseBodyMatchers.java index b0c7711..0278c06 100644 --- a/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/ResponseBodyMatchers.java +++ b/spring-boot/spring-boot-testing/src/test/java/io/reflectoring/testing/web/ResponseBodyMatchers.java @@ -20,7 +20,7 @@ public class ResponseBodyMatchers { }; } - public ResultMatcher containsErrorMessageForField(String expectedFieldName, String expectedMessage) { + public ResultMatcher containsError(String expectedFieldName, String expectedMessage) { return mvcResult -> { String json = mvcResult.getResponse().getContentAsString(); ErrorResult errorResult = objectMapper.readValue(json, ErrorResult.class);