From 214ce71433810fafbf2eb5a6ff14faae2c716fd0 Mon Sep 17 00:00:00 2001 From: Cavero Barca Date: Tue, 10 Mar 2020 14:17:19 +0100 Subject: [PATCH] Keep only null as stripChar in the Apache Commons example --- .../src/main/java/com/baeldung/trim/LTrimRTrim.java | 7 ++----- .../java/com/baeldung/trim/LTrimRTrimUnitTest.java | 11 ++--------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/core-java-modules/core-java-string-operations-2/src/main/java/com/baeldung/trim/LTrimRTrim.java b/core-java-modules/core-java-string-operations-2/src/main/java/com/baeldung/trim/LTrimRTrim.java index 9ca1122441..9bf10e22cf 100644 --- a/core-java-modules/core-java-string-operations-2/src/main/java/com/baeldung/trim/LTrimRTrim.java +++ b/core-java-modules/core-java-string-operations-2/src/main/java/com/baeldung/trim/LTrimRTrim.java @@ -114,11 +114,8 @@ public class LTrimRTrim { // Apache Commons StringUtils containsIgnoreCase @Benchmark public boolean apacheCommonsStringUtils() { - String ltrim = org.apache.commons.lang3.StringUtils.stripStart(src, " "); - String rtrim = org.apache.commons.lang3.StringUtils.stripEnd(src, " "); - - ltrim = org.apache.commons.lang3.StringUtils.stripStart(src, null); - rtrim = org.apache.commons.lang3.StringUtils.stripEnd(src, null); + String ltrim = org.apache.commons.lang3.StringUtils.stripStart(src, null); + String rtrim = org.apache.commons.lang3.StringUtils.stripEnd(src, null); return checkStrings(ltrim, rtrim); } diff --git a/core-java-modules/core-java-string-operations-2/src/test/java/com/baeldung/trim/LTrimRTrimUnitTest.java b/core-java-modules/core-java-string-operations-2/src/test/java/com/baeldung/trim/LTrimRTrimUnitTest.java index f60340c238..3d8f8b382b 100644 --- a/core-java-modules/core-java-string-operations-2/src/test/java/com/baeldung/trim/LTrimRTrimUnitTest.java +++ b/core-java-modules/core-java-string-operations-2/src/test/java/com/baeldung/trim/LTrimRTrimUnitTest.java @@ -67,15 +67,8 @@ public class LTrimRTrimUnitTest { @Test public void givenString_whenCallingStringUtilsStripStartEnd_thenReturnsTrue() { // Use StringUtils containsIgnoreCase to avoid case insensitive issues - String ltrim = org.apache.commons.lang3.StringUtils.stripStart(src, " "); - String rtrim = org.apache.commons.lang3.StringUtils.stripEnd(src, " "); - - // Compare the Strings obtained and the expected - Assert.assertTrue(ltrimResult.equalsIgnoreCase(ltrim)); - Assert.assertTrue(rtrimResult.equalsIgnoreCase(rtrim)); - - ltrim = org.apache.commons.lang3.StringUtils.stripStart(src, null); - rtrim = org.apache.commons.lang3.StringUtils.stripEnd(src, null); + String ltrim = org.apache.commons.lang3.StringUtils.stripStart(src, null); + String rtrim = org.apache.commons.lang3.StringUtils.stripEnd(src, null); // Compare the Strings obtained and the expected Assert.assertTrue(ltrimResult.equalsIgnoreCase(ltrim));