From 27fd95fbf1007c6e1a99306f78a641e9dcdccc91 Mon Sep 17 00:00:00 2001
From: h_sharifi <h_sharifi@modernisc.com>
Date: Wed, 9 Nov 2022 11:55:20 +0330
Subject: [PATCH] #BAEL-5880:refactor test cases

---
 .../pdfinfo/PdfInfoITextUnitTest.java         | 35 ++++---------------
 .../pdfinfo/PdfInfoPdfBoxUnitTest.java        | 31 +++-------------
 2 files changed, 12 insertions(+), 54 deletions(-)

diff --git a/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoITextUnitTest.java b/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoITextUnitTest.java
index a0d04d23eb..ab980c2fb7 100644
--- a/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoITextUnitTest.java
+++ b/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoITextUnitTest.java
@@ -4,47 +4,26 @@ import org.junit.Assert;
 import org.junit.Test;
 
 import java.io.IOException;
-import java.util.HashMap;
+import java.util.Map;
 
 public class PdfInfoITextUnitTest {
 
     private static final String PDF_FILE = "src/test/resources/input.pdf";
 
     @Test
-    public void givenPdf_whenGetNumberOfPage_thenOK() throws IOException {
-        // given
-        int expectedNumberOfPage = 4;
-
-        // when
-        int actualNumberOfPage = PdfInfoIText.getNumberOfPage(PDF_FILE);
-
-        // then
-        Assert.assertEquals(expectedNumberOfPage, actualNumberOfPage);
+    public void givenPdf_whenGetNumberOfPages_thenOK() throws IOException {
+        Assert.assertEquals(4, PdfInfoIText.getNumberOfPages(PDF_FILE));
     }
 
     @Test
     public void givenPdf_whenIsPasswordRequired_thenOK() throws IOException {
-        // given
-        boolean expectedPasswordRequired = false;
-
-        // when
-        boolean actualPasswordRequired = PdfInfoIText.isPasswordRequired(PDF_FILE);
-
-        // then
-        Assert.assertEquals(expectedPasswordRequired, actualPasswordRequired);
+        Assert.assertEquals(false, PdfInfoIText.isPasswordRequired(PDF_FILE));
     }
 
     @Test
     public void givenPdf_whenGetInfo_thenOK() throws IOException {
-        // given
-        String expectedProducer = "LibreOffice 4.2";
-        String expectedCreator = "Writer";
-
-        // when
-        HashMap<String, String> info = PdfInfoIText.getInfo(PDF_FILE);
-
-        // then
-        Assert.assertEquals(expectedProducer, info.get("Producer"));
-        Assert.assertEquals(expectedCreator, info.get("Creator"));
+        Map<String, String> info = PdfInfoIText.getInfo(PDF_FILE);
+        Assert.assertEquals("LibreOffice 4.2", info.get("Producer"));
+        Assert.assertEquals("Writer", info.get("Creator"));
     }
 }
diff --git a/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoPdfBoxUnitTest.java b/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoPdfBoxUnitTest.java
index 0d1d0ddf83..5d5048dece 100644
--- a/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoPdfBoxUnitTest.java
+++ b/pdf-2/src/test/java/com/baeldung/pdfinfo/PdfInfoPdfBoxUnitTest.java
@@ -11,40 +11,19 @@ public class PdfInfoPdfBoxUnitTest {
     private static final String PDF_FILE = "src/test/resources/input.pdf";
 
     @Test
-    public void givenPdf_whenGetNumberOfPage_thenOK() throws IOException {
-        // given
-        int expectedNumberOfPage = 4;
-
-        // when
-        int actualNumberOfPage = PdfInfoPdfBox.getNumberOfPage(PDF_FILE);
-
-        // then
-        Assert.assertEquals(expectedNumberOfPage, actualNumberOfPage);
+    public void givenPdf_whenGetNumberOfPages_thenOK() throws IOException {
+        Assert.assertEquals(4, PdfInfoPdfBox.getNumberOfPages(PDF_FILE));
     }
 
     @Test
     public void givenPdf_whenIsPasswordRequired_thenOK() throws IOException {
-        // given
-        boolean expectedPasswordRequired = false;
-
-        // when
-        boolean actualPasswordRequired = PdfInfoPdfBox.isPasswordRequired(PDF_FILE);
-
-        // then
-        Assert.assertEquals(expectedPasswordRequired, actualPasswordRequired);
+        Assert.assertEquals(false, PdfInfoPdfBox.isPasswordRequired(PDF_FILE));
     }
 
     @Test
     public void givenPdf_whenGetInfo_thenOK() throws IOException {
-        // given
-        String expectedProducer = "LibreOffice 4.2";
-        String expectedCreator = "Writer";
-
-        // when
         PDDocumentInformation info = PdfInfoPdfBox.getInfo(PDF_FILE);
-
-        // then
-        Assert.assertEquals(expectedProducer, info.getProducer());
-        Assert.assertEquals(expectedCreator, info.getCreator());
+        Assert.assertEquals("LibreOffice 4.2", info.getProducer());
+        Assert.assertEquals("Writer", info.getCreator());
     }
 }