BAEL 2330

* Implementing Hexagonal Architecture in java

* Removing duplicates from a string

* Fix for the code review feedback
- removing the hexagonal architecture code
- removing the methods removeDuplicatesUsingCharArray
- adding some meaningful sentences to test

* Fix for the code review feedback
- fix for removeDuplicatesUsingCharArray
- adding unit testing
- adding brackets around for loops

* Fix for the code review feedback

* Adding remove duplicates using java 8 distinct
adding assets to the unittests to test for empty strings

* Checking for empty strings in unit tests
Adding an if statement to check whether an empty string is passed to removeDuplicatesUsingSorting method
This commit is contained in:
kyleandari
2018-11-23 10:46:20 -05:00
committed by Emily Cheyne
parent 9127733ad1
commit 58a536c395
2 changed files with 40 additions and 9 deletions

View File

@@ -44,16 +44,16 @@ public class RemoveDuplicateFromString {
}
String removeDuplicatesUsingSorting(String str) {
char[] chars = str.toCharArray();
Arrays.sort(chars);
StringBuilder sb = new StringBuilder();
sb.append(chars[0]);
for (int i = 1; i < chars.length; i++) {
if (chars[i] != chars[i - 1]) {
sb.append(chars[i]);
if(!str.isEmpty()) {
char[] chars = str.toCharArray();
Arrays.sort(chars);
sb.append(chars[0]);
for (int i = 1; i < chars.length; i++) {
if (chars[i] != chars[i - 1]) {
sb.append(chars[i]);
}
}
}
@@ -90,6 +90,13 @@ public class RemoveDuplicateFromString {
return sb.toString();
}
String removeDuplicatesUsingDistinct(String str) {
StringBuilder sb = new StringBuilder();
str.chars().distinct().forEach(c -> sb.append((char) c));
return sb.toString();
}
}