mindol1004/spring-boot-rest
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BAEL-639: Fixing failing test

Browse Source
This commit is contained in:
slavisa-baeldung
2017-02-18 07:31:10 +01:00
parent 5f0f26e374
commit 6c282a742c
21 changed files with 265 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core-java/src/test/java/com/baeldung/test/comparison/DivisibilityTest.java → core-java/src/test/java/com/baeldung/junit4vstestng/DivisibilityTest.java
View File

@@ -1,4 +1,4 @@
package com.baeldung.test.comparison;
package com.baeldung.junit4vstestng;
import static org.junit.Assert.assertEquals;
@@ -15,7 +15,7 @@ public class DivisibilityTest {
}
@Test
public void givenNumber_whenDivisiblebyTwo_thenCorrect() {
public void givenNumber_whenDivisibleByTwo_thenCorrect() {
assertEquals(number % 2, 0);
}
}

28
core-java/src/test/java/com/baeldung/test/comparison/MyParameterisedUnitTest.java → core-java/src/test/java/com/baeldung/junit4vstestng/MyParameterisedUnitTest.java
View File

@@ -1,7 +1,4 @@
package com.baeldung.test.comparison;
import java.util.Arrays;
import java.util.Collection;
package com.baeldung.junit4vstestng;
import org.junit.Assert;
import org.junit.Before;
@@ -10,16 +7,13 @@ import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
import java.util.Arrays;
import java.util.Collection;
@RunWith(value = Parameterized.class)
public class MyParameterisedUnitTest {
private String name;
private NameCheck nameCheck;
@Before
public void initialSetup() {
nameCheck = new NameCheck();
}
public MyParameterisedUnitTest(String myName) {
this.name = myName;
@@ -27,23 +21,13 @@ public class MyParameterisedUnitTest {
@Parameters
public static Collection<Object[]> data() {
Object[][] data = new Object[][] { { "Peter" }, { "Sam" }, { "Tim" }, { "Lucy" } };
Object[][] data = new Object[][]{{"Peter"}, {"Sam"}, {"Tim"}, {"Lucy"}};
return Arrays.asList(data);
}
@Test
public void givenName_whenValidLength_thenTrue() {
boolean valid = nameCheck.nameCheck(name);
boolean valid = name.length() > 0;
Assert.assertEquals(valid, true);
}
}
class NameCheck {
public boolean nameCheck(String name) {
if (name.length() > 0)
return true;
return false;
}
}

2
core-java/src/test/java/com/baeldung/test/comparison/StringCaseTest.java → core-java/src/test/java/com/baeldung/junit4vstestng/StringCaseTest.java
View File

@@ -1,4 +1,4 @@
package com.baeldung.test.comparison;
package com.baeldung.junit4vstestng;
import static org.junit.Assert.assertEquals;

2
core-java/src/test/java/com/baeldung/test/comparison/SuiteTest.java → core-java/src/test/java/com/baeldung/junit4vstestng/SuiteTest.java
View File

@@ -1,4 +1,4 @@
package com.baeldung.test.comparison;
package com.baeldung.junit4vstestng;
import org.junit.runner.RunWith;
import org.junit.runners.Suite;

9
core-java/src/test/java/com/baeldung/test/comparison/SummationServiceTest.java → core-java/src/test/java/com/baeldung/junit4vstestng/SummationServiceTest.java
View File

@@ -1,8 +1,4 @@
package com.baeldung.test.comparison;
import java.security.Security;
import java.util.ArrayList;
import java.util.List;
package com.baeldung.junit4vstestng;
import org.junit.After;
import org.junit.AfterClass;
@@ -12,6 +8,9 @@ import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;
import java.util.ArrayList;
import java.util.List;
public class SummationServiceTest {
private static List<Integer> numbers;

46
core-java/src/test/java/com/baeldung/test/comparison/DependentTests.java
View File

@@ -1,46 +0,0 @@
package com.baeldung.test.comparison;
import org.testng.Assert;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
public class DependentTests {
private EmailValidator emailValidator;
private LoginValidator loginValidator;
private String validEmail = "abc@qwe.com";
@BeforeClass
public void setup() {
emailValidator = new EmailValidator();
loginValidator = new LoginValidator();
}
@Test
public void givenEmail_ifValid_thenTrue() {
boolean valid = emailValidator.validate(validEmail);
Assert.assertEquals(valid, true);
}
@Test(dependsOnMethods = { "givenEmail_ifValid_thenTrue" })
public void givenValidEmail_whenLoggedin_thenTrue() {
boolean valid = loginValidator.validate();
Assert.assertEquals(valid, true);
}
}
class EmailValidator {
public boolean validate(String validEmail) {
return true;
}
}
class LoginValidator {
public boolean validate() {
return true;
}
}

81
core-java/src/test/java/com/baeldung/test/comparison/MyParameterisedUnitTestNg.java
View File

@@ -1,81 +0,0 @@
package com.baeldung.test.comparison;
import org.testng.Assert;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Parameters;
import org.testng.annotations.Test;
public class MyParameterisedUnitTestNg {
private PrimeNumberCheck primeNumberChecker;
@BeforeClass
public void intialSetup() {
primeNumberChecker = new PrimeNumberCheck();
}
@Test(enabled = false)
@Parameters({ "num", "expectedResult" })
public void givenNumber_ifPrime_thenCorrect(int number, boolean expectedResult) {
Assert.assertEquals(expectedResult, primeNumberChecker.validate(number));
}
@DataProvider(name = "test1")
public static Object[][] primeNumbers() {
return new Object[][] { { 2, true }, { 6, false }, { 19, true }, { 22, false }, { 23, true } };
}
@Test(dataProvider = "test1")
public void givenNumber_whenPrime_thenCorrect(Integer inputNumber, Boolean expectedResult) {
Assert.assertEquals(expectedResult, primeNumberChecker.validate(inputNumber));
}
@Test(dataProvider = "myDataProvider")
public void parameterCheckTest(User user) {
Assert.assertEquals("sam", user.getName());
Assert.assertEquals(12, user.getAge());
}
@DataProvider(name = "myDataProvider")
public Object[][] parameterProvider() {
User usr = new User();
usr.setName("sam");
usr.setAge(12);
return new Object[][] { { usr } };
}
}
class PrimeNumberCheck {
public Object validate(int number) {
for (int i = 2; i < number; i++) {
if (number % i == 0)
return false;
}
return true;
}
}
class User {
private String name;
private int age;
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
public int getAge() {
return age;
}
public void setAge(int age) {
this.age = age;
}
}

11
core-java/src/test/java/com/baeldung/test/comparison/RegistrationTest.java
View File

@@ -1,11 +0,0 @@
package com.baeldung.test.comparison;
import org.testng.annotations.Test;
public class RegistrationTest {
@Test
public void givenEmail_ifValid_thenCorrect() {
}
}

12
core-java/src/test/java/com/baeldung/test/comparison/SignInTest.java
View File

@@ -1,12 +0,0 @@
package com.baeldung.test.comparison;
import org.testng.annotations.Test;
public class SignInTest {
@Test
public void givenUsername_ifValid_thenCorrect() {
}
}

94
core-java/src/test/java/com/baeldung/test/comparison/SummationServiceTestTestNg.java
View File

@@ -1,94 +0,0 @@
package com.baeldung.test.comparison;
import java.util.ArrayList;
import java.util.List;
import org.testng.Assert;
import org.testng.TestNG;
import org.testng.annotations.AfterClass;
import org.testng.annotations.AfterGroups;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.BeforeGroups;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
public class SummationServiceTestTestNg extends TestNG {
private List<Integer> numbers;
private int testCount = 0;
@BeforeClass
public void initialize() {
numbers = new ArrayList<>();
}
@AfterClass
public void tearDown() {
numbers = null;
}
@BeforeMethod
public void runBeforeEachTest() {
testCount++;
}
@AfterMethod
public void runAfterEachTest() {
}
@BeforeGroups("negative_tests")
public void runBeforeEachNegativeGroup() {
numbers.clear();
}
@BeforeGroups("regression")
public void runBeforeEachRegressionGroup() {
numbers.add(-11);
numbers.add(2);
}
@BeforeGroups("positive_tests")
public void runBeforeEachPositiveGroup() {
numbers.add(1);
numbers.add(2);
numbers.add(3);
}
@AfterGroups("positive_tests,regression,negative_tests")
public void runAfterEachGroup() {
numbers.clear();
}
@Test(groups = "positive_tests", enabled = false)
public void givenNumbers_sumEquals_thenCorrect() {
int sum = numbers.stream().reduce(0, Integer::sum);
Assert.assertEquals(sum, 6);
}
@Test(groups = "negative_tests")
public void givenEmptyList_sumEqualsZero_thenCorrect() {
int sum = numbers.stream().reduce(0, Integer::sum);
Assert.assertEquals(0, sum);
}
@Test(groups = "regression")
public void givenNegativeNumber_sumLessthanZero_thenCorrect() {
int sum = numbers.stream().reduce(0, Integer::sum);
Assert.assertTrue(sum < 0);
;
}
@Test(groups = "sanity")
public void givenNumbers_doSum() {
}
@Test(expectedExceptions = ArithmeticException.class)
public void givenNumber_whenThrowsException_thenCorrect() {
int i = 1 / 0;
}
}

11
core-java/src/test/java/com/baeldung/test/comparison/TimeOutTest.java
View File

@@ -1,11 +0,0 @@
package com.baeldung.test.comparison;
import org.testng.annotations.Test;
public class TimeOutTest {
@Test(timeOut = 1000, enabled = false)
public void givenExecution_takeMoreTime_thenFail() {
while (true)
;
}
}

10
core-java/src/test/resources/parameterised_test.xml
View File

@@ -1,10 +0,0 @@
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="My test suite">
<test name="testing">
<parameter name="num" value="2"/>
<parameter name="expectedResult" value="true"/>
<classes>
<class name="com.baeldung.test.comparison.MyParameterisedUnitTestNg"/>
</classes>
</test>
</suite>

13
core-java/src/test/resources/test_group.xml
View File

@@ -1,13 +0,0 @@
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="regression_test">
<test name="testing">
<groups>
<run>
<include name="sanity" />
</run>
</groups>
<classes>
<class name="com.baeldung.test.comparison.SummationServiceTestTestNg" />
</classes>
</test>
</suite>

9
core-java/src/test/resources/test_suite.xml
View File

@@ -1,9 +0,0 @@
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="Evaluation_Suite">
<test name="Sanity">
<classes>
<class name="com.baeldung.test.comparison.RegistrationTest" />
<class name="com.baeldung.test.comparison.SignInTest" />
</classes>
</test>
</suite>