From 729c392019658fad952734acd0faf2a5ec0c58c6 Mon Sep 17 00:00:00 2001 From: Yasin Bhojawala Date: Sun, 29 Oct 2017 19:16:42 +0530 Subject: [PATCH] BAEL-1217 fixed failing tests --- .../org/baeldung/converter/GenericBigDecimalConverter.java | 3 +-- .../test/java/org/baeldung/converter/CustomConverterTest.java | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/spring-boot/src/main/java/org/baeldung/converter/GenericBigDecimalConverter.java b/spring-boot/src/main/java/org/baeldung/converter/GenericBigDecimalConverter.java index e96dbeaf47..7be038910b 100644 --- a/spring-boot/src/main/java/org/baeldung/converter/GenericBigDecimalConverter.java +++ b/spring-boot/src/main/java/org/baeldung/converter/GenericBigDecimalConverter.java @@ -32,8 +32,7 @@ public class GenericBigDecimalConverter implements GenericConverter { } else { Number number = (Number) source; BigDecimal converted = new BigDecimal(number.doubleValue()); - converted.setScale(2, BigDecimal.ROUND_HALF_EVEN); - return converted; + return converted.setScale(2, BigDecimal.ROUND_HALF_EVEN); } } } diff --git a/spring-boot/src/test/java/org/baeldung/converter/CustomConverterTest.java b/spring-boot/src/test/java/org/baeldung/converter/CustomConverterTest.java index 8446196758..faa6baffbb 100644 --- a/spring-boot/src/test/java/org/baeldung/converter/CustomConverterTest.java +++ b/spring-boot/src/test/java/org/baeldung/converter/CustomConverterTest.java @@ -44,7 +44,7 @@ public class CustomConverterTest { @Test public void whenConvertingToBigDecimalUsingGenericConverter_thenSuccess() { assertThat(conversionService.convert(Integer.valueOf(11), BigDecimal.class)). - isEqualTo(BigDecimal.valueOf(11)); + isEqualTo(BigDecimal.valueOf(11.00).setScale(2, BigDecimal.ROUND_HALF_EVEN)); assertThat(conversionService.convert(Double.valueOf(25.23), BigDecimal.class)) .isEqualByComparingTo(BigDecimal.valueOf(Double.valueOf(25.23))); assertThat(conversionService.convert("2.32", BigDecimal.class))