From f1359b620f96277921b1b1572b40ed6eefe09605 Mon Sep 17 00:00:00 2001 From: Philippe Date: Tue, 28 Jul 2020 10:26:00 -0300 Subject: [PATCH 1/9] [BAEL-4381] Intro to ArchUnit --- .../article-resources/archunit/figure1.drawio | 1 + .../article-resources/archunit/figure1.png | Bin 0 -> 15103 bytes libraries-testing/pom.xml | 14 ++- .../smurfs/persistence/SmurfsRepository.java | 49 ++++++++++ .../smurfs/persistence/domain/Smurf.java | 64 ++++++++++++ .../smurfs/presentation/SmurfsController.java | 27 +++++ .../smurfs/service/SmurfsService.java | 41 ++++++++ .../archunit/smurfs/service/dto/SmurfDTO.java | 64 ++++++++++++ .../archunit/smurfs/SmurfsArchUnitTest.java | 92 ++++++++++++++++++ 9 files changed, 349 insertions(+), 3 deletions(-) create mode 100644 libraries-testing/article-resources/archunit/figure1.drawio create mode 100644 libraries-testing/article-resources/archunit/figure1.png create mode 100644 libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java create mode 100644 libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java create mode 100644 libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java create mode 100644 libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java create mode 100644 libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java create mode 100644 libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java diff --git a/libraries-testing/article-resources/archunit/figure1.drawio b/libraries-testing/article-resources/archunit/figure1.drawio new file mode 100644 index 0000000000..859d9946a1 --- /dev/null +++ b/libraries-testing/article-resources/archunit/figure1.drawio @@ -0,0 +1 @@ +7VjbctowEP0aP9LBNgb3sSa3BzJNJ+2kk5eMsBdbrax1ZUEgX1/Jlm84YWgbKL3wwFhHa3l99pyVwHKn6fpSkCy5xgiY5QyjteWeWY7jj331rYFNCXjOsARiQaMSshvglj6BAauwJY0g7wRKRCZp1gVD5BxC2cGIEPjYDVsg6z41IzH0gNuQsD56RyOZGNQev20mroDGiXm070zKiTkJv8YCl9w8jyOHciYl1TLmHfOERPjYgtxzy50KRFlepespMM1qxVh538ULs3XKArjc54YrsrkffLj+Bp8ePr+/GTw409XdwKyyImxpqEg3JMsYDYmkyE3mclMRpV4i05eaYRCWGyyQy1szb6txnpGQ8vgjZhoYKkSSecXpyIxrKu1RCdxgTovnuWcMFmomSGTKzJIrEFLlw94xGusIqdcOiBmZeJ3HBUkp0wqcLUMaEZX5FHmOOreAkTmwoK7WFBmK4pXcRfHRS1DGWvhF8VF4n+iKNZUYrFuQIf4SMAUpNiqkmvWMCIw/7EoUj43aJr7BkpbQRq4BiVF4XK/dlFpdmGr/QOUnvcpbzpikmlomi7dujyLIgEd5DcadEDPa0gpEymNmiEImGCMn7LxBg6IUoLPUwmhiZljKR4FfQMqNaRhkKbErjYjkSXG//ToSeLHUOS5FCDvodE3XIiIGuSPOK+M0NzuFI4ApB666/enVReD2RJCDWNEQTsL4bUMWjbXn+udbwyGFsL/nPX/L837f8874Gc/bB/P8+N/26GhPj7on5VH/KI16ponvFq7yWqiILiy/7baURlGpEcjpE5kX62mVZEi5LHjwAss7O1Tdd2m859P68Gjy7JzCnvPvYPhG7dOmX+9darPcjWagtf9POq1gYHvdFXCxyJUkt6VSJ/Xz6hn11JOpaikKT+d892e3eXuyR5v3jtrmvX7NQeQ0l8BPZGc/Vn0PeKTf3t5Hw9++vVe/pk/Z7P+d/UsV7v9eP6UD+19o64Oe2tWw+f+n3PGbv9fc8+8= \ No newline at end of file diff --git a/libraries-testing/article-resources/archunit/figure1.png b/libraries-testing/article-resources/archunit/figure1.png new file mode 100644 index 0000000000000000000000000000000000000000..8bd8e9647b07a46e7d8e363ba750fa838c07debb GIT binary patch literal 15103 zcmeHuc{tQ<`!|!aCCZxaiWU??4JzA2%1$bhEV+xUlZdQi?(QfQg)oDmP*PO3vW;$~ z&DcivF)eq)*hXd;X3Wg*`l9qa@AEvzd%W-OIDW@_y!|=X_xnAs>pZV>|D1Ep&gQU~ zh`b0NAD@`H*+F|gz7=A8eEg+CtH8?o2m93c_!Rie4<0yn$#tA`;Qq$$Fuspk7LRJ}y$E9$XWZVd&If0KKCLkoCfQUg%!;;|ELCgtKO^VC# z)+GH~N_%_fGUdKM=R^0cgo{;p^{^IRU-(XKN3QpYb#48^5P^l2&Rx0Q_YE4m4ln)$ z>+a_K){VDf25o+<7{LiC)xPwV69wcjaAoUlg_ zA8*U8lKio9-vvRmi->)c^n;0pTQE%QcK*8TA1jD)u+q23FKUrXX#KWS8(d9zczk)q zNA}Vg_RM%Fa0%yppJw$MP$?g~rHueCB*w?CMdtzz?DD!^C$?zS){| zPJUBIOaHQD9{w3qczSz>-_2zTn_P3R7Jh2Z+(Wn~sq9&-fBqvP=+j?UJV(18m62q5BiB<{}tNSjg5Y)G{vRMk+^T}ZcR)Mn47D?vuh}__*v7MrlFjO zl6~Qfb8IqoCYN~6wu+}0JwMx=t9R@knf&DU!$E()xv6bP8YTA7YUws9+_}!6p%#K` z(DcX$&+ZbJ@$rMU`ri%)eSMckVNH*Yo%wdVL&`t^2j!`sthCz#dD{O$rRpjUbc zf#ZD@p5*!{(IIWr=+W>a)en*>`*=A4F>r3Be}7-`rqNe*K|?k{V?9r_eaE}#bR4fX z3OU7jYa6|LL*s`;4A;j=bV>HPo6r%M*x+H*NYTAMX)cG%i|XGNEM~&0vrONmEvw<` z7cwyr)~d*@V-ETnau~$QqTw}kssVL+a}=ZfVV+ss1cO(T>`^czIT%SNP_D?jp2HnB z6C8DP4J!zn>Gh(88GeecQl1v4atiZ&h2j_X3wxiV|d^Y zxf@whKm7XTZ1nt=VT{0gog(U{nhBW7Zz`)3O; za~<)l4>K}%7(~*Ilz_51ATrKOKYQY1tt&BkO$#Y4*3{aBcRPE)+64cWO1{vEYGa)) zfuEEAto!up4?S)a);~|wL}{OHKOW2F*SD@iMc6adqpQ=6NHeMRfwqJ}QL|GZ(ekHH%7ND;wj}i~J2E-owlu>W$aRmsnTyy$P0aaJMGN{1kgV#-eL`#lcCR0Rk3y>2S0@HiEOfgOfOB@hA7S^|a9Dmd1B)0@l;0ijg&TyGUU zl&39tk|veG%8MMKJHNI5y^Z953-@vT@WoVc$>7j1rb&k(P5K}m@pb{2%?cP+SH z5QN>guUw?(aDjLN4q~`4h~b~`y1Y4^+;PYKbjsqRZ zn?YJy`@PZSQIK3p{*dn9eb=oO(i>W`^{~L@Z|gqaq&SIy8G3EH`aVJUnEFS$ic;NW zxLEz^YvwsB0!>nr%t))KC*wvDK;||GgR8xwm{>WlBSOcNbIlynJMPGw;Yp|MO4+V? zKPFsLh30qO+9a_|Mc{#?U4F5p_Yu*jym*WBx9jANAq?bF9f=Z+HGAJ(5tYSkJ$wT$ zxaPNW9VjHJ`eHNns`bY_0V!&n2ffe=cC;52Ix*mVW20VImR@Mdz9?33(ERK-D^>Vv zei&9d!@{6vEYdP6TUAVScj%X<>y)-U6T+7yBW^<+>+GQOh|+G_2PwOJ$33*8P8A&8 zG^-3j^tY9rmot7lCl43X(z8w-0eg+upX~f&41cHN>{EeN(stsjzGjOVo+F+IX%%Ji zQzJprR=@q!^9u#fqdDOlW{2DF5_-$Lu%YCrs<5H#(7yiQdNzqxiK>iXPEbC-O0Z@P zm36dc?(xD%D%&(G4b(B|twzY#^^tQ^W33b<(}`Axto?R~-pZSAC8XCg3MkXvZb&k2 zkUi6ntoqh*mNJLiHPMRV(r0!athy~2hK#Q{r|w+o=iTU16Y{9H3Q5MaIhMNm&rFc| zTYTHINP|*zS<}>rl~Ud{9#&{BcQjybtaWI9jy~>nkVP%wV~&PAcvKTI?&Fp+f?}yr z4Q)I8549RFPqDrFtB^>eQv2))L!u#jtZXLe^WSe%d<`$Nw7QF_By}rJKc+gYrp~*0 z^-8(B5R z1H6mO!Rh!h&LH-4a2&IjwsG>6MmBRlZJy8@${61wg67HE<&Vc|t*qvB8@*xT&yP?lUHz@A zaP@N(EJ0MGwk=wzph?jnX>y+4sw*hI$&Xj#d#G9iS>0#Ad%lMkMnuX{@IscTE~H#X zkK5ckM^D^#mxo&ZuaxXCF|Btq60g9;sLq)s8KJMVrAZt0LdvZh?_5SP547QLwefT) z&SX{>2072Z5^|SW7-&y?e1E+;SaTg}#1d+6a|C;{5=gq(=T9=!k9FITkS$vM zrcyA>st9*^7{|mIuf!bn!BFoMOHi4_)Acnc+jxm1r6p`NbH@#?5#tq5nB< zmk-x5Yeb&3zreHkMhr8mop0Q(>&W%K+B=v^dXB0$i3 zt!}l&P1h7djgAk)!8P^|*mP@iCWf27pF?(L%ynstQ7zEBJ+`wf%rcLc{9VU z+_BcKIs@rk-2CSo#h-<9=pS4-+!057pJ759YK=eFGM@k!qdTtDp_?AN zK-JZx)4sKq-*_JMvgAm^&=D(#MocXCLiJ_ZeAQ^e?b>07Tn53KMKwB>6i--;y{O0(%&XDrU{~`{ai+MW#<%M; z5mAtNT#)a8GkDY2GR|Hzj%jFv#WULeYQp1UI9@0Tg*M^)f?5#=h!S7aM9}}i^GK8l z9DxE6;^rn37b~(_-wFYtX3<&w_+H8X(a(pM05u=wD*=jx}=&bSFX?LG|Cf{h%=Dih56{h_I%U0Tc*m*e{r zoD(^Yr`}m*G`Pb?UbvV0t_q2;|Mvmq|7Kq=d5`~>_kHMdvmR97^l>DrCT#kHBQ{$v z^v11jz0e8x>l+(=bD~*PPugJJ-R9F{xy9AIrVv?NgA^14AD)x<$N~b-Zg?Q$ZQTg3 zoO&>U_a4TsM0-PeI@bn&xi`T$cRyM_KA6?S1#y7@%A=sxEPw*|R>!M6R z5%TN%bgVKi@+oIJDVlM2#(-4C9csz;Me#;H6pvT&WOto97d>6k%b~f&*=`_iJNqy*HG{avU+w=hkIBfOK{JcU@JfGrPB9y1+6W zlOU^6;w@L*I7h(h_Fv|J(i6+*gZz9PGx#I7CA5BzuRKeT&hVmE7E}#}7l+a6n3!%i zRNY42dpGWd2)*|1`k9K5MBnZbZ6glVw*OEbs<<7r05B$TYqS?4j#}MBcIcot_Bxaz z%rS_z{bXA)Yk6f3v&5ywlVFV*oo@{vwF(-4z0?2l?RuUCUB?Y}RK`x+i7Zn8ztYeaosS^?qRAAp$tF*w{ z-Dx%AMTY1d2_ID4*hyqp_v5OWkGkRcs^TD#YErWa^=(f=&3}o=am+wE4CEXmxfzIV zLAZmRTJPSvRphO*!+qCnSbhRYl6F0B%W^QO}AS)7z&y0|eDX=_o6 zzwp(9T|d{4Vu>5yD<7oIv$4wIuH?|$tNGy_2 z(9A%H;SOK^bmq4c#N@R^I{^oC#LaqC#nY~6aSpG*&9Ov&C$>@)6`nO z)KyzFo%m6$%2-TVMh2&9op+@f47<)wT<29eBLPHacpksd!$J@SF=0t3r^TZuFH@3u zvq@Nu=x+(4CVi+QnG$ggjDSTvjmnlq$GS_IkGHJn-yfe~aQ?Ww!h z!|sXz_UHd0fSIcg#~IC^rhiV*(BaXIc*Oj=5U7DhxXjTl3eH@OJ_2@;i~erKP$@zE zTc-TtXcxteH|^FR7WGNg?F3Ojl4|K@A^ycWphf9m45Ah!a&kf6KQeoDm%ZQ@Qj-^CrN6#C^otx++ zm-bc(Mx_^iI`FDChY#(5xLLV2R;H)Y-#G|W2s(+XVkW*DaERv%;s4%u1C9^AxFfss zkB&WJWFD8N z8DM!LljCT7yZI&}5fC04%Z!!t1?A*+P)??`e3tp0C!M}qQb{udl#_Df7&PhEzCYKe zzvTRr#{bf*Uv~7%Z~Xu1Ck3AycmphtaD9WWhl7F$KkTm1*ue9$xxZ6v4_#AN;m7S+ zj9s9&Q>ST0l-P3-l-3Y1i9RkfDMsJvMee%`V2<|BpO;V$Cjq#albo2b`%%zovDOM( zyNI}GYNL z&AI^^+xwquN-iSCANd9Jg*bdCTrK_yZcf~q>n-=%rSk*8d>?uaKEf;zmeTk*lmGeX zIsTPkI}wZ9MeBZ`te{~))QqhL4e|vB!MR1&wZWxQ)sAil{DPlcw}x@^kQL~?0L0F! zFk5^Nafn~s*y|-+3M~dWuM}Ej*DfD)u-}wt2Im1jjU~PMvfd8p@bSr4L$d%2AG&{7 z339~|y$04+AitY^9?K|^iX8yA-8-xnI^zq6K>%`!_ReaHEGuAR`coE~5V3%|*tOav z%qinej9}iq4C$Z;#{mIf&qs?8|1k)d*MD(acL#vu^E*!OUOae%Cv*U(9i>|z*8+)# znQZ;ewvfdAlYqd*aP=EME~8-zZ1q*_`l2L+5*2_L*S1|bqhKYwh+hh~GB06&Sv z*A{q#i$Pilo!brvz8ZO7ByH{3kQPg&G&L`&BU|W_MBj{p1V}iqmdPw>(HoUq?>ASy zRbU&00L8V76m!jhCP`=Nr0hBdxIFjS>IZ5Xg8-n3qQ%MImbbnFjv`{6<-IU^fIcpJ zKBD6Rjc+swDAhrq1k**ypOKtY2-dM!v9<@?++)R?vP+UY3f{8PQl%U#2IA;yJ}JA% z17tl`K%7>|u|M#61-pNECnL9EyuS*IM6vq`#ijLqz$SxI*AG4qy0;xSY#k!zf zzVYmuKh~*O11?TBHK#8~NJpQ>(X*T#*iwBRBH6!=n^uwNpQ8K+Ip8F(Y zE~mRiKMxzP=wQ`f<-(!^7^0jP#bQt?v){fz&ID6Mj;@)b=;HS!1aar* zbV7_;Km~<;y(!}1zQE5f)f{vkP;0zevb;eD0yz+*eJ3G>`?fp4P`q?FTi~5U8$9)< za@n>8ZA)2aCOEQ$?4KfP2FKB{y2wgFHt2BcP%HF8#?Fb;s12NKTBH|f>xxsTtsVZB z$hv6<`d|c2yA;n2*W;$+=fBQ`+$oJ3_Z^o5{?0d=MZ{HJH|9Cq_3y9Lj$5`}LF(SpK0;casc#P^z3TmU&=}2`WCN zWE}(5A$`RlVy4_tzFL)!B#oAJi+mDBElBrl)oeB*wq5UbNy}&@-8pnW!rI4bX1u@q zA#?B~6MgYf4lvp23jwbdY#Bg4)hjN9KBgJH8PJvla8QQJX|n@5KJr}=D*LbNlHtMl z3Ag9N8fX4pvmx$}86}t`q^+7e3J)$Qb)j0@&s_#{x^3L#VbC_oaZboVap!v3_A8R3 zJ02NxaEw75XUuE-ktq(WkA>V})SB$Se~)>w%IG4^xzyXtansX&MgA3ihiey7(yu;nM;hmIG}VJk2o;DXI7b;A!Dw#`F5qZt6x8wru{20QAw@6uGq z*%Ty?Y9y3xMhlIw_mQt|+G>!<={#y%;bi8xuX;$qK9NDh-}-o9I9{i?Kn-A>CopY% zi#`t#fSyCn2PGl(VFH`15X4D$S6Ayr8x{Z_0+xJ5VUiCRj$p%-{jv`z243XEtB1~e zmd#fXXsABl?eyj7al#aM!kwNZ%%Ue;38T81?hl(fvr_em0E{RLL~C@|(`<1sH3_r0 z4A4z}s)$fPAczt%YD;59$!-W@GP(1rK$m12yl2DGp>M(hY?K05FF&k!7jVD@*Cv@ZsF}SNaDbA3 z8I$2+*tDtru=fCMzpV?0Es9$64{!yC5V9A}0xGK5a8cz2d7l-Y|0rm5&Nb|78U<>< zV2wCLqik#LkERgnn=Gmw>LscA9`Uryl>pbOcx|`!f~X&lz<695Z_tlaT`^bT#;%~W zAKvUAO=Cuv&b>y>zor0en}FhUqqG5H8c;v`N~2_d%Cw~1L7)Ue#RnESMk@-`^EfnJ z6kQiZoF77Qhx}$WB0q@|Lh)=8rIb5T8Y|>&1rxv&w!?c?ElFPsM)hfg5OrPNx6M2) zEFC%DgaoZb4c_OSCR$GL_H}^E?Vg0Jg*_TXL>Z+z&)z-$Yr~5U6YwN&;E$!teJ`^3 zb|A_UNi4yhD8NX6`!NNrx#9<>xvGp_>{yQ zPQu_h{rG7$lREFpr@}y;l~Pw9g~BqLARNgVbwe7?e!NVmyY#2yIG6$q<8hdWuc~bW z*Alz74Ziw|&oM}ta&`()mq?(;-XQc|%wT#>y=p&A3E?gcPFtLD(H9sa;uGwsQL1fJ z^p$&LhOmU(0U$+Kbux68$5{=X;$M&A$QM|HU@T%M$T%FdM!Ud}5c;pBISUb6JXKNw zXhGp=U^0+c-1jXFXMAPUVL>tuCAl75kD!$Cil`OG&Tx88IwzW_jBpnKDk?N=40)=C z3rmN1PmRz8-r*;|CL+5yfT60-DYT7g5CXCS=^Ye+(O;K_M{X0D0bm~E2(Z_9rz&XJ zLu!}iw8>oOkmDtmHI5Ix7FgcaTv2n#^Sl>cJcRl^8c9It;T>>t>9PO<;8*3;;y_2~ zBm-;658Dd-F3{|S2zpy`X&A+ZTq7*;vq!ai)y!=m3P{0(1bf(%m9^x1E7< z_P?MutN>_$fUZ6CNg`~G@OmvV)7F%-NVosYr!Z5 z==3#`To@CZh<#zFs$myypt2nt!G8DI97sr7EK467tgCr`>6-_8H2BKr z=R-NZ(Nih7=C1xE1KuDP!>T%Z@p8?hcWw_mfXZvF?_B7hLVB=%B?TKBe91O$;`?xA ze`Dl+Ga48HA^0Pz0!SDRi=a#PbG`KG%1lMkdb8H8`n-8M;l*Xaex42C#m%jUbs`A($7)oiMmIi`)fVC)*|Hly(z@ZnUkI)Hv~}*; zWcy&ROgLSQmQ2ND1y3t#YbKOzQmbaQzZ%xnUr#)v0#gJQCP6v00A@o@{)|))m}6Y? z7gbqXjN^=|_71Mv3_zOT(ovKN{yzUR^6@KNbsN$nYiiyQfb^Mqvl>Kr{>6)84o#_Y z@eStyIl1t~rajP=|9*-5RxCW8IRiT(cajMeQvPB<<$ws z;Dm+c?h!6(dl&s(hLXuzA>c;;)T}Ys5er~%pyqFOXp-T6U{ZLdbopy{2M5N_fFhdZq}(B0zGr92Ue+2F$mRnF%5e`S{pcE zx=h&){Esd#<5;H3_gDDPfuO+s@+@JQa;_XmMYW1{A6cRT$bA9zY*V0Y+7HSIEkN1B z{_LH_jiB`=kn<*f*|l?-vIn62D*xTVWj2=JtA+LgI3M`z6`&k%o_1}S4Y|Xhi*Tdn z{xaowK>7bfK@s%uQ_$ JmKeML@n88 + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 libraries-testing libraries-testing @@ -158,6 +158,13 @@ test + + com.tngtech.archunit + archunit-junit5 + ${archunit.version} + test + + @@ -193,7 +200,7 @@ 1.5.7.1 - 1.9.9 + 1.9.9 1.9.0 1.9.0 1.9.27 @@ -210,6 +217,7 @@ 1.8 1.8 3.8.1 + 0.14.1 diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java new file mode 100644 index 0000000000..8107e6317a --- /dev/null +++ b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java @@ -0,0 +1,49 @@ +/** + * + */ +package com.baldung.archunit.smurfs.persistence; + +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.TreeMap; + +import com.baldung.archunit.smurfs.persistence.domain.Smurf; + +import static java.util.stream.Collectors.toList; + +/** + * @author Philippe + * + */ +public class SmurfsRepository { + + private static Map smurfs = Collections.synchronizedMap(new TreeMap<>()); + + static { + // Just a few here. A full list can be found + // at https://smurfs.fandom.com/wiki/List_of_Smurf_characters + smurfs.put("Papa", new Smurf("Papa", true, true)); + smurfs.put("Actor", new Smurf("Actor", true, true)); + smurfs.put("Alchemist", new Smurf("Alchemist", true, true)); + smurfs.put("Archeologist", new Smurf("Archeologist", true, true)); + smurfs.put("Architect", new Smurf("Architect", true, true)); + smurfs.put("Baby", new Smurf("Baby", true, true)); + smurfs.put("Baker", new Smurf("Baker", true, true)); + smurfs.put("Baker", new Smurf("Baker", true, true)); + } + + public SmurfsRepository() { + + } + + public List findAll() { + return Collections.unmodifiableList(smurfs.values().stream().collect(toList())); + } + + public Optional findByName(String name) { + return Optional.of(smurfs.get(name)); + } + +} diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java new file mode 100644 index 0000000000..468266cf9a --- /dev/null +++ b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java @@ -0,0 +1,64 @@ +/** + * + */ +package com.baldung.archunit.smurfs.persistence.domain; + +/** + * @author Philippe + * + */ +public class Smurf { + private String name; + private boolean comic; + private boolean cartoon; + + public Smurf() {} + + public Smurf(String name, boolean comic, boolean cartoon) { + this.name = name; + this.comic = comic; + this.cartoon = cartoon; + } + + /** + * @return the name + */ + public String getName() { + return name; + } + + /** + * @param name the name to set + */ + public void setName(String name) { + this.name = name; + } + + /** + * @return the commic + */ + public boolean isComic() { + return comic; + } + + /** + * @param commic the commic to set + */ + public void setCommic(boolean comic) { + this.comic = comic; + } + + /** + * @return the cartoon + */ + public boolean isCartoon() { + return cartoon; + } + + /** + * @param cartoon the cartoon to set + */ + public void setCartoon(boolean cartoon) { + this.cartoon = cartoon; + } +} diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java new file mode 100644 index 0000000000..c0aff4ec03 --- /dev/null +++ b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java @@ -0,0 +1,27 @@ +package com.baldung.archunit.smurfs.presentation; + +import java.util.List; + +import org.springframework.http.MediaType; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RestController; + +import com.baldung.archunit.smurfs.service.SmurfsService; +import com.baldung.archunit.smurfs.service.dto.SmurfDTO; + +@RequestMapping(value = "/smurfs", produces = MediaType.APPLICATION_JSON_UTF8_VALUE) +@RestController +public class SmurfsController { + + private SmurfsService smurfs; + + public SmurfsController(SmurfsService smurfs) { + this.smurfs = smurfs; + } + + @GetMapping + public List getSmurfs() { + return smurfs.findAll(); + } +} diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java new file mode 100644 index 0000000000..40ffcc955c --- /dev/null +++ b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java @@ -0,0 +1,41 @@ +/** + * + */ +package com.baldung.archunit.smurfs.service; + +import java.util.List; +import java.util.stream.Collectors; + +import org.springframework.stereotype.Component; + +import com.baldung.archunit.smurfs.persistence.SmurfsRepository; +import com.baldung.archunit.smurfs.persistence.domain.Smurf; +import com.baldung.archunit.smurfs.service.dto.SmurfDTO; + +/** + * @author Philippe + * + */ +@Component +public class SmurfsService { + + private SmurfsRepository repository; + + public SmurfsService(SmurfsRepository repository) { + this.repository = repository; + } + + public List findAll() { + + return repository.findAll() + .stream() + .map(SmurfsService::toDTO) + .collect(Collectors.toList()); + } + + + public static SmurfDTO toDTO(Smurf smurf) { + return new SmurfDTO(smurf.getName(),smurf.isComic(), smurf.isCartoon()); + } + +} diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java new file mode 100644 index 0000000000..3c49262f9d --- /dev/null +++ b/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java @@ -0,0 +1,64 @@ +/** + * + */ +package com.baldung.archunit.smurfs.service.dto; + +import com.baldung.archunit.smurfs.persistence.domain.Smurf; + +/** + * @author Philippe + * + */ +public class SmurfDTO { + private String name; + private boolean comic; + private boolean cartoon; + + public SmurfDTO() {} + + public SmurfDTO(String name, boolean comic, boolean cartoon) { + this.name = name; + this.comic = comic; + this.cartoon = cartoon; + } + + + /** + * @return the name + */ + public String getName() { + return name; + } + /** + * @param name the name to set + */ + public void setName(String name) { + this.name = name; + } + /** + * @return the commic + */ + public boolean isComic() { + return comic; + } + /** + * @param commic the commic to set + */ + public void setCommic(boolean comic) { + this.comic = comic; + } + /** + * @return the cartoon + */ + public boolean isCartoon() { + return cartoon; + } + /** + * @param cartoon the cartoon to set + */ + public void setCartoon(boolean cartoon) { + this.cartoon = cartoon; + } + + +} diff --git a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java new file mode 100644 index 0000000000..b0c4397794 --- /dev/null +++ b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java @@ -0,0 +1,92 @@ +/** + * + */ +package com.baeldung.archunit.smurfs; + + +import com.tngtech.archunit.core.domain.JavaClasses; +import com.tngtech.archunit.core.importer.ClassFileImporter; +import com.tngtech.archunit.lang.ArchRule; +import com.tngtech.archunit.library.Architectures.LayeredArchitecture; + +import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes; +import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noClasses; +import static com.tngtech.archunit.library.Architectures.layeredArchitecture; + +import static org.junit.jupiter.api.Assertions.assertThrows; + +import org.junit.jupiter.api.Test; + +/** + * @author Philippe + * + */ +public class SmurfsArchUnitTest { + + @Test + public void givenPresentationLayerClasses_thenWrongCheckFails() { + JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + + ArchRule r1 = classes() + .that() + .resideInAPackage("..presentation..") + .should() + .onlyDependOnClassesThat() + .resideInAPackage("..service.."); + + assertThrows(AssertionError.class, ()-> r1.check(jc)) ; + } + + + @Test + public void givenPresentationLayerClasses_thenCheckWithFrameworkDependenciesSuccess() { + JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + + ArchRule r1 = classes() + .that() + .resideInAPackage("..presentation..") + .should() + .onlyDependOnClassesThat() + .resideInAnyPackage("..service..", "java..", "javax..", "org.springframework.."); + + r1.check(jc); + } + + @Test + public void givenPresentationLayerClasses_thenNoPersistenceLayerAccess() { + JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + + ArchRule r1 = noClasses() + .that() + .resideInAPackage("..presentation..") + .should() + .dependOnClassesThat() + .resideInAPackage("..persistence.."); + + + r1.check(jc); + } + + @Test + public void givenApplicationClasses_thenNoLayerViolationsShouldExist() { + + JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + + LayeredArchitecture arch = layeredArchitecture() + // Define layers + .layer("Presentation").definedBy("..presentation..") + .layer("Service").definedBy("..service..") + .layer("Persistence").definedBy("..persistence..") + // Add constraints + .whereLayer("Presentation").mayNotBeAccessedByAnyLayer() + .whereLayer("Service").mayOnlyBeAccessedByLayers("Presentation") + .whereLayer("Persistence").mayOnlyBeAccessedByLayers("Service"); + + + arch.check(jc); + + } + + + +} From 12fe9f3c71c39657118c3e28d78f6c78b1a4881d Mon Sep 17 00:00:00 2001 From: Philippe Date: Tue, 28 Jul 2020 10:30:33 -0300 Subject: [PATCH 2/9] [BAEL-4381] Intro to ArchUnit Code formatting --- .../java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java index b0c4397794..a89716fe9c 100644 --- a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java +++ b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java @@ -62,7 +62,6 @@ public class SmurfsArchUnitTest { .should() .dependOnClassesThat() .resideInAPackage("..persistence.."); - r1.check(jc); } @@ -81,10 +80,8 @@ public class SmurfsArchUnitTest { .whereLayer("Presentation").mayNotBeAccessedByAnyLayer() .whereLayer("Service").mayOnlyBeAccessedByLayers("Presentation") .whereLayer("Persistence").mayOnlyBeAccessedByLayers("Service"); - arch.check(jc); - } From 0e0fb4fa6ee67f4669d1e23b3a911b2c37233e1c Mon Sep 17 00:00:00 2001 From: Philippe Date: Tue, 28 Jul 2020 10:31:18 -0300 Subject: [PATCH 3/9] [BAEL-4381] Intro to ArchUnit Code formatting --- .../java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java index a89716fe9c..fa4428e599 100644 --- a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java +++ b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java @@ -83,7 +83,4 @@ public class SmurfsArchUnitTest { arch.check(jc); } - - - } From 92c0f251dc56acc7608cd55056988234517d42a0 Mon Sep 17 00:00:00 2001 From: Philippe Date: Tue, 28 Jul 2020 10:44:32 -0300 Subject: [PATCH 4/9] [BAEL-4381] Intro to ArchUnit Package typo --- .../archunit/smurfs/persistence/SmurfsRepository.java | 4 ++-- .../archunit/smurfs/persistence/domain/Smurf.java | 2 +- .../archunit/smurfs/presentation/SmurfsController.java | 6 +++--- .../archunit/smurfs/service/SmurfsService.java | 8 ++++---- .../archunit/smurfs/service/dto/SmurfDTO.java | 4 ++-- .../com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java | 8 ++++---- 6 files changed, 16 insertions(+), 16 deletions(-) rename libraries-testing/src/main/java/com/{baldung => baeldung}/archunit/smurfs/persistence/SmurfsRepository.java (92%) rename libraries-testing/src/main/java/com/{baldung => baeldung}/archunit/smurfs/persistence/domain/Smurf.java (94%) rename libraries-testing/src/main/java/com/{baldung => baeldung}/archunit/smurfs/presentation/SmurfsController.java (78%) rename libraries-testing/src/main/java/com/{baldung => baeldung}/archunit/smurfs/service/SmurfsService.java (74%) rename libraries-testing/src/main/java/com/{baldung => baeldung}/archunit/smurfs/service/dto/SmurfDTO.java (90%) diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java similarity index 92% rename from libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java rename to libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java index 8107e6317a..1dee45087a 100644 --- a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/SmurfsRepository.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java @@ -1,7 +1,7 @@ /** * */ -package com.baldung.archunit.smurfs.persistence; +package com.baeldung.archunit.smurfs.persistence; import java.util.Collections; import java.util.List; @@ -9,7 +9,7 @@ import java.util.Map; import java.util.Optional; import java.util.TreeMap; -import com.baldung.archunit.smurfs.persistence.domain.Smurf; +import com.baeldung.archunit.smurfs.persistence.domain.Smurf; import static java.util.stream.Collectors.toList; diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java similarity index 94% rename from libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java rename to libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java index 468266cf9a..6e0f586a5b 100644 --- a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/persistence/domain/Smurf.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java @@ -1,7 +1,7 @@ /** * */ -package com.baldung.archunit.smurfs.persistence.domain; +package com.baeldung.archunit.smurfs.persistence.domain; /** * @author Philippe diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/presentation/SmurfsController.java similarity index 78% rename from libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java rename to libraries-testing/src/main/java/com/baeldung/archunit/smurfs/presentation/SmurfsController.java index c0aff4ec03..7e31980d89 100644 --- a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/presentation/SmurfsController.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/presentation/SmurfsController.java @@ -1,4 +1,4 @@ -package com.baldung.archunit.smurfs.presentation; +package com.baeldung.archunit.smurfs.presentation; import java.util.List; @@ -7,8 +7,8 @@ import org.springframework.web.bind.annotation.GetMapping; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RestController; -import com.baldung.archunit.smurfs.service.SmurfsService; -import com.baldung.archunit.smurfs.service.dto.SmurfDTO; +import com.baeldung.archunit.smurfs.service.SmurfsService; +import com.baeldung.archunit.smurfs.service.dto.SmurfDTO; @RequestMapping(value = "/smurfs", produces = MediaType.APPLICATION_JSON_UTF8_VALUE) @RestController diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java similarity index 74% rename from libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java rename to libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java index 40ffcc955c..e2c73ef77e 100644 --- a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/SmurfsService.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java @@ -1,16 +1,16 @@ /** * */ -package com.baldung.archunit.smurfs.service; +package com.baeldung.archunit.smurfs.service; import java.util.List; import java.util.stream.Collectors; import org.springframework.stereotype.Component; -import com.baldung.archunit.smurfs.persistence.SmurfsRepository; -import com.baldung.archunit.smurfs.persistence.domain.Smurf; -import com.baldung.archunit.smurfs.service.dto.SmurfDTO; +import com.baeldung.archunit.smurfs.persistence.SmurfsRepository; +import com.baeldung.archunit.smurfs.persistence.domain.Smurf; +import com.baeldung.archunit.smurfs.service.dto.SmurfDTO; /** * @author Philippe diff --git a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java similarity index 90% rename from libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java rename to libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java index 3c49262f9d..948d0b349a 100644 --- a/libraries-testing/src/main/java/com/baldung/archunit/smurfs/service/dto/SmurfDTO.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java @@ -1,9 +1,9 @@ /** * */ -package com.baldung.archunit.smurfs.service.dto; +package com.baeldung.archunit.smurfs.service.dto; -import com.baldung.archunit.smurfs.persistence.domain.Smurf; +import com.baeldung.archunit.smurfs.persistence.domain.Smurf; /** * @author Philippe diff --git a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java index fa4428e599..0231a2c51a 100644 --- a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java +++ b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java @@ -25,7 +25,7 @@ public class SmurfsArchUnitTest { @Test public void givenPresentationLayerClasses_thenWrongCheckFails() { - JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + JavaClasses jc = new ClassFileImporter().importPackages("com.baeldung.archunit.smurfs"); ArchRule r1 = classes() .that() @@ -40,7 +40,7 @@ public class SmurfsArchUnitTest { @Test public void givenPresentationLayerClasses_thenCheckWithFrameworkDependenciesSuccess() { - JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + JavaClasses jc = new ClassFileImporter().importPackages("com.baeldung.archunit.smurfs"); ArchRule r1 = classes() .that() @@ -54,7 +54,7 @@ public class SmurfsArchUnitTest { @Test public void givenPresentationLayerClasses_thenNoPersistenceLayerAccess() { - JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + JavaClasses jc = new ClassFileImporter().importPackages("com.baeldung.archunit.smurfs"); ArchRule r1 = noClasses() .that() @@ -69,7 +69,7 @@ public class SmurfsArchUnitTest { @Test public void givenApplicationClasses_thenNoLayerViolationsShouldExist() { - JavaClasses jc = new ClassFileImporter().importPackages("com.baldung.archunit.smurfs"); + JavaClasses jc = new ClassFileImporter().importPackages("com.baeldung.archunit.smurfs"); LayeredArchitecture arch = layeredArchitecture() // Define layers From b2ce6f2836ef23d70788be9ad47d7840d4cfdf71 Mon Sep 17 00:00:00 2001 From: Philippe Date: Fri, 14 Aug 2020 09:29:27 -0300 Subject: [PATCH 5/9] [BAEL-4381] Fix formatting --- .../smurfs/persistence/SmurfsRepository.java | 7 ------ .../smurfs/persistence/domain/Smurf.java | 7 ------ .../smurfs/service/SmurfsService.java | 8 +----- .../archunit/smurfs/service/dto/SmurfDTO.java | 10 +------- .../archunit/smurfs/SmurfsArchUnitTest.java | 25 +++++++------------ 5 files changed, 11 insertions(+), 46 deletions(-) diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java index 1dee45087a..c18fcbc839 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java @@ -1,6 +1,3 @@ -/** - * - */ package com.baeldung.archunit.smurfs.persistence; import java.util.Collections; @@ -13,10 +10,6 @@ import com.baeldung.archunit.smurfs.persistence.domain.Smurf; import static java.util.stream.Collectors.toList; -/** - * @author Philippe - * - */ public class SmurfsRepository { private static Map smurfs = Collections.synchronizedMap(new TreeMap<>()); diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java index 6e0f586a5b..04427a8037 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java @@ -1,12 +1,5 @@ -/** - * - */ package com.baeldung.archunit.smurfs.persistence.domain; -/** - * @author Philippe - * - */ public class Smurf { private String name; private boolean comic; diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java index e2c73ef77e..4034b33b39 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/SmurfsService.java @@ -1,6 +1,4 @@ -/** - * - */ + package com.baeldung.archunit.smurfs.service; import java.util.List; @@ -12,10 +10,6 @@ import com.baeldung.archunit.smurfs.persistence.SmurfsRepository; import com.baeldung.archunit.smurfs.persistence.domain.Smurf; import com.baeldung.archunit.smurfs.service.dto.SmurfDTO; -/** - * @author Philippe - * - */ @Component public class SmurfsService { diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java index 948d0b349a..ac87b2137c 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java @@ -1,14 +1,6 @@ -/** - * - */ + package com.baeldung.archunit.smurfs.service.dto; -import com.baeldung.archunit.smurfs.persistence.domain.Smurf; - -/** - * @author Philippe - * - */ public class SmurfDTO { private String name; private boolean comic; diff --git a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java index 0231a2c51a..68a33be69b 100644 --- a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java +++ b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java @@ -17,10 +17,6 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import org.junit.jupiter.api.Test; -/** - * @author Philippe - * - */ public class SmurfsArchUnitTest { @Test @@ -29,10 +25,9 @@ public class SmurfsArchUnitTest { ArchRule r1 = classes() .that() - .resideInAPackage("..presentation..") - .should() - .onlyDependOnClassesThat() - .resideInAPackage("..service.."); + .resideInAPackage("..presentation..") + .should().onlyDependOnClassesThat() + .resideInAPackage("..service.."); assertThrows(AssertionError.class, ()-> r1.check(jc)) ; } @@ -44,10 +39,9 @@ public class SmurfsArchUnitTest { ArchRule r1 = classes() .that() - .resideInAPackage("..presentation..") - .should() - .onlyDependOnClassesThat() - .resideInAnyPackage("..service..", "java..", "javax..", "org.springframework.."); + .resideInAPackage("..presentation..") + .should().onlyDependOnClassesThat() + .resideInAnyPackage("..service..", "java..", "javax..", "org.springframework.."); r1.check(jc); } @@ -58,10 +52,9 @@ public class SmurfsArchUnitTest { ArchRule r1 = noClasses() .that() - .resideInAPackage("..presentation..") - .should() - .dependOnClassesThat() - .resideInAPackage("..persistence.."); + .resideInAPackage("..presentation..") + .should().dependOnClassesThat() + .resideInAPackage("..persistence.."); r1.check(jc); } From 8b7c80c376055484023224b64dcbd0eca6a559b7 Mon Sep 17 00:00:00 2001 From: Philippe Date: Fri, 14 Aug 2020 11:41:36 -0300 Subject: [PATCH 6/9] [BAEL-4381] Fix formatting --- .../smurfs/persistence/domain/Smurf.java | 18 ------------- .../archunit/smurfs/service/dto/SmurfDTO.java | 25 ++++--------------- 2 files changed, 5 insertions(+), 38 deletions(-) diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java index 04427a8037..255a024cdc 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/domain/Smurf.java @@ -13,44 +13,26 @@ public class Smurf { this.cartoon = cartoon; } - /** - * @return the name - */ public String getName() { return name; } - /** - * @param name the name to set - */ public void setName(String name) { this.name = name; } - /** - * @return the commic - */ public boolean isComic() { return comic; } - /** - * @param commic the commic to set - */ public void setCommic(boolean comic) { this.comic = comic; } - /** - * @return the cartoon - */ public boolean isCartoon() { return cartoon; } - /** - * @param cartoon the cartoon to set - */ public void setCartoon(boolean cartoon) { this.cartoon = cartoon; } diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java index ac87b2137c..523c639c41 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/service/dto/SmurfDTO.java @@ -14,43 +14,28 @@ public class SmurfDTO { this.cartoon = cartoon; } - - /** - * @return the name - */ public String getName() { return name; } - /** - * @param name the name to set - */ + public void setName(String name) { this.name = name; } - /** - * @return the commic - */ + public boolean isComic() { return comic; } - /** - * @param commic the commic to set - */ + public void setCommic(boolean comic) { this.comic = comic; } - /** - * @return the cartoon - */ + public boolean isCartoon() { return cartoon; } - /** - * @param cartoon the cartoon to set - */ + public void setCartoon(boolean cartoon) { this.cartoon = cartoon; } - } From de268d18d5c2de791186d153111f6441422634d4 Mon Sep 17 00:00:00 2001 From: Philippe Date: Fri, 14 Aug 2020 22:58:58 -0300 Subject: [PATCH 7/9] [BAEL-4381] Fix formatting --- .../article-resources/archunit/figure1.drawio | 1 - .../article-resources/archunit/figure1.png | Bin 15103 -> 0 bytes 2 files changed, 1 deletion(-) delete mode 100644 libraries-testing/article-resources/archunit/figure1.drawio delete mode 100644 libraries-testing/article-resources/archunit/figure1.png diff --git a/libraries-testing/article-resources/archunit/figure1.drawio b/libraries-testing/article-resources/archunit/figure1.drawio deleted file mode 100644 index 859d9946a1..0000000000 --- a/libraries-testing/article-resources/archunit/figure1.drawio +++ /dev/null @@ -1 +0,0 @@ -7VjbctowEP0aP9LBNgb3sSa3BzJNJ+2kk5eMsBdbrax1ZUEgX1/Jlm84YWgbKL3wwFhHa3l99pyVwHKn6fpSkCy5xgiY5QyjteWeWY7jj331rYFNCXjOsARiQaMSshvglj6BAauwJY0g7wRKRCZp1gVD5BxC2cGIEPjYDVsg6z41IzH0gNuQsD56RyOZGNQev20mroDGiXm070zKiTkJv8YCl9w8jyOHciYl1TLmHfOERPjYgtxzy50KRFlepespMM1qxVh538ULs3XKArjc54YrsrkffLj+Bp8ePr+/GTw409XdwKyyImxpqEg3JMsYDYmkyE3mclMRpV4i05eaYRCWGyyQy1szb6txnpGQ8vgjZhoYKkSSecXpyIxrKu1RCdxgTovnuWcMFmomSGTKzJIrEFLlw94xGusIqdcOiBmZeJ3HBUkp0wqcLUMaEZX5FHmOOreAkTmwoK7WFBmK4pXcRfHRS1DGWvhF8VF4n+iKNZUYrFuQIf4SMAUpNiqkmvWMCIw/7EoUj43aJr7BkpbQRq4BiVF4XK/dlFpdmGr/QOUnvcpbzpikmlomi7dujyLIgEd5DcadEDPa0gpEymNmiEImGCMn7LxBg6IUoLPUwmhiZljKR4FfQMqNaRhkKbErjYjkSXG//ToSeLHUOS5FCDvodE3XIiIGuSPOK+M0NzuFI4ApB666/enVReD2RJCDWNEQTsL4bUMWjbXn+udbwyGFsL/nPX/L837f8874Gc/bB/P8+N/26GhPj7on5VH/KI16ponvFq7yWqiILiy/7baURlGpEcjpE5kX62mVZEi5LHjwAss7O1Tdd2m859P68Gjy7JzCnvPvYPhG7dOmX+9darPcjWagtf9POq1gYHvdFXCxyJUkt6VSJ/Xz6hn11JOpaikKT+d892e3eXuyR5v3jtrmvX7NQeQ0l8BPZGc/Vn0PeKTf3t5Hw9++vVe/pk/Z7P+d/UsV7v9eP6UD+19o64Oe2tWw+f+n3PGbv9fc8+8= \ No newline at end of file diff --git a/libraries-testing/article-resources/archunit/figure1.png b/libraries-testing/article-resources/archunit/figure1.png deleted file mode 100644 index 8bd8e9647b07a46e7d8e363ba750fa838c07debb..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 15103 zcmeHuc{tQ<`!|!aCCZxaiWU??4JzA2%1$bhEV+xUlZdQi?(QfQg)oDmP*PO3vW;$~ z&DcivF)eq)*hXd;X3Wg*`l9qa@AEvzd%W-OIDW@_y!|=X_xnAs>pZV>|D1Ep&gQU~ zh`b0NAD@`H*+F|gz7=A8eEg+CtH8?o2m93c_!Rie4<0yn$#tA`;Qq$$Fuspk7LRJ}y$E9$XWZVd&If0KKCLkoCfQUg%!;;|ELCgtKO^VC# z)+GH~N_%_fGUdKM=R^0cgo{;p^{^IRU-(XKN3QpYb#48^5P^l2&Rx0Q_YE4m4ln)$ z>+a_K){VDf25o+<7{LiC)xPwV69wcjaAoUlg_ zA8*U8lKio9-vvRmi->)c^n;0pTQE%QcK*8TA1jD)u+q23FKUrXX#KWS8(d9zczk)q zNA}Vg_RM%Fa0%yppJw$MP$?g~rHueCB*w?CMdtzz?DD!^C$?zS){| zPJUBIOaHQD9{w3qczSz>-_2zTn_P3R7Jh2Z+(Wn~sq9&-fBqvP=+j?UJV(18m62q5BiB<{}tNSjg5Y)G{vRMk+^T}ZcR)Mn47D?vuh}__*v7MrlFjO zl6~Qfb8IqoCYN~6wu+}0JwMx=t9R@knf&DU!$E()xv6bP8YTA7YUws9+_}!6p%#K` z(DcX$&+ZbJ@$rMU`ri%)eSMckVNH*Yo%wdVL&`t^2j!`sthCz#dD{O$rRpjUbc zf#ZD@p5*!{(IIWr=+W>a)en*>`*=A4F>r3Be}7-`rqNe*K|?k{V?9r_eaE}#bR4fX z3OU7jYa6|LL*s`;4A;j=bV>HPo6r%M*x+H*NYTAMX)cG%i|XGNEM~&0vrONmEvw<` z7cwyr)~d*@V-ETnau~$QqTw}kssVL+a}=ZfVV+ss1cO(T>`^czIT%SNP_D?jp2HnB z6C8DP4J!zn>Gh(88GeecQl1v4atiZ&h2j_X3wxiV|d^Y zxf@whKm7XTZ1nt=VT{0gog(U{nhBW7Zz`)3O; za~<)l4>K}%7(~*Ilz_51ATrKOKYQY1tt&BkO$#Y4*3{aBcRPE)+64cWO1{vEYGa)) zfuEEAto!up4?S)a);~|wL}{OHKOW2F*SD@iMc6adqpQ=6NHeMRfwqJ}QL|GZ(ekHH%7ND;wj}i~J2E-owlu>W$aRmsnTyy$P0aaJMGN{1kgV#-eL`#lcCR0Rk3y>2S0@HiEOfgOfOB@hA7S^|a9Dmd1B)0@l;0ijg&TyGUU zl&39tk|veG%8MMKJHNI5y^Z953-@vT@WoVc$>7j1rb&k(P5K}m@pb{2%?cP+SH z5QN>guUw?(aDjLN4q~`4h~b~`y1Y4^+;PYKbjsqRZ zn?YJy`@PZSQIK3p{*dn9eb=oO(i>W`^{~L@Z|gqaq&SIy8G3EH`aVJUnEFS$ic;NW zxLEz^YvwsB0!>nr%t))KC*wvDK;||GgR8xwm{>WlBSOcNbIlynJMPGw;Yp|MO4+V? zKPFsLh30qO+9a_|Mc{#?U4F5p_Yu*jym*WBx9jANAq?bF9f=Z+HGAJ(5tYSkJ$wT$ zxaPNW9VjHJ`eHNns`bY_0V!&n2ffe=cC;52Ix*mVW20VImR@Mdz9?33(ERK-D^>Vv zei&9d!@{6vEYdP6TUAVScj%X<>y)-U6T+7yBW^<+>+GQOh|+G_2PwOJ$33*8P8A&8 zG^-3j^tY9rmot7lCl43X(z8w-0eg+upX~f&41cHN>{EeN(stsjzGjOVo+F+IX%%Ji zQzJprR=@q!^9u#fqdDOlW{2DF5_-$Lu%YCrs<5H#(7yiQdNzqxiK>iXPEbC-O0Z@P zm36dc?(xD%D%&(G4b(B|twzY#^^tQ^W33b<(}`Axto?R~-pZSAC8XCg3MkXvZb&k2 zkUi6ntoqh*mNJLiHPMRV(r0!athy~2hK#Q{r|w+o=iTU16Y{9H3Q5MaIhMNm&rFc| zTYTHINP|*zS<}>rl~Ud{9#&{BcQjybtaWI9jy~>nkVP%wV~&PAcvKTI?&Fp+f?}yr z4Q)I8549RFPqDrFtB^>eQv2))L!u#jtZXLe^WSe%d<`$Nw7QF_By}rJKc+gYrp~*0 z^-8(B5R z1H6mO!Rh!h&LH-4a2&IjwsG>6MmBRlZJy8@${61wg67HE<&Vc|t*qvB8@*xT&yP?lUHz@A zaP@N(EJ0MGwk=wzph?jnX>y+4sw*hI$&Xj#d#G9iS>0#Ad%lMkMnuX{@IscTE~H#X zkK5ckM^D^#mxo&ZuaxXCF|Btq60g9;sLq)s8KJMVrAZt0LdvZh?_5SP547QLwefT) z&SX{>2072Z5^|SW7-&y?e1E+;SaTg}#1d+6a|C;{5=gq(=T9=!k9FITkS$vM zrcyA>st9*^7{|mIuf!bn!BFoMOHi4_)Acnc+jxm1r6p`NbH@#?5#tq5nB< zmk-x5Yeb&3zreHkMhr8mop0Q(>&W%K+B=v^dXB0$i3 zt!}l&P1h7djgAk)!8P^|*mP@iCWf27pF?(L%ynstQ7zEBJ+`wf%rcLc{9VU z+_BcKIs@rk-2CSo#h-<9=pS4-+!057pJ759YK=eFGM@k!qdTtDp_?AN zK-JZx)4sKq-*_JMvgAm^&=D(#MocXCLiJ_ZeAQ^e?b>07Tn53KMKwB>6i--;y{O0(%&XDrU{~`{ai+MW#<%M; z5mAtNT#)a8GkDY2GR|Hzj%jFv#WULeYQp1UI9@0Tg*M^)f?5#=h!S7aM9}}i^GK8l z9DxE6;^rn37b~(_-wFYtX3<&w_+H8X(a(pM05u=wD*=jx}=&bSFX?LG|Cf{h%=Dih56{h_I%U0Tc*m*e{r zoD(^Yr`}m*G`Pb?UbvV0t_q2;|Mvmq|7Kq=d5`~>_kHMdvmR97^l>DrCT#kHBQ{$v z^v11jz0e8x>l+(=bD~*PPugJJ-R9F{xy9AIrVv?NgA^14AD)x<$N~b-Zg?Q$ZQTg3 zoO&>U_a4TsM0-PeI@bn&xi`T$cRyM_KA6?S1#y7@%A=sxEPw*|R>!M6R z5%TN%bgVKi@+oIJDVlM2#(-4C9csz;Me#;H6pvT&WOto97d>6k%b~f&*=`_iJNqy*HG{avU+w=hkIBfOK{JcU@JfGrPB9y1+6W zlOU^6;w@L*I7h(h_Fv|J(i6+*gZz9PGx#I7CA5BzuRKeT&hVmE7E}#}7l+a6n3!%i zRNY42dpGWd2)*|1`k9K5MBnZbZ6glVw*OEbs<<7r05B$TYqS?4j#}MBcIcot_Bxaz z%rS_z{bXA)Yk6f3v&5ywlVFV*oo@{vwF(-4z0?2l?RuUCUB?Y}RK`x+i7Zn8ztYeaosS^?qRAAp$tF*w{ z-Dx%AMTY1d2_ID4*hyqp_v5OWkGkRcs^TD#YErWa^=(f=&3}o=am+wE4CEXmxfzIV zLAZmRTJPSvRphO*!+qCnSbhRYl6F0B%W^QO}AS)7z&y0|eDX=_o6 zzwp(9T|d{4Vu>5yD<7oIv$4wIuH?|$tNGy_2 z(9A%H;SOK^bmq4c#N@R^I{^oC#LaqC#nY~6aSpG*&9Ov&C$>@)6`nO z)KyzFo%m6$%2-TVMh2&9op+@f47<)wT<29eBLPHacpksd!$J@SF=0t3r^TZuFH@3u zvq@Nu=x+(4CVi+QnG$ggjDSTvjmnlq$GS_IkGHJn-yfe~aQ?Ww!h z!|sXz_UHd0fSIcg#~IC^rhiV*(BaXIc*Oj=5U7DhxXjTl3eH@OJ_2@;i~erKP$@zE zTc-TtXcxteH|^FR7WGNg?F3Ojl4|K@A^ycWphf9m45Ah!a&kf6KQeoDm%ZQ@Qj-^CrN6#C^otx++ zm-bc(Mx_^iI`FDChY#(5xLLV2R;H)Y-#G|W2s(+XVkW*DaERv%;s4%u1C9^AxFfss zkB&WJWFD8N z8DM!LljCT7yZI&}5fC04%Z!!t1?A*+P)??`e3tp0C!M}qQb{udl#_Df7&PhEzCYKe zzvTRr#{bf*Uv~7%Z~Xu1Ck3AycmphtaD9WWhl7F$KkTm1*ue9$xxZ6v4_#AN;m7S+ zj9s9&Q>ST0l-P3-l-3Y1i9RkfDMsJvMee%`V2<|BpO;V$Cjq#albo2b`%%zovDOM( zyNI}GYNL z&AI^^+xwquN-iSCANd9Jg*bdCTrK_yZcf~q>n-=%rSk*8d>?uaKEf;zmeTk*lmGeX zIsTPkI}wZ9MeBZ`te{~))QqhL4e|vB!MR1&wZWxQ)sAil{DPlcw}x@^kQL~?0L0F! zFk5^Nafn~s*y|-+3M~dWuM}Ej*DfD)u-}wt2Im1jjU~PMvfd8p@bSr4L$d%2AG&{7 z339~|y$04+AitY^9?K|^iX8yA-8-xnI^zq6K>%`!_ReaHEGuAR`coE~5V3%|*tOav z%qinej9}iq4C$Z;#{mIf&qs?8|1k)d*MD(acL#vu^E*!OUOae%Cv*U(9i>|z*8+)# znQZ;ewvfdAlYqd*aP=EME~8-zZ1q*_`l2L+5*2_L*S1|bqhKYwh+hh~GB06&Sv z*A{q#i$Pilo!brvz8ZO7ByH{3kQPg&G&L`&BU|W_MBj{p1V}iqmdPw>(HoUq?>ASy zRbU&00L8V76m!jhCP`=Nr0hBdxIFjS>IZ5Xg8-n3qQ%MImbbnFjv`{6<-IU^fIcpJ zKBD6Rjc+swDAhrq1k**ypOKtY2-dM!v9<@?++)R?vP+UY3f{8PQl%U#2IA;yJ}JA% z17tl`K%7>|u|M#61-pNECnL9EyuS*IM6vq`#ijLqz$SxI*AG4qy0;xSY#k!zf zzVYmuKh~*O11?TBHK#8~NJpQ>(X*T#*iwBRBH6!=n^uwNpQ8K+Ip8F(Y zE~mRiKMxzP=wQ`f<-(!^7^0jP#bQt?v){fz&ID6Mj;@)b=;HS!1aar* zbV7_;Km~<;y(!}1zQE5f)f{vkP;0zevb;eD0yz+*eJ3G>`?fp4P`q?FTi~5U8$9)< za@n>8ZA)2aCOEQ$?4KfP2FKB{y2wgFHt2BcP%HF8#?Fb;s12NKTBH|f>xxsTtsVZB z$hv6<`d|c2yA;n2*W;$+=fBQ`+$oJ3_Z^o5{?0d=MZ{HJH|9Cq_3y9Lj$5`}LF(SpK0;casc#P^z3TmU&=}2`WCN zWE}(5A$`RlVy4_tzFL)!B#oAJi+mDBElBrl)oeB*wq5UbNy}&@-8pnW!rI4bX1u@q zA#?B~6MgYf4lvp23jwbdY#Bg4)hjN9KBgJH8PJvla8QQJX|n@5KJr}=D*LbNlHtMl z3Ag9N8fX4pvmx$}86}t`q^+7e3J)$Qb)j0@&s_#{x^3L#VbC_oaZboVap!v3_A8R3 zJ02NxaEw75XUuE-ktq(WkA>V})SB$Se~)>w%IG4^xzyXtansX&MgA3ihiey7(yu;nM;hmIG}VJk2o;DXI7b;A!Dw#`F5qZt6x8wru{20QAw@6uGq z*%Ty?Y9y3xMhlIw_mQt|+G>!<={#y%;bi8xuX;$qK9NDh-}-o9I9{i?Kn-A>CopY% zi#`t#fSyCn2PGl(VFH`15X4D$S6Ayr8x{Z_0+xJ5VUiCRj$p%-{jv`z243XEtB1~e zmd#fXXsABl?eyj7al#aM!kwNZ%%Ue;38T81?hl(fvr_em0E{RLL~C@|(`<1sH3_r0 z4A4z}s)$fPAczt%YD;59$!-W@GP(1rK$m12yl2DGp>M(hY?K05FF&k!7jVD@*Cv@ZsF}SNaDbA3 z8I$2+*tDtru=fCMzpV?0Es9$64{!yC5V9A}0xGK5a8cz2d7l-Y|0rm5&Nb|78U<>< zV2wCLqik#LkERgnn=Gmw>LscA9`Uryl>pbOcx|`!f~X&lz<695Z_tlaT`^bT#;%~W zAKvUAO=Cuv&b>y>zor0en}FhUqqG5H8c;v`N~2_d%Cw~1L7)Ue#RnESMk@-`^EfnJ z6kQiZoF77Qhx}$WB0q@|Lh)=8rIb5T8Y|>&1rxv&w!?c?ElFPsM)hfg5OrPNx6M2) zEFC%DgaoZb4c_OSCR$GL_H}^E?Vg0Jg*_TXL>Z+z&)z-$Yr~5U6YwN&;E$!teJ`^3 zb|A_UNi4yhD8NX6`!NNrx#9<>xvGp_>{yQ zPQu_h{rG7$lREFpr@}y;l~Pw9g~BqLARNgVbwe7?e!NVmyY#2yIG6$q<8hdWuc~bW z*Alz74Ziw|&oM}ta&`()mq?(;-XQc|%wT#>y=p&A3E?gcPFtLD(H9sa;uGwsQL1fJ z^p$&LhOmU(0U$+Kbux68$5{=X;$M&A$QM|HU@T%M$T%FdM!Ud}5c;pBISUb6JXKNw zXhGp=U^0+c-1jXFXMAPUVL>tuCAl75kD!$Cil`OG&Tx88IwzW_jBpnKDk?N=40)=C z3rmN1PmRz8-r*;|CL+5yfT60-DYT7g5CXCS=^Ye+(O;K_M{X0D0bm~E2(Z_9rz&XJ zLu!}iw8>oOkmDtmHI5Ix7FgcaTv2n#^Sl>cJcRl^8c9It;T>>t>9PO<;8*3;;y_2~ zBm-;658Dd-F3{|S2zpy`X&A+ZTq7*;vq!ai)y!=m3P{0(1bf(%m9^x1E7< z_P?MutN>_$fUZ6CNg`~G@OmvV)7F%-NVosYr!Z5 z==3#`To@CZh<#zFs$myypt2nt!G8DI97sr7EK467tgCr`>6-_8H2BKr z=R-NZ(Nih7=C1xE1KuDP!>T%Z@p8?hcWw_mfXZvF?_B7hLVB=%B?TKBe91O$;`?xA ze`Dl+Ga48HA^0Pz0!SDRi=a#PbG`KG%1lMkdb8H8`n-8M;l*Xaex42C#m%jUbs`A($7)oiMmIi`)fVC)*|Hly(z@ZnUkI)Hv~}*; zWcy&ROgLSQmQ2ND1y3t#YbKOzQmbaQzZ%xnUr#)v0#gJQCP6v00A@o@{)|))m}6Y? z7gbqXjN^=|_71Mv3_zOT(ovKN{yzUR^6@KNbsN$nYiiyQfb^Mqvl>Kr{>6)84o#_Y z@eStyIl1t~rajP=|9*-5RxCW8IRiT(cajMeQvPB<<$ws z;Dm+c?h!6(dl&s(hLXuzA>c;;)T}Ys5er~%pyqFOXp-T6U{ZLdbopy{2M5N_fFhdZq}(B0zGr92Ue+2F$mRnF%5e`S{pcE zx=h&){Esd#<5;H3_gDDPfuO+s@+@JQa;_XmMYW1{A6cRT$bA9zY*V0Y+7HSIEkN1B z{_LH_jiB`=kn<*f*|l?-vIn62D*xTVWj2=JtA+LgI3M`z6`&k%o_1}S4Y|Xhi*Tdn z{xaowK>7bfK@s%uQ_$ JmKeML@n88 Date: Mon, 17 Aug 2020 11:58:25 -0300 Subject: [PATCH 8/9] [BAEL-4381] Fix formatting --- .../archunit/smurfs/persistence/SmurfsRepository.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java index c18fcbc839..5d90d0f288 100644 --- a/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java +++ b/libraries-testing/src/main/java/com/baeldung/archunit/smurfs/persistence/SmurfsRepository.java @@ -26,11 +26,7 @@ public class SmurfsRepository { smurfs.put("Baker", new Smurf("Baker", true, true)); smurfs.put("Baker", new Smurf("Baker", true, true)); } - - public SmurfsRepository() { - - } - + public List findAll() { return Collections.unmodifiableList(smurfs.values().stream().collect(toList())); } From de79bd2919ea26cb83f190dfa6a715ec5bf34540 Mon Sep 17 00:00:00 2001 From: bfontana Date: Mon, 17 Aug 2020 21:49:49 -0300 Subject: [PATCH 9/9] Update SmurfsArchUnitTest.java --- .../java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java index 68a33be69b..9724c2bcae 100644 --- a/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java +++ b/libraries-testing/src/test/java/com/baeldung/archunit/smurfs/SmurfsArchUnitTest.java @@ -1,6 +1,3 @@ -/** - * - */ package com.baeldung.archunit.smurfs;