mindol1004/spring-boot-rest
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[BAEL-3981] Fixes from Josh's review

Browse Source 
* Upgraded Apache Commons to 3.10

* Replaced Nathalie by Natalie
This commit is contained in:
dupirefr
2020-05-20 23:33:04 +02:00
parent 0ce80e48fd
commit bb1ccffcaf
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/EqualsMethodUnitTest.java
View File

@@ -66,8 +66,8 @@ class EqualsMethodUnitTest {
@Test
void givenTwoPersonWittEqualsWithDifferentNames_whenEquals_thenFalse() {
PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
assertThat(joe.equals(nathalie)).isFalse();
assertThat(joe.equals(natalie)).isFalse();
}
}

8
core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/GuavaUnitTest.java
View File

@@ -58,13 +58,13 @@ class GuavaUnitTest {
@Nested
class ComparisonChainClass {
@Test
void givenTwoPersonWithEquals_whenComparisonChainByLastNameThenFirstName_thenSortedJoeFirstAndNathalieSecond() {
PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
void givenTwoPersonWithEquals_whenComparisonChainByLastNameThenFirstName_thenSortedJoeFirstAndNatalieSecond() {
PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
int comparisonResult = ComparisonChain.start()
.compare(nathalie.lastName(), joe.lastName())
.compare(nathalie.firstName(), joe.firstName())
.compare(natalie.lastName(), joe.lastName())
.compare(natalie.firstName(), joe.firstName())
.result();
assertThat(comparisonResult).isPositive();

4
core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/ObjectsEqualsStaticMethodUnitTest.java
View File

@@ -19,9 +19,9 @@ class ObjectsEqualsStaticMethodUnitTest {
@Test
void givenTwoPersonWithEqualsWithDifferentNames_whenObjectsEquals_thenFalse() {
PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
assertThat(Objects.equals(joe, nathalie)).isFalse();
assertThat(Objects.equals(joe, natalie)).isFalse();
}
@Test