From dc90aace68ccb29428970fde4283784c405ed1a6 Mon Sep 17 00:00:00 2001 From: Mohamed Sanaulla Date: Sat, 18 Mar 2017 10:18:04 +0300 Subject: [PATCH] incorporate few review comments for bael-603 (#1429) --- .../student/client/StudentClient.java | 16 ++++---- .../module-info.java | 2 +- .../com/baeldung/student/model/Student.java | 17 +++++---- .../module-info.java | 2 +- .../service/dbimpl/StudentDbService.java | 37 ++++++++++--------- .../module-info.java | 5 ++- .../student/service/StudentService.java | 10 ++--- .../module-info.java | 4 +- 8 files changed, 50 insertions(+), 43 deletions(-) diff --git a/core-java-9/src/modules/com.baeldung.student.client/com/baeldung/student/client/StudentClient.java b/core-java-9/src/modules/com.baeldung.student.client/com/baeldung/student/client/StudentClient.java index b5b5d1eead..e6fce9163f 100644 --- a/core-java-9/src/modules/com.baeldung.student.client/com/baeldung/student/client/StudentClient.java +++ b/core-java-9/src/modules/com.baeldung.student.client/com/baeldung/student/client/StudentClient.java @@ -4,13 +4,13 @@ import com.baeldung.student.service.StudentService; import com.baeldung.student.service.dbimpl.StudentDbService; import com.baeldung.student.model.Student; -public class StudentClient{ +public class StudentClient { - public static void main(String[] args) { - StudentService service = new StudentDbService(); - service.create(new Student()); - service.read("17SS0001"); - service.update(new Student()); - service.delete("17SS0001"); - } + public static void main(String[] args) { + StudentService service = new StudentDbService(); + service.create(new Student()); + service.read("17SS0001"); + service.update(new Student()); + service.delete("17SS0001"); + } } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.client/module-info.java b/core-java-9/src/modules/com.baeldung.student.client/module-info.java index 3979297068..7ef7b430fc 100644 --- a/core-java-9/src/modules/com.baeldung.student.client/module-info.java +++ b/core-java-9/src/modules/com.baeldung.student.client/module-info.java @@ -1,3 +1,3 @@ module com.baeldung.student.client{ - requires com.baeldung.student.service.dbimpl; + requires com.baeldung.student.service.dbimpl; } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.model/com/baeldung/student/model/Student.java b/core-java-9/src/modules/com.baeldung.student.model/com/baeldung/student/model/Student.java index 21c0b4e0ae..d7f8f69107 100644 --- a/core-java-9/src/modules/com.baeldung.student.model/com/baeldung/student/model/Student.java +++ b/core-java-9/src/modules/com.baeldung.student.model/com/baeldung/student/model/Student.java @@ -2,11 +2,14 @@ package com.baeldung.student.model; import java.util.Date; -public class Student{ - public String registrationId; - public String firstName; - public String lastName; - public Date dateOfBirth; - public String city; - public String country; +public class Student { + private String registrationId; + + public String getRegistrationId() { + return registrationId; + } + + public void setRegistrationId(String registrationId) { + this.registrationId = registrationId; + } } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.model/module-info.java b/core-java-9/src/modules/com.baeldung.student.model/module-info.java index 6f60e3b4dc..3bdab058d4 100644 --- a/core-java-9/src/modules/com.baeldung.student.model/module-info.java +++ b/core-java-9/src/modules/com.baeldung.student.model/module-info.java @@ -1,3 +1,3 @@ module com.baeldung.student.model{ - exports com.baeldung.student.model; + exports com.baeldung.student.model; } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.service.dbimpl/com/baeldung/student/service/dbimpl/StudentDbService.java b/core-java-9/src/modules/com.baeldung.student.service.dbimpl/com/baeldung/student/service/dbimpl/StudentDbService.java index fb24a440f0..2519da085b 100644 --- a/core-java-9/src/modules/com.baeldung.student.service.dbimpl/com/baeldung/student/service/dbimpl/StudentDbService.java +++ b/core-java-9/src/modules/com.baeldung.student.service.dbimpl/com/baeldung/student/service/dbimpl/StudentDbService.java @@ -2,26 +2,29 @@ package com.baeldung.student.service.dbimpl; import com.baeldung.student.service.StudentService; import com.baeldung.student.model.Student; +import java.util.logging.*; -public class StudentDbService implements StudentService{ +public class StudentDbService implements StudentService { - public String create(Student student){ - System.out.println("Creating student in DB..."); - return student.registrationId; - } + private static Logger logger = Logger.getLogger("StudentDbService"); - public Student read(String registrationId){ - System.out.println("Reading student from DB..."); - return new Student(); - } + public String create(Student student) { + logger.log(Level.INFO, "Creating student in DB..."); + return student.getRegistrationId(); + } - public Student update(Student student){ - System.out.println("Updating sutdent in DB..."); - return student; - } + public Student read(String registrationId) { + logger.log(Level.INFO, "Reading student from DB..."); + return new Student(); + } - public String delete(String registrationId){ - System.out.println("Deleteing sutdent in DB..."); - return registrationId; - } + public Student update(Student student) { + logger.log(Level.INFO, "Updating sutdent in DB..."); + return student; + } + + public String delete(String registrationId) { + logger.log(Level.INFO, "Deleteing sutdent in DB..."); + return registrationId; + } } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.service.dbimpl/module-info.java b/core-java-9/src/modules/com.baeldung.student.service.dbimpl/module-info.java index a55b4e0f80..96a453ea6b 100644 --- a/core-java-9/src/modules/com.baeldung.student.service.dbimpl/module-info.java +++ b/core-java-9/src/modules/com.baeldung.student.service.dbimpl/module-info.java @@ -1,4 +1,5 @@ module com.baeldung.student.service.dbimpl{ - requires transitive com.baeldung.student.service; - exports com.baeldung.student.service.dbimpl; + requires transitive com.baeldung.student.service; + exports com.baeldung.student.service.dbimpl; + requires java.logging; } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.service/com/baeldung/student/service/StudentService.java b/core-java-9/src/modules/com.baeldung.student.service/com/baeldung/student/service/StudentService.java index 3c0070ff49..6076bf12e3 100644 --- a/core-java-9/src/modules/com.baeldung.student.service/com/baeldung/student/service/StudentService.java +++ b/core-java-9/src/modules/com.baeldung.student.service/com/baeldung/student/service/StudentService.java @@ -2,13 +2,13 @@ package com.baeldung.student.service; import com.baeldung.student.model.Student; -public interface StudentService{ +public interface StudentService { - public String create(Student student); + public String create(Student student); - public Student read(String registrationId); + public Student read(String registrationId); - public Student update(Student student); + public Student update(Student student); - public String delete(String registrationId); + public String delete(String registrationId); } \ No newline at end of file diff --git a/core-java-9/src/modules/com.baeldung.student.service/module-info.java b/core-java-9/src/modules/com.baeldung.student.service/module-info.java index c083e62776..5de9e58348 100644 --- a/core-java-9/src/modules/com.baeldung.student.service/module-info.java +++ b/core-java-9/src/modules/com.baeldung.student.service/module-info.java @@ -1,4 +1,4 @@ module com.baeldung.student.service{ - requires transitive com.baeldung.student.model; - exports com.baeldung.student.service; + requires transitive com.baeldung.student.model; + exports com.baeldung.student.service; } \ No newline at end of file