From e17dd32c49a3dfd77cf2aaa99a0ff0f5a59eb5a9 Mon Sep 17 00:00:00 2001 From: pivovarit Date: Tue, 17 Jan 2017 06:03:30 +0100 Subject: [PATCH] Refactor HealthCheckTest --- .../metrics/healthchecks/HealthCheckTest.java | 21 ++++++++++--------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/metrics/src/test/java/com/baeldung/metrics/healthchecks/HealthCheckTest.java b/metrics/src/test/java/com/baeldung/metrics/healthchecks/HealthCheckTest.java index 4b0d996821..99a3970761 100644 --- a/metrics/src/test/java/com/baeldung/metrics/healthchecks/HealthCheckTest.java +++ b/metrics/src/test/java/com/baeldung/metrics/healthchecks/HealthCheckTest.java @@ -1,16 +1,18 @@ package com.baeldung.metrics.healthchecks; -import static org.hamcrest.CoreMatchers.equalTo; -import static org.junit.Assert.assertThat; - -import java.util.Map; - -import org.junit.Test; - import com.codahale.metrics.health.HealthCheck; import com.codahale.metrics.health.HealthCheckRegistry; +import org.junit.Test; + +import java.util.Map; + +import static org.hamcrest.CoreMatchers.equalTo; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertThat; +import static org.junit.Assert.assertTrue; public class HealthCheckTest { + @Test public void whenUseHealthCheck_thenHealthChecked() { HealthCheckRegistry healthCheckRegistry = new HealthCheckRegistry(); @@ -21,9 +23,8 @@ public class HealthCheckTest { assertThat(healthCheckRegistry.getNames().size(), equalTo(2)); Map results = healthCheckRegistry.runHealthChecks(); - for (Map.Entry entry : results.entrySet()) { - assertThat(entry.getValue().isHealthy(), equalTo(true)); - } + assertFalse(results.isEmpty()); + results.forEach((k, v) -> assertTrue(v.isHealthy())); healthCheckRegistry.unregister("uc"); assertThat(healthCheckRegistry.getNames().size(), equalTo(1));