Minor changes to class names and return type List<String> for BAEL-3083

This commit is contained in:
caroline
2019-09-10 14:40:07 +02:00
parent 7a77f060be
commit e479bea0b8
2 changed files with 8 additions and 8 deletions

View File

@@ -16,7 +16,7 @@ import java.util.stream.Collectors;
public class FindAStringInGivenList {
public List findUsingLoopWithRegex(String search, List<String> list) {
public List<String> findUsingLoopWithRegex(String search, List<String> list) {
List<String> matches = new ArrayList<String>();
@@ -33,7 +33,7 @@ public class FindAStringInGivenList {
}
public List findUsingLoop(String search, List<String> list) {
public List<String> findUsingLoop(String search, List<String> list) {
List<String> matches = new ArrayList<String>();
@@ -46,7 +46,7 @@ public class FindAStringInGivenList {
return matches;
}
public List findUsingStream(String search, List<String> list) {
public List<String> findUsingStream(String search, List<String> list) {
List<String> matchingElements =
list.stream()
@@ -67,7 +67,7 @@ public class FindAStringInGivenList {
return Lists.newArrayList(result.iterator());
}
public List<String> findUsingApacheCommon(String search, List<String> list) {
public List<String> findUsingCommonsCollection(String search, List<String> list) {
CollectionUtils.filter(list, PredicateUtils.notNullPredicate());
Iterable<String> result = IterableUtils.filteredIterable(list, new org.apache.commons.collections4.Predicate<String>() {
public boolean evaluate(String listElement) {

View File

@@ -63,16 +63,16 @@ public class FindAStringInListUnitTest {
}
@Test
public void givenAString_whenFoundUsingApacheCommons_thenReturnList(){
List matchingElements = findAStringInGivenList.findUsingApacheCommon("Jack", list);
public void givenAString_whenFoundUsingCommonsCollection_thenReturnList(){
List matchingElements = findAStringInGivenList.findUsingCommonsCollection("Jack", list);
assertEquals(2, matchingElements.size());
assertEquals("Jack and Jill", matchingElements.get(0));
assertEquals("Jack", matchingElements.get(1));
}
@Test
public void givenAString_whenNullFoundUsingApacheCommons_thenReturnEmptyList(){
List matchingElements = findAStringInGivenList.findUsingApacheCommon(null, list);
public void givenAString_whenNullFoundUsingCommonsCollection_thenReturnEmptyList(){
List matchingElements = findAStringInGivenList.findUsingCommonsCollection(null, list);
assertEquals(0, matchingElements.size());
}