mindol1004/spring-data-mongodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert BsonUndefined to null value.

Browse Source 
Register a reading converter that returns null when attempting to read a value of type BsonUndefined.
Prior to this change users faced a ConverterNotFoundException when source documents contained BsonUndefined.

Resolves: #2350
This commit is contained in:
Christoph Strobl
2023-06-01 08:48:35 +02:00
parent fa63efcb24
commit 98795cb33e
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoConverters.java
View File

@@ -33,6 +33,7 @@ import java.util.concurrent.atomic.AtomicLong;
import org.bson.BsonReader; import org.bson.BsonReader;
import org.bson.BsonTimestamp; import org.bson.BsonTimestamp;
import org.bson.BsonUndefined;
import org.bson.BsonWriter; import org.bson.BsonWriter;
import org.bson.Document; import org.bson.Document;
import org.bson.codecs.Codec; import org.bson.codecs.Codec;
@@ -104,6 +105,7 @@ abstract class MongoConverters {
converters.add(BinaryToByteArrayConverter.INSTANCE); converters.add(BinaryToByteArrayConverter.INSTANCE);
converters.add(BsonTimestampToInstantConverter.INSTANCE); converters.add(BsonTimestampToInstantConverter.INSTANCE);
converters.add(reading(BsonUndefined.class, Object.class, it -> null));
converters.add(reading(String.class, URI.class, URI::create).andWriting(URI::toString)); converters.add(reading(String.class, URI.class, URI::create).andWriting(URI::toString));
return converters; return converters;

8
spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java
View File

@@ -34,6 +34,7 @@ import java.time.ZoneOffset;
import java.time.temporal.ChronoUnit; import java.time.temporal.ChronoUnit;
import java.util.*; import java.util.*;
import org.bson.BsonUndefined;
import org.bson.types.Binary; import org.bson.types.Binary;
import org.bson.types.Code; import org.bson.types.Code;
import org.bson.types.Decimal128; import org.bson.types.Decimal128;
@@ -2843,6 +2844,13 @@ class MappingMongoConverterUnitTests {
assertThat(converter.read(Address.class, source).city).isEqualTo("Gotham,Metropolis"); assertThat(converter.read(Address.class, source).city).isEqualTo("Gotham,Metropolis");
} }
@Test // GH-2350
void shouldConvertBsonUndefinedToNull() {
org.bson.Document source = new org.bson.Document("s", "hallway drive").append("city", new BsonUndefined());
assertThat(converter.read(Address.class, source).city).isNull();
}
static class GenericType<T> { static class GenericType<T> {
T content; T content;
} }