Invalidate session before clearing session store

Closes gh-1114
This commit is contained in:
Vedran Pavic
2018-07-11 23:32:35 +02:00
parent 9956e91b93
commit dba475c48f
2 changed files with 27 additions and 2 deletions

View File

@@ -164,6 +164,7 @@ public class SpringSessionWebSessionStore<S extends Session> implements WebSessi
@Override
public Mono<Void> invalidate() {
this.state.set(State.EXPIRED);
return SpringSessionWebSessionStore.this.sessions.deleteById(this.session.getId());
}
@@ -174,7 +175,14 @@ public class SpringSessionWebSessionStore<S extends Session> implements WebSessi
@Override
public boolean isExpired() {
return this.session.isExpired();
if (this.state.get().equals(State.EXPIRED)) {
return true;
}
if (this.session.isExpired()) {
this.state.set(State.EXPIRED);
return true;
}
return false;
}
@Override
@@ -199,7 +207,7 @@ public class SpringSessionWebSessionStore<S extends Session> implements WebSessi
}
private enum State {
NEW, STARTED
NEW, STARTED, EXPIRED
}
private static class SpringSessionMap implements Map<String, Object> {

View File

@@ -291,4 +291,21 @@ public class SpringSessionWebSessionStoreTests<S extends Session> {
.hasMessage("clock cannot be null");
}
@Test // gh-1114
public void createSessionThenSessionIsNotExpired() {
WebSession createdWebSession = this.webSessionStore.createWebSession().block();
assertThat(createdWebSession.isExpired()).isFalse();
}
@Test // gh-1114
public void invalidateSessionThenSessionIsExpired() {
WebSession createdWebSession = this.webSessionStore.createWebSession().block();
given(createdWebSession.invalidate()).willReturn(Mono.empty());
createdWebSession.invalidate().block();
assertThat(createdWebSession.isExpired()).isTrue();
}
}