diff --git a/docs/src/test/java/docs/IndexDocTests.java b/docs/src/test/java/docs/IndexDocTests.java index 4f5d30fd..d0287417 100644 --- a/docs/src/test/java/docs/IndexDocTests.java +++ b/docs/src/test/java/docs/IndexDocTests.java @@ -76,7 +76,7 @@ public class IndexDocTests { public void demo() { S toSave = repository.createSession(); // <2> // ... - toSave.setMaxInactiveInterval(30); // <3> + toSave.setMaxInactiveIntervalInSeconds(30); // <3> repository.save(toSave); // <4> diff --git a/spring-session/src/main/java/org/springframework/session/ExpiringSession.java b/spring-session/src/main/java/org/springframework/session/ExpiringSession.java index b3c9605a..c51455ec 100644 --- a/spring-session/src/main/java/org/springframework/session/ExpiringSession.java +++ b/spring-session/src/main/java/org/springframework/session/ExpiringSession.java @@ -27,14 +27,14 @@ public interface ExpiringSession extends Session { * * @param interval the number of seconds that the {@link Session} should be kept alive between client requests. */ - void setMaxInactiveInterval(int interval); + void setMaxInactiveIntervalInSeconds(int interval); /** * Gets the maximum inactive interval in seconds between requests before this session will be invalidated. A negative time indicates that the session will never timeout. * * @return the maximum inactive interval in seconds between requests before this session will be invalidated. A negative time indicates that the session will never timeout. */ - int getMaxInactiveInterval(); + int getMaxInactiveIntervalInSeconds(); /** * Returns true if the session is expired. diff --git a/spring-session/src/main/java/org/springframework/session/MapSession.java b/spring-session/src/main/java/org/springframework/session/MapSession.java index cdd43233..bea1bf9f 100644 --- a/spring-session/src/main/java/org/springframework/session/MapSession.java +++ b/spring-session/src/main/java/org/springframework/session/MapSession.java @@ -42,7 +42,7 @@ import java.util.concurrent.TimeUnit; */ public final class MapSession implements ExpiringSession, Serializable { /** - * Default {@link #setMaxInactiveInterval(int)} (30 minutes) + * Default {@link #setMaxInactiveIntervalInSeconds(int)} (30 minutes) */ public static final int DEFAULT_MAX_INACTIVE_INTERVAL_SECONDS = 1800; @@ -79,7 +79,7 @@ public final class MapSession implements ExpiringSession, Serializable { } this.lastAccessedTime = session.getLastAccessedTime(); this.creationTime = session.getCreationTime(); - this.maxInactiveInterval = session.getMaxInactiveInterval(); + this.maxInactiveInterval = session.getMaxInactiveIntervalInSeconds(); } public void setLastAccessedTime(long lastAccessedTime) { @@ -98,11 +98,11 @@ public final class MapSession implements ExpiringSession, Serializable { return lastAccessedTime; } - public void setMaxInactiveInterval(int interval) { + public void setMaxInactiveIntervalInSeconds(int interval) { this.maxInactiveInterval = interval; } - public int getMaxInactiveInterval() { + public int getMaxInactiveIntervalInSeconds() { return maxInactiveInterval; } diff --git a/spring-session/src/main/java/org/springframework/session/MapSessionRepository.java b/spring-session/src/main/java/org/springframework/session/MapSessionRepository.java index 820664bc..7a991f7b 100644 --- a/spring-session/src/main/java/org/springframework/session/MapSessionRepository.java +++ b/spring-session/src/main/java/org/springframework/session/MapSessionRepository.java @@ -34,7 +34,7 @@ import java.util.concurrent.ConcurrentHashMap; */ public class MapSessionRepository implements SessionRepository { /** - * If non-null, this value is used to override {@link ExpiringSession#setMaxInactiveInterval(int)}. + * If non-null, this value is used to override {@link ExpiringSession#setMaxInactiveIntervalInSeconds(int)}. */ private Integer defaultMaxInactiveInterval; @@ -60,7 +60,7 @@ public class MapSessionRepository implements SessionRepository } /** - * If non-null, this value is used to override {@link ExpiringSession#setMaxInactiveInterval(int)}. + * If non-null, this value is used to override {@link ExpiringSession#setMaxInactiveIntervalInSeconds(int)}. * @param defaultMaxInactiveInterval the number of seconds that the {@link Session} should be kept alive between client requests. */ public void setDefaultMaxInactiveInterval(int defaultMaxInactiveInterval) { @@ -92,7 +92,7 @@ public class MapSessionRepository implements SessionRepository public ExpiringSession createSession() { ExpiringSession result = new MapSession(); if(defaultMaxInactiveInterval != null) { - result.setMaxInactiveInterval(defaultMaxInactiveInterval); + result.setMaxInactiveIntervalInSeconds(defaultMaxInactiveInterval); } return result; } diff --git a/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java b/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java index 520e6760..02cfd649 100644 --- a/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java +++ b/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java @@ -76,7 +76,7 @@ import org.springframework.util.Assert; *

* An expiration is associated to each session using the EXPIRE command based upon the - * {@link org.springframework.session.data.redis.RedisOperationsSessionRepository.RedisSession#getMaxInactiveInterval()} + * {@link org.springframework.session.data.redis.RedisOperationsSessionRepository.RedisSession#getMaxInactiveIntervalInSeconds()} * . For example: *

* @@ -123,7 +123,7 @@ public class RedisOperationsSessionRepository implements SessionRepository extends OncePerR } public void setMaxInactiveInterval(int interval) { - session.setMaxInactiveInterval(interval); + session.setMaxInactiveIntervalInSeconds(interval); } public int getMaxInactiveInterval() { - return session.getMaxInactiveInterval(); + return session.getMaxInactiveIntervalInSeconds(); } @SuppressWarnings("deprecation") diff --git a/spring-session/src/test/java/org/springframework/session/MapSessionRepositoryTests.java b/spring-session/src/test/java/org/springframework/session/MapSessionRepositoryTests.java index 4feac02f..51eaa5b6 100644 --- a/spring-session/src/test/java/org/springframework/session/MapSessionRepositoryTests.java +++ b/spring-session/src/test/java/org/springframework/session/MapSessionRepositoryTests.java @@ -35,7 +35,7 @@ public class MapSessionRepositoryTests { @Test public void getSessionExpired() { - session.setMaxInactiveInterval(1); + session.setMaxInactiveIntervalInSeconds(1); session.setLastAccessedTime(System.currentTimeMillis() - TimeUnit.MINUTES.toMillis(5)); repository.save(session); @@ -47,16 +47,16 @@ public class MapSessionRepositoryTests { ExpiringSession session = repository.createSession(); assertThat(session).isInstanceOf(MapSession.class); - assertThat(session.getMaxInactiveInterval()).isEqualTo(new MapSession().getMaxInactiveInterval()); + assertThat(session.getMaxInactiveIntervalInSeconds()).isEqualTo(new MapSession().getMaxInactiveIntervalInSeconds()); } @Test public void createSessionCustomDefaultExpiration() { - final int expectedMaxInterval = new MapSession().getMaxInactiveInterval() + 10; + final int expectedMaxInterval = new MapSession().getMaxInactiveIntervalInSeconds() + 10; repository.setDefaultMaxInactiveInterval(expectedMaxInterval); ExpiringSession session = repository.createSession(); - assertThat(session.getMaxInactiveInterval()).isEqualTo(expectedMaxInterval); + assertThat(session.getMaxInactiveIntervalInSeconds()).isEqualTo(expectedMaxInterval); } } \ No newline at end of file diff --git a/spring-session/src/test/java/org/springframework/session/MapSessionTests.java b/spring-session/src/test/java/org/springframework/session/MapSessionTests.java index 7a666404..2f3c7b40 100644 --- a/spring-session/src/test/java/org/springframework/session/MapSessionTests.java +++ b/spring-session/src/test/java/org/springframework/session/MapSessionTests.java @@ -83,11 +83,11 @@ public class MapSessionTests { return 0; } - public void setMaxInactiveInterval(int interval) { + public void setMaxInactiveIntervalInSeconds(int interval) { } - public int getMaxInactiveInterval() { + public int getMaxInactiveIntervalInSeconds() { return 0; } diff --git a/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java b/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java index ae3822b2..cc5e1bfd 100644 --- a/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java +++ b/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java @@ -78,7 +78,7 @@ public class RedisOperationsSessionRepositoryTests { @Test public void createSessionDefaultMaxInactiveInterval() throws Exception { ExpiringSession session = redisRepository.createSession(); - assertThat(session.getMaxInactiveInterval()).isEqualTo(new MapSession().getMaxInactiveInterval()); + assertThat(session.getMaxInactiveIntervalInSeconds()).isEqualTo(new MapSession().getMaxInactiveIntervalInSeconds()); } @Test @@ -86,7 +86,7 @@ public class RedisOperationsSessionRepositoryTests { int interval = 1; redisRepository.setDefaultMaxInactiveInterval(interval); ExpiringSession session = redisRepository.createSession(); - assertThat(session.getMaxInactiveInterval()).isEqualTo(interval); + assertThat(session.getMaxInactiveIntervalInSeconds()).isEqualTo(interval); } @Test @@ -164,7 +164,7 @@ public class RedisOperationsSessionRepositoryTests { Map map = map( getSessionAttrNameKey(attrName), expected.getAttribute(attrName), CREATION_TIME_ATTR, expected.getCreationTime(), - MAX_INACTIVE_ATTR, expected.getMaxInactiveInterval(), + MAX_INACTIVE_ATTR, expected.getMaxInactiveIntervalInSeconds(), LAST_ACCESSED_ATTR, expected.getLastAccessedTime()); when(boundHashOperations.entries()).thenReturn(map); when(expirationRedisOperations.boundSetOps(anyString())).thenReturn(boundSetOperations); @@ -206,7 +206,7 @@ public class RedisOperationsSessionRepositoryTests { Map map = map( getSessionAttrNameKey(attrName), expected.getAttribute(attrName), CREATION_TIME_ATTR, expected.getCreationTime(), - MAX_INACTIVE_ATTR, expected.getMaxInactiveInterval(), + MAX_INACTIVE_ATTR, expected.getMaxInactiveIntervalInSeconds(), LAST_ACCESSED_ATTR, expected.getLastAccessedTime()); when(boundHashOperations.entries()).thenReturn(map); @@ -216,7 +216,7 @@ public class RedisOperationsSessionRepositoryTests { assertThat(session.getAttributeNames()).isEqualTo(expected.getAttributeNames()); assertThat(session.getAttribute(attrName)).isEqualTo(expected.getAttribute(attrName)); assertThat(session.getCreationTime()).isEqualTo(expected.getCreationTime()); - assertThat(session.getMaxInactiveInterval()).isEqualTo(expected.getMaxInactiveInterval()); + assertThat(session.getMaxInactiveIntervalInSeconds()).isEqualTo(expected.getMaxInactiveIntervalInSeconds()); assertThat(session.getLastAccessedTime()).isGreaterThanOrEqualTo(now); }