From 3a1fd12709d27ecea7e9e97de9fc3e3296df9ad0 Mon Sep 17 00:00:00 2001 From: Deboshree Date: Sun, 21 May 2023 23:36:38 +0530 Subject: [PATCH] removed optional specific function --- .../baeldung/stringtoint/StringToIntConverter.java | 11 ----------- .../stringtoint/StringToIntConverterUnitTest.java | 2 -- 2 files changed, 13 deletions(-) diff --git a/core-java-modules/core-java-string-conversions-3/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java b/core-java-modules/core-java-string-conversions-3/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java index 6e7ea05bd7..151dcb3fdb 100644 --- a/core-java-modules/core-java-string-conversions-3/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java +++ b/core-java-modules/core-java-string-conversions-3/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java @@ -31,17 +31,6 @@ public class StringToIntConverter { } } - Optional convertStringToIntUsingOptional(String input){ - Optional parsedInt; - try { - parsedInt = Optional.of(Integer.parseInt(input)); - } catch (Exception e) { - // log or handle the error - parsedInt = Optional.empty(); - } - return parsedInt; - } - int convertStringToIntUsingNumberUtils(String input, Integer defaultValue){ return NumberUtils.toInt(input, defaultValue); } diff --git a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java index c0c5da7731..5f6d2ae73f 100644 --- a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java +++ b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java @@ -22,7 +22,6 @@ class stringToIntConverter { testData.forEach(data -> { Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input).orElse(Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input).orElse(Integer.MIN_VALUE)); - Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingOptional(data.input).orElse(Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerDecode(data.input).orElse(Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingNumberUtils(data.input,Integer.MIN_VALUE )); }); @@ -37,7 +36,6 @@ class stringToIntConverter { testData.forEach(data -> { Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input).orElse(Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input).orElse(Integer.MIN_VALUE)); - Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingOptional(data.input).orElse(Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingNumberUtils(data.input, Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerDecode(data.input).orElse(Integer.MIN_VALUE)); });