BAEL-5246: pom cleanup (#4620)

* BAEL-5246: round 1 of pom cleanup - upto "jersey" project

* BAEL-5246: Initial pass for pom cleanup - upto spring-cloud

* BAEL-5246: pom cleanup upto testing-modules/junit5

* BAEL-5246: pom cleanup - upto xstream

* BAEL-5246: pom cleanup - last round (before review)

spring-boot-custom-starter/greeter-spring-boot-autoconfigure/pom.xml

@@ -13,12 +13,6 @@
         <relativePath>../../spring-boot-custom-starter</relativePath>
     </parent>
 
-    <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <spring-boot.version>1.5.2.RELEASE</spring-boot.version>
-        <greeter.version>0.0.1-SNAPSHOT</greeter.version>
-    </properties>
-
     <dependencies>
 
         <dependency>
@@ -54,13 +48,20 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.7.0</version>
+                <version>${maven-compiler-plugin.version}</version>
                 <configuration>
-                    <source>1.8</source>
-                    <target>1.8</target>
+                    <source>${java.version}</source>
+                    <target>${java.version}</target>
                 </configuration>
             </plugin>
         </plugins>
     </build>
 
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <spring-boot.version>1.5.2.RELEASE</spring-boot.version>
+        <greeter.version>0.0.1-SNAPSHOT</greeter.version>
+        
+    </properties>
+
 </project>

spring-boot-custom-starter/greeter-spring-boot-sample-app/pom.xml

@@ -1,5 +1,5 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <groupId>com.baeldung</groupId>
@@ -13,19 +13,16 @@
         <relativePath>../../parent-boot-1</relativePath>
     </parent>
 
-    <properties>
-        <greeter-starter.version>0.0.1-SNAPSHOT</greeter-starter.version>
-    </properties>
-
     <dependencies>
-
         <dependency>
             <groupId>com.baeldung</groupId>
             <artifactId>greeter-spring-boot-starter</artifactId>
             <version>${greeter-starter.version}</version>
         </dependency>
-
     </dependencies>
 
+    <properties>
+        <greeter-starter.version>0.0.1-SNAPSHOT</greeter-starter.version>
+    </properties>
 
 </project>

spring-boot-custom-starter/greeter-spring-boot-starter/pom.xml

@@ -13,12 +13,6 @@
         <relativePath>../../spring-boot-custom-starter</relativePath>
     </parent>
 
-    <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <greeter.version>0.0.1-SNAPSHOT</greeter.version>
-        <spring-boot.version>1.5.2.RELEASE</spring-boot.version>
-    </properties>
-
     <dependencies>
 
         <dependency>
@@ -46,13 +40,19 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.7.0</version>
+                <version>${maven-compiler-plugin.version}</version>
                 <configuration>
-                    <source>1.8</source>
-                    <target>1.8</target>
+                    <source>${java.version}</source>
+                    <target>${java.version}</target>
                 </configuration>
             </plugin>
         </plugins>
     </build>
 
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <greeter.version>0.0.1-SNAPSHOT</greeter.version>
+        <spring-boot.version>1.5.2.RELEASE</spring-boot.version>
+    </properties>
+
 </project>

spring-boot-custom-starter/greeter/pom.xml

@@ -0,0 +1,14 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>com.baeldung</groupId>
+    <artifactId>greeter</artifactId>
+    <version>0.0.1-SNAPSHOT</version>
+    <parent>
+        <artifactId>parent-boot-1</artifactId>
+        <groupId>com.baeldung</groupId>
+        <version>0.0.1-SNAPSHOT</version>
+        <relativePath>../../parent-boot-1</relativePath>
+    </parent>
+</project>

spring-boot-custom-starter/pom.xml

@@ -1,5 +1,5 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.baeldung</groupId>
     <artifactId>spring-boot-custom-starter</artifactId>
@@ -19,8 +19,4 @@
         <module>greeter-spring-boot-sample-app</module>
     </modules>
 
-    <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    </properties>
-
 </project>