From b899265a3137040e854d66a237cb26c8fbaa496e Mon Sep 17 00:00:00 2001 From: "Amitabh.Tiwari" Date: Tue, 15 Jun 2021 20:09:17 +0530 Subject: [PATCH 1/5] BAEL-4960: Test for conversion --- .../StringToBigIntegerUnitTest.java | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java diff --git a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java new file mode 100644 index 0000000000..d3b6467eab --- /dev/null +++ b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java @@ -0,0 +1,44 @@ +package com.baeldung.stringtobybiginteger; + +import static org.junit.Assert.assertEquals; + +import java.math.BigInteger; + +import org.junit.Test; + +public class StringToBigIntegerUnitTest { + + @Test + public void whenGetStringWithOutRadix_thenOK() { + final String inputString = "878"; + BigInteger result = new BigInteger(inputString); + assertEquals("878", result.toString()); + } + + @Test + public void whenGetStringWithRadix_thenOK() { + final String inputString = "290f98"; + BigInteger result = new BigInteger(inputString, 16); + assertEquals("2690968", result.toString()); + } + + @Test(expected = NumberFormatException.class) + public void whenGetStringWithOutRadix_thenThrowError() { + final String inputString = "290f98"; + new BigInteger(inputString); + } + + @Test(expected = NumberFormatException.class) + public void whenGetStringWithRadix_thenThrowError() { + final String inputString = "Hello Baeldung"; + new BigInteger(inputString, 7); + } + + @Test + public void whenGetStringUsingByte_thenOk() { + final String inputString = "Hello Baeldung"; + byte[] inputStringBytes = inputString.getBytes(); + BigInteger result = new BigInteger(inputStringBytes); + assertEquals("Hello Baeldung", new String(result.toByteArray())); + } +} From 268f9d73bf23f3c2a5cc242819f7016c2b0b399c Mon Sep 17 00:00:00 2001 From: "Amitabh.Tiwari" Date: Tue, 15 Jun 2021 20:13:37 +0530 Subject: [PATCH 2/5] Removal of unwanted spaces --- .../StringToBigIntegerUnitTest.java | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java index d3b6467eab..b535797d44 100644 --- a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java +++ b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java @@ -7,38 +7,38 @@ import java.math.BigInteger; import org.junit.Test; public class StringToBigIntegerUnitTest { - - @Test - public void whenGetStringWithOutRadix_thenOK() { - final String inputString = "878"; - BigInteger result = new BigInteger(inputString); - assertEquals("878", result.toString()); - } - @Test - public void whenGetStringWithRadix_thenOK() { - final String inputString = "290f98"; - BigInteger result = new BigInteger(inputString, 16); - assertEquals("2690968", result.toString()); - } + @Test + public void whenGetStringWithOutRadix_thenOK() { + final String inputString = "878"; + BigInteger result = new BigInteger(inputString); + assertEquals("878", result.toString()); + } - @Test(expected = NumberFormatException.class) - public void whenGetStringWithOutRadix_thenThrowError() { - final String inputString = "290f98"; - new BigInteger(inputString); - } + @Test + public void whenGetStringWithRadix_thenOK() { + final String inputString = "290f98"; + BigInteger result = new BigInteger(inputString, 16); + assertEquals("2690968", result.toString()); + } - @Test(expected = NumberFormatException.class) - public void whenGetStringWithRadix_thenThrowError() { - final String inputString = "Hello Baeldung"; - new BigInteger(inputString, 7); - } + @Test(expected = NumberFormatException.class) + public void whenGetStringWithOutRadix_thenThrowError() { + final String inputString = "290f98"; + new BigInteger(inputString); + } - @Test - public void whenGetStringUsingByte_thenOk() { - final String inputString = "Hello Baeldung"; - byte[] inputStringBytes = inputString.getBytes(); - BigInteger result = new BigInteger(inputStringBytes); - assertEquals("Hello Baeldung", new String(result.toByteArray())); - } + @Test(expected = NumberFormatException.class) + public void whenGetStringWithRadix_thenThrowError() { + final String inputString = "Hello Baeldung"; + new BigInteger(inputString, 7); + } + + @Test + public void whenGetStringUsingByte_thenOk() { + final String inputString = "Hello Baeldung"; + byte[] inputStringBytes = inputString.getBytes(); + BigInteger result = new BigInteger(inputStringBytes); + assertEquals("Hello Baeldung", new String(result.toByteArray())); + } } From 5b1f24f5a801cc5a67ba0a17b23f88f3bd1b3612 Mon Sep 17 00:00:00 2001 From: "Amitabh.Tiwari" Date: Wed, 23 Jun 2021 10:22:35 +0530 Subject: [PATCH 3/5] Corrected test as per review comments --- .../stringtobybiginteger/StringToBigIntegerUnitTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java index b535797d44..54c9617718 100644 --- a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java +++ b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java @@ -30,13 +30,13 @@ public class StringToBigIntegerUnitTest { @Test(expected = NumberFormatException.class) public void whenGetStringWithRadix_thenThrowError() { - final String inputString = "Hello Baeldung"; + final String inputString = "290f98"; new BigInteger(inputString, 7); } @Test public void whenGetStringUsingByte_thenOk() { - final String inputString = "Hello Baeldung"; + final String inputString = "290f98"; byte[] inputStringBytes = inputString.getBytes(); BigInteger result = new BigInteger(inputStringBytes); assertEquals("Hello Baeldung", new String(result.toByteArray())); From 365e8cca059ab53fd93975cde8f73e95160be83c Mon Sep 17 00:00:00 2001 From: "Amitabh.Tiwari" Date: Mon, 28 Jun 2021 18:57:48 +0530 Subject: [PATCH 4/5] Corrected the tests --- .../stringtobybiginteger/StringToBigIntegerUnitTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java index 54c9617718..8d47d72a0e 100644 --- a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java +++ b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java @@ -39,6 +39,6 @@ public class StringToBigIntegerUnitTest { final String inputString = "290f98"; byte[] inputStringBytes = inputString.getBytes(); BigInteger result = new BigInteger(inputStringBytes); - assertEquals("Hello Baeldung", new String(result.toByteArray())); + assertEquals("290f98", new String(result.toByteArray())); } } From ced95d0e2342e4fc3ae3a8b2e11f601e6bb741ed Mon Sep 17 00:00:00 2001 From: "Amitabh.Tiwari" Date: Sun, 11 Jul 2021 12:15:12 +0530 Subject: [PATCH 5/5] Added changes as per review --- .../StringToBigIntegerUnitTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java index 8d47d72a0e..82ffe96d84 100644 --- a/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java +++ b/core-java-modules/core-java-string-conversions-2/src/test/java/com/baeldung/stringtobybiginteger/StringToBigIntegerUnitTest.java @@ -10,33 +10,33 @@ public class StringToBigIntegerUnitTest { @Test public void whenGetStringWithOutRadix_thenOK() { - final String inputString = "878"; + String inputString = "878"; BigInteger result = new BigInteger(inputString); assertEquals("878", result.toString()); } @Test public void whenGetStringWithRadix_thenOK() { - final String inputString = "290f98"; + String inputString = "290f98"; BigInteger result = new BigInteger(inputString, 16); assertEquals("2690968", result.toString()); } @Test(expected = NumberFormatException.class) public void whenGetStringWithOutRadix_thenThrowError() { - final String inputString = "290f98"; + String inputString = "290f98"; new BigInteger(inputString); } @Test(expected = NumberFormatException.class) public void whenGetStringWithRadix_thenThrowError() { - final String inputString = "290f98"; + String inputString = "290f98"; new BigInteger(inputString, 7); } @Test public void whenGetStringUsingByte_thenOk() { - final String inputString = "290f98"; + String inputString = "290f98"; byte[] inputStringBytes = inputString.getBytes(); BigInteger result = new BigInteger(inputStringBytes); assertEquals("290f98", new String(result.toByteArray()));