mindol1004/spring-soap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor | Add common formatting, remove comments, update test class name,follow test method naming convention and use Junit5

Browse Source
This commit is contained in:
Vishal
2020-08-17 18:06:20 +05:30
parent e3d787a3c8
commit f621693bdd
3 changed files with 62 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparison.java
View File

@@ -1,46 +0,0 @@
package com.baeldung.listassert;
import org.hamcrest.Matchers;
import org.apache.commons.collections4.CollectionUtils;
import org.junit.Test;
import java.util.Arrays;
import java.util.List;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
public class OrderAgnosticListComparison {
private final List<Integer> first = Arrays.asList(1, 3, 4, 6, 8);
private final List<Integer> second = Arrays.asList(8, 1, 6, 3, 4);
private final List<Integer> third = Arrays.asList(1, 3, 3, 6, 6);
//In this test using simple JUnit assertion
@Test
public void whenTestingForOrderAgnosticEqualityShouldBeTrue() {
assertTrue(first.size() == second.size() &&
first.containsAll(second) && second.containsAll(first));
}
@Test
public void whenTestingForOrderAgnosticEqualityShouldBeFalse() {
assertFalse(first.size() == third.size() &&
first.containsAll(third) && third.containsAll(first));
}
//In this test using Hamcrest lib apis for assertion
@Test
public void whenTestingForOrderAgnosticEqualityShouldBeEqual() {
assertThat(first, Matchers.containsInAnyOrder(second.toArray()));
}
//In this test asserting lists using Apache Commons apis
@Test
public void whenTestingForOrderAgnosticEqualityShouldBeTrueIfEqualOtherwiseFalse() {
assertTrue(CollectionUtils.isEqualCollection(first, second));
assertFalse(CollectionUtils.isEqualCollection(first, third));
}
}

40
testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparisonUnitTest.java Normal file
View File

@@ -0,0 +1,40 @@
package com.baeldung.listassert;
import org.apache.commons.collections4.CollectionUtils;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.Test;
import java.util.Arrays;
import java.util.List;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class OrderAgnosticListComparisonUnitTest {
private final List<Integer> first = Arrays.asList(1, 3, 4, 6, 8);
private final List<Integer> second = Arrays.asList(8, 1, 6, 3, 4);
private final List<Integer> third = Arrays.asList(1, 3, 3, 6, 6);
@Test
public void whenTestingForOrderAgnosticEquality_ShouldBeTrue() {
assertTrue(first.size() == second.size() && first.containsAll(second) && second.containsAll(first));
}
@Test
public void whenTestingForOrderAgnosticEquality_ShouldBeFalse() {
assertFalse(first.size() == third.size() && first.containsAll(third) && third.containsAll(first));
}
@Test
public void whenTestingForOrderAgnosticEquality_ShouldBeEqual() {
assertThat(first, Matchers.containsInAnyOrder(second.toArray()));
}
@Test
public void whenTestingForOrderAgnosticEquality_ShouldBeTrueIfEqualOtherwiseFalse() {
assertTrue(CollectionUtils.isEqualCollection(first, second));
assertFalse(CollectionUtils.isEqualCollection(first, third));
}
}