From ff19b0e0578f157dccced13666a62355b0023ed5 Mon Sep 17 00:00:00 2001 From: Kai Yuan Date: Sat, 10 Sep 2022 17:06:11 +0200 Subject: [PATCH] Positive or negative (#12706) * Check if a number is positive or negative in Java * reformat single line if/else statements * Check if a number is positive or negative in Java * [positiveOrNegative] using compareTo() instead of == to compare float numbers * [positiveOrNegative] re-org imports --- .../com/baeldung/positivenegative/PositiveOrNegative.java | 6 +++--- .../positivenegative/PositiveOrNegativeUnitTest.java | 8 +++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/core-java-modules/core-java-numbers-5/src/main/java/com/baeldung/positivenegative/PositiveOrNegative.java b/core-java-modules/core-java-numbers-5/src/main/java/com/baeldung/positivenegative/PositiveOrNegative.java index a580aa5ac5..0fa32a0425 100644 --- a/core-java-modules/core-java-numbers-5/src/main/java/com/baeldung/positivenegative/PositiveOrNegative.java +++ b/core-java-modules/core-java-numbers-5/src/main/java/com/baeldung/positivenegative/PositiveOrNegative.java @@ -26,11 +26,11 @@ public class PositiveOrNegative { } public static Result bySignum(Float floatNumber) { - float result = Math.signum(floatNumber); + Float result = Math.signum(floatNumber); - if (result == 1.0f) { + if (result.compareTo(1.0f) == 0) { return Result.POSITIVE; - } else if (result == -1.0f) { + } else if (result.compareTo(-1.0f) == 0) { return Result.NEGATIVE; } return Result.ZERO; diff --git a/core-java-modules/core-java-numbers-5/src/test/java/com/baeldung/positivenegative/PositiveOrNegativeUnitTest.java b/core-java-modules/core-java-numbers-5/src/test/java/com/baeldung/positivenegative/PositiveOrNegativeUnitTest.java index 4807e8b928..847ef6edb6 100644 --- a/core-java-modules/core-java-numbers-5/src/test/java/com/baeldung/positivenegative/PositiveOrNegativeUnitTest.java +++ b/core-java-modules/core-java-numbers-5/src/test/java/com/baeldung/positivenegative/PositiveOrNegativeUnitTest.java @@ -1,10 +1,12 @@ package com.baeldung.positivenegative; -import org.junit.jupiter.api.Test; - -import static com.baeldung.positivenegative.PositiveOrNegative.Result.*; +import static com.baeldung.positivenegative.PositiveOrNegative.Result.NEGATIVE; +import static com.baeldung.positivenegative.PositiveOrNegative.Result.POSITIVE; +import static com.baeldung.positivenegative.PositiveOrNegative.Result.ZERO; import static org.junit.jupiter.api.Assertions.assertEquals; +import org.junit.jupiter.api.Test; + class PositiveOrNegativeUnitTest { @Test void givenIntegers_whenChkPositiveOrNegativeByOperator_thenReturnExpectedResult() {