github/quartz-manager
1
0
Fork 0
mirror of https://github.com/fabioformosa/quartz-manager.git synced 2026-05-29 21:20:29 +09:00
Code Issues Packages Projects Releases Wiki Activity

#57 fixed tests

Browse Source
This commit is contained in:
Fabio Formosa
2022-11-03 22:11:44 +01:00
parent 121f2e364f
commit a8fb990966
3 changed files with 52 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
quartz-manager-frontend/src/app/components/simple-trigger-config/simple-trigger-config.component.html
View File

@@ -142,7 +142,6 @@
</button>
<button mat-raised-button
type="submit" color="primary"
[disabled]="!simpleTriggerReactiveForm.valid"
*ngIf="enabledTriggerForm">
Submit
</button>

61
quartz-manager-frontend/src/app/components/simple-trigger-config/simple-trigger-config.component.spec.ts
View File

@@ -8,7 +8,7 @@ import {DebugElement, NO_ERRORS_SCHEMA} from '@angular/core';
import {By} from '@angular/platform-browser';
import {RouterTestingModule} from '@angular/router/testing';
import {MatIconModule} from '@angular/material/icon';
import {FormsModule} from '@angular/forms';
import {FormBuilder, FormsModule, ReactiveFormsModule} from '@angular/forms';
import {MatFormFieldModule} from '@angular/material/form-field';
import {MatNativeDateModule} from '@angular/material/core';
import {MatInputModule} from '@angular/material/input';
@@ -16,10 +16,10 @@ import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
import {TriggerKey} from '../../model/triggerKey.model';
import {Trigger} from '../../model/trigger.model';
import {JobDetail} from '../../model/jobDetail.model';
import {SimpleTriggerForm} from '../../model/simple-trigger.form';
import {SimpleTrigger} from '../../model/simple-trigger.model';
import JobService from '../../services/job.service';
import {MatSelectModule} from '@angular/material/select';
import {MisfireInstruction} from '../../model/misfire-instruction.model';
describe('SimpleTriggerConfig', () => {
@@ -32,10 +32,10 @@ describe('SimpleTriggerConfig', () => {
beforeEach(async( () => {
TestBed.configureTestingModule({
imports: [FormsModule, MatFormFieldModule, MatFormFieldModule, MatSelectModule, MatInputModule, BrowserAnimationsModule,
MatNativeDateModule,
MatNativeDateModule, ReactiveFormsModule,
MatCardModule, MatIconModule, HttpClientTestingModule, RouterTestingModule],
declarations: [SimpleTriggerConfigComponent],
providers: [SchedulerService, ApiService, ConfigService, JobService],
providers: [SchedulerService, ApiService, ConfigService, JobService, FormBuilder],
schemas: [NO_ERRORS_SCHEMA]
}).compileComponents();
@@ -62,24 +62,46 @@ describe('SimpleTriggerConfig', () => {
fixture.detectChanges();
}
function setDropdownValue(componentDe: DebugElement, dropdownSelector: string, value: string) {
const dropdownDe = componentDe.query(By.css(dropdownSelector));
const dropdownEl = dropdownDe.nativeElement;
dropdownEl.value = value;
dropdownEl.dispatchEvent(new Event('change'));
fixture.detectChanges();
}
function setDropdownValueByIndex(componentDe: DebugElement, dropdownSelector: string, index: number) {
const dropdownDe = componentDe.query(By.css(dropdownSelector));
const dropdownEl = dropdownDe.nativeElement;
dropdownEl.value = dropdownEl.options[index].value;
dropdownEl.dispatchEvent(new Event('change'));
fixture.detectChanges();
}
function setMatSelectValueByIndex(componentDe: DebugElement, dropdownSelector: string, index: number) {
const dropdownDe = componentDe.query(By.css(dropdownSelector));
dropdownDe.triggerEventHandler('selectionChange', {value: 'MISFIRE_INSTRUCTION_FIRE_NOW'});
const dropdownEl = dropdownDe.nativeElement;
dropdownEl.dispatchEvent(new Event('change'));
fixture.detectChanges();
}
it('should emit an event when a new trigger is submitted', () => {
const mockTrigger = new Trigger();
mockTrigger.triggerKeyDTO = new TriggerKey('test-trigger', null);
mockTrigger.jobDetailDTO = <JobDetail>{jobClassName: 'TestJob', description: null};
mockTrigger.misfireInstruction = MisfireInstruction.MISFIRE_INSTRUCTION_FIRE_NOW;
component.openTriggerForm();
fixture.detectChanges();
const componentDe: DebugElement = fixture.debugElement;
setInputValue(componentDe, '#triggerName', 'test-trigger');
expect(component.simpleTriggerForm.triggerName).toEqual('test-trigger');
expect(component.simpleTriggerReactiveForm.controls.triggerName.value).toEqual('test-trigger');
setInputValue(componentDe, '#jobClass', 'TestJob');
// setInputValue(componentDe, '#startDate', '19/11/2022, 10:34:00 PM');
// setInputValue(componentDe, '#endDate', '21/11/2022, 10:34:00 PM');
setInputValue(componentDe, '#repeatInterval', '2000');
expect(component.simpleTriggerForm.repeatInterval).toEqual(2000);
expect(component.simpleTriggerReactiveForm.controls.triggerRecurrence.value.repeatInterval).toEqual(2000);
setInputValue(componentDe, '#repeatCount', '100');
expect(component.simpleTriggerForm.repeatCount).toEqual(100);
expect(component.simpleTriggerReactiveForm.controls.triggerRecurrence.value.repeatCount).toEqual(100);
const submitButton = componentDe.query(By.css('form > button[color="primary"]'));
expect(submitButton.nativeElement.textContent.trim()).toEqual('Submit');
@@ -89,6 +111,9 @@ describe('SimpleTriggerConfig', () => {
submitButton.nativeElement.click();
const getJobsReq = httpTestingController.expectOne(`${CONTEXT_PATH}/jobs`);
getJobsReq.flush(['TestJob']);
const postSimpleTriggerReq = httpTestingController.expectOne(`${CONTEXT_PATH}/simple-triggers/test-trigger`);
postSimpleTriggerReq.flush(mockTrigger);
@@ -104,22 +129,30 @@ describe('SimpleTriggerConfig', () => {
mockTrigger.triggerKeyDTO = new TriggerKey('test-trigger', null);
mockTrigger.jobDetailDTO = <JobDetail>{jobClassName: 'TestJob', description: null};
mockTrigger.mayFireAgain = true;
mockTrigger.misfireInstruction = MisfireInstruction.MISFIRE_INSTRUCTION_FIRE_NOW;
const getSimpleTriggerReq = httpTestingController.expectOne(`${CONTEXT_PATH}/simple-triggers/test-trigger`);
getSimpleTriggerReq.flush(mockTrigger);
component.simpleTriggerForm = <SimpleTriggerForm>{
component.simpleTriggerReactiveForm.setValue({
triggerName: 'test-trigger',
jobClass: 'TestJob',
repeatInterval: 2000,
repeatCount: 100
};
triggerRecurrence: {
repeatInterval: 2000,
repeatCount: 100,
},
triggerPeriod: {
startDate: null,
endDate: null
},
misfireInstruction: MisfireInstruction.MISFIRE_INSTRUCTION_FIRE_NOW.toString()
});
component.openTriggerForm();
fixture.detectChanges();
const componentDe: DebugElement = fixture.debugElement;
setInputValue(componentDe, '#repeatInterval', '4000');
expect(component.simpleTriggerForm.repeatInterval).toEqual(4000);
expect(component.simpleTriggerReactiveForm.controls.triggerRecurrence.value.repeatInterval).toEqual(4000);
const submitButton = componentDe.query(By.css('form > button[color="primary"]'));
expect(submitButton.nativeElement.textContent.trim()).toEqual('Submit');

10
quartz-manager-frontend/src/app/components/simple-trigger-config/simple-trigger-config.component.ts
View File

@@ -133,11 +133,11 @@ export class SimpleTriggerConfigComponent implements OnInit {
const simpleTriggerReactiveForm = new SimpleTriggerReactiveForm();
simpleTriggerReactiveForm.triggerName = simpleTrigger.triggerKeyDTO.name;
simpleTriggerReactiveForm.jobClass = simpleTrigger.jobDetailDTO.jobClassName;
simpleTriggerReactiveForm.triggerRecurrence.repeatCount = simpleTrigger.repeatCount;
simpleTriggerReactiveForm.triggerRecurrence.repeatInterval = simpleTrigger.repeatInterval;
simpleTriggerReactiveForm.triggerPeriod.startDate = simpleTrigger.startTime && moment(simpleTrigger.startTime);
simpleTriggerReactiveForm.triggerPeriod.endDate = simpleTrigger.endTime && moment(simpleTrigger.endTime);
simpleTriggerReactiveForm.misfireInstruction = MisfireInstruction[simpleTrigger.misfireInstruction];
simpleTriggerReactiveForm.triggerRecurrence.repeatCount = simpleTrigger.repeatCount || null;
simpleTriggerReactiveForm.triggerRecurrence.repeatInterval = simpleTrigger.repeatInterval || null;
simpleTriggerReactiveForm.triggerPeriod.startDate = (simpleTrigger.startTime && moment(simpleTrigger.startTime)) || null;
simpleTriggerReactiveForm.triggerPeriod.endDate = (simpleTrigger.endTime && moment(simpleTrigger.endTime)) || null;
simpleTriggerReactiveForm.misfireInstruction = (simpleTrigger.misfireInstruction && MisfireInstruction[simpleTrigger.misfireInstruction]) || null;
return simpleTriggerReactiveForm;
};