mindol1004/MangKyu-erros
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add default answerResourceId on GetQuizResponse

Browse Source
This commit is contained in:
MangKyu
2022-01-06 23:28:43 +09:00
parent 0997ee5de9
commit aadb2b34ce
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/com/mangkyu/employment/interview/app/quiz/converter/QuizDtoConverter.java
View File

@@ -8,6 +8,7 @@ import com.mangkyu.employment.interview.app.quiz.entity.Quiz;
import com.mangkyu.employment.interview.enums.common.EnumMapperValue;
import com.mangkyu.employment.interview.enums.value.QuizLevel;
import lombok.NoArgsConstructor;
import org.apache.commons.lang3.StringUtils;
import java.sql.Timestamp;
import java.util.List;
@@ -61,7 +62,7 @@ public final class QuizDtoConverter {
private static String getAnswerResourceId(final Quiz quiz) {
return (quiz.getAnswer() == null)
? null
? StringUtils.EMPTY
: quiz.getAnswer().getResourceId();
}

2
src/main/java/com/mangkyu/employment/interview/app/quiz/dto/GetQuizResponse.java
View File

@@ -14,8 +14,6 @@ import java.util.List;
public class GetQuizResponse {
private final String resourceId;
@JsonInclude(JsonInclude.Include.NON_NULL)
private final String answerResourceId;
private final String title;

5
src/test/java/com/mangkyu/employment/interview/app/quiz/converter/QuizDtoConverterTest.java
View File

@@ -8,6 +8,7 @@ import com.mangkyu.employment.interview.app.quiz.entity.Quiz;
import com.mangkyu.employment.interview.enums.common.EnumMapperType;
import com.mangkyu.employment.interview.enums.common.EnumMapperValue;
import com.mangkyu.employment.interview.testutils.EntityCreationUtils;
import org.apache.commons.lang3.StringUtils;
import org.junit.jupiter.api.Test;
import java.sql.Timestamp;
@@ -83,7 +84,7 @@ class QuizDtoConverterTest {
assertThat(result.getQuizLevelList().size()).isEqualTo(quiz.getQuizLevel().size());
assertThat(result.getCreatedAt()).isEqualTo(Timestamp.valueOf(quiz.getCreatedAt()).getTime());
assertThat(result.getCategory().getCode()).isEqualTo(enumMapperValue(quiz.getQuizCategory()).getCode());
assertThat(result.getAnswerResourceId()).isNull();
assertThat(result.getAnswerResourceId()).isEqualTo(StringUtils.EMPTY);
}
@Test
@@ -119,7 +120,7 @@ class QuizDtoConverterTest {
assertThat(result.getQuizLevelList().size()).isEqualTo(quiz.getQuizLevel().size());
assertThat(result.getCreatedAt()).isEqualTo(Timestamp.valueOf(quiz.getCreatedAt()).getTime());
assertThat(result.getCategory()).isNull();
assertThat(result.getAnswerResourceId()).isNull();
assertThat(result.getAnswerResourceId()).isEqualTo(StringUtils.EMPTY);
}
private EnumMapperValue enumMapperValue(final EnumMapperType enumMapperType) {