refactor: removed unnecessary comments

This commit is contained in:
손창현
2022-07-02 03:00:50 +09:00
parent f4e32dc84c
commit 1fcae19f32
2 changed files with 16 additions and 9 deletions

View File

@@ -31,9 +31,7 @@ public class MovieTimeServiceImpl implements MovieTimeService {
Movie movie = movieRepository.findByTitle(title)
.orElseThrow(MovieTimeServiceImpl::throwMovieNotFound);
// 영화 시작 시간이 06시 이전(전날 심야 영화)는 제외하고 가져오기
LocalDateTime startOfDay = runningDate.atStartOfDay().plusHours(6);
// 영화 시작 시간이 익일 06시 이전(심야 영화)까지 모두 가져오기
LocalDateTime endOfDay = startOfDay.plusDays(1);
List<MovieTime> movieTimes = movieTimeRepository.findValidMovieTimes(movie.getId(), startOfDay, endOfDay);

View File

@@ -3,21 +3,23 @@ package com.ticketing.server.movie.service;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.when;
import com.ticketing.server.movie.domain.Movie;
import com.ticketing.server.movie.domain.repository.MovieRepository;
import com.ticketing.server.movie.domain.repository.MovieTimeRepository;
import com.ticketing.server.movie.service.dto.MovieDto;
import com.ticketing.server.movie.service.dto.MovieTimeDto;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.util.Collections;
import java.util.List;
import org.apache.tomcat.jni.Local;
import java.util.Optional;
import javax.transaction.Transactional;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.test.annotation.Rollback;
@ExtendWith(MockitoExtension.class)
public class MovieTimeServiceImplTest {
@@ -31,23 +33,30 @@ public class MovieTimeServiceImplTest {
@Mock
MovieTimeRepository movieTimeRepository;
@InjectMocks
MovieServiceImpl movieService;
@InjectMocks
MovieTimeServiceImpl movieTimeService;
@Test
@DisplayName("MovieTime Service Test - get movie times when there is no valid movie times")
@Transactional
@DisplayName("MovieTime Service Test - get empty list when there is no valid movie times")
void shouldGetEmptyList() {
// given
long movieId = 1L;
String title = "범죄도시2";
Movie movie = new Movie(title, 106);
when(movieRepository.findByTitle(title)).thenReturn(Optional.of(movie));
when(movieTimeRepository.findValidMovieTimes(movieId, startOfDay, endOfDay))
when(movieTimeRepository.findValidMovieTimes(1L, startOfDay, endOfDay))
.thenReturn(Collections.emptyList());
// when
List<MovieTimeDto> movieTimes = movieTimeService.getMovieTimes();
Optional<Movie> result = movieRepository.findByTitle(title);
List<MovieTimeDto> movieTimeDtoList = movieTimeService.getMovieTimes(title, LocalDate.now());
// then
assertTrue(movieDtoList.isEmpty());
assertTrue(movieTimeDtoList.isEmpty());
}
}