refactor: removed tmdb settings

This commit is contained in:
손창현
2022-07-02 02:37:39 +09:00
parent f7396d7986
commit 8d3f1b7208
7 changed files with 53 additions and 113 deletions

View File

@@ -1,9 +0,0 @@
package com.ticketing.server.movie.service;
import com.ticketing.server.movie.service.interfaces.TMDBService;
import org.springframework.stereotype.Service;
@Service
public class TMBDServiceImpl implements TMDBService {
}

View File

@@ -1,5 +0,0 @@
package com.ticketing.server.movie.service.interfaces;
public interface TMDBService {
}

View File

@@ -3,6 +3,7 @@ package com.ticketing.server.movie.domain.repository;
import javax.transaction.Transactional;
import org.junit.jupiter.api.MethodOrderer;
import org.junit.jupiter.api.TestMethodOrder;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
@SpringBootTest
@@ -10,4 +11,8 @@ import org.springframework.boot.test.context.SpringBootTest;
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class MovieTimeRepositoryTest {
@Autowired
MovieTimeRepository movieTimeRepository;
}

View File

@@ -42,7 +42,6 @@ public class MovieServiceImplTest {
// then
assertTrue(movieDtoList.isEmpty());
}
@Test

View File

@@ -1,5 +1,53 @@
package com.ticketing.server.movie.service;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.when;
import com.ticketing.server.movie.domain.repository.MovieRepository;
import com.ticketing.server.movie.domain.repository.MovieTimeRepository;
import com.ticketing.server.movie.service.dto.MovieDto;
import com.ticketing.server.movie.service.dto.MovieTimeDto;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.util.Collections;
import java.util.List;
import org.apache.tomcat.jni.Local;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class)
public class MovieTimeServiceImplTest {
LocalDateTime startOfDay = LocalDate.now().atStartOfDay().plusHours(6);
LocalDateTime endOfDay = startOfDay.plusDays(1);
@Mock
MovieRepository movieRepository;
@Mock
MovieTimeRepository movieTimeRepository;
@InjectMocks
MovieTimeServiceImpl movieTimeService;
@Test
@DisplayName("MovieTime Service Test - get movie times when there is no valid movie times")
void shouldGetEmptyList() {
// given
long movieId = 1L;
when(movieTimeRepository.findValidMovieTimes(movieId, startOfDay, endOfDay))
.thenReturn(Collections.emptyList());
// when
List<MovieTimeDto> movieTimes = movieTimeService.getMovieTimes();
// then
assertTrue(movieDtoList.isEmpty());
}
}

View File

@@ -1,94 +0,0 @@
package com.ticketing.server.movie.service;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Map;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.HttpEntity;
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpMethod;
import org.springframework.http.MediaType;
import org.springframework.http.ResponseEntity;
import org.springframework.web.client.RestTemplate;
@SpringBootTest
public class TMDBServiceImplTest {
@Value("${tmdb.api-key}")
private String apiKey;
@Value("${tmdb.read-access-token}")
private String readAccessToken;
@Autowired
RestTemplate restTemplate;
@Test
@DisplayName("TMDB Service Test - Get [Now Playing] movies")
void shouldAbleToGetMovieList() throws Exception {
// given
assertNotNull(apiKey);
assertNotNull(readAccessToken);
ArrayList<Charset> acceptCharset = new ArrayList<>();
acceptCharset.add(StandardCharsets.UTF_8);
HttpHeaders headers = new HttpHeaders();
headers.setAcceptCharset(acceptCharset);
headers.setContentType(MediaType.APPLICATION_JSON);
headers.setBearerAuth(readAccessToken);
Map<String, String> params = new HashMap<>();
params.put("api_key", apiKey);
params.put("language", "ko");
HttpEntity<?> request = new HttpEntity<>(headers);
// when
ResponseEntity<?> response = restTemplate.exchange(
"https://api.themoviedb.org/3/movie/now_playing?" + mapToUrlParam(params),
HttpMethod.GET,
request,
String.class
);
// JSONParser parser = new JSONParser();
// Object obj = parser.parse(String.valueOf(response));
// Object results = ((JSONObject) obj).get("results");
//
// ArrayList<String> movieList = new ArrayList<>();
//
// ArrayList<JSONObject> jsonMovieList = new ArrayList<>();
// then
assertTrue(response.getStatusCode().is2xxSuccessful());
}
private static String mapToUrlParam(Map<String, String> params) {
StringBuffer paramData = new StringBuffer();
for (Map.Entry<String, String> param : params.entrySet()) {
if (paramData.length() != 0) {
paramData.append('&');
}
paramData.append(param.getKey());
paramData.append('=');
paramData.append(param.getValue());
}
return paramData.toString();
}
}

View File

@@ -31,7 +31,3 @@ jwt:
secret-key: Zi1sYWItdGlja2V0aW5nLXByb2plY3Qtc3ByaW5nLWJvb3Qtc2VjdXJpdHktand0LXNlY3JldC1rZXktZi1sYWItdGlja2V0aW5nLXByb2plY3Qtc3ByaW5nLWJvb3Qtc2VjdXJpdHktand0LXNlY3JldC1rZXkK
access-token-validity-in-seconds: 60
refresh-token-validity-in-seconds: 259200
tmdb:
api-key: 0d1503b6dcbfe1c514299b5564c649b8
read-access-token: eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiIwZDE1MDNiNmRjYmZlMWM1MTQyOTliNTU2NGM2NDliOCIsInN1YiI6IjYyOWYwODRlNzI2ZmIxMTA2NDA4MjI2NCIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.rs8KZea8QLyashILiggWFx2s46lgUtzo-xSWoDgE58A