mindol1004/Ticketing
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: movieService test code

Browse Source
This commit is contained in:
손창현
2022-07-14 03:24:46 +09:00
parent 1691d9e9d8
commit e74095932a
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/src/main/java/com/ticketing/server/movie/domain/repository/MovieRepository.java
View File

@@ -16,7 +16,7 @@ public interface MovieRepository extends JpaRepository<Movie, Long> {
Optional<Movie> findByIdAndDeletedAtNull(Long id);
@Query(value = "SELECT m "
+ "FROM movie m "
+ "FROM Movie m "
+ "WHERE title = :title "
+ "AND deleted_at IS NULL")
Optional<Movie> findValidMovieWithTitle(String title);

11
server/src/test/java/com/ticketing/server/movie/service/MovieServiceImplTest.java
View File

@@ -6,6 +6,7 @@ import static org.mockito.Mockito.when;
import com.ticketing.server.movie.domain.Movie;
import com.ticketing.server.movie.domain.repository.MovieRepository;
import com.ticketing.server.movie.service.dto.MovieDTO;
import com.ticketing.server.movie.service.dto.MovieListDTO;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
@@ -38,10 +39,10 @@ public class MovieServiceImplTest {
.thenReturn(Collections.emptyList());
// when
List<MovieDTO> movieDTOList = movieService.getMovies();
MovieListDTO movieListDto = movieService.getMovies();
// then
assertTrue(movieDTOList.isEmpty());
assertTrue(movieListDto.getMovieDtos().isEmpty());
}
@Test
@@ -49,18 +50,16 @@ public class MovieServiceImplTest {
void shouldAbleToGetMovies() {
// given
movie = new Movie("범죄도시2", 106L);
movieDto = movieDto.from(movie);
movies.add(movie);
movieDTOS.add(movieDto);
when(movieRepository.findValidMovies())
.thenReturn(movies);
// when
List<MovieDTO> movieDTOList = movieService.getMovies();
MovieListDTO movieListDto = movieService.getMovies();
// then
assertTrue(!movieDTOList.isEmpty());
assertTrue(!movieListDto.getMovieDtos().isEmpty());
}
}