refactor: movieService test code
This commit is contained in:
@@ -16,7 +16,7 @@ public interface MovieRepository extends JpaRepository<Movie, Long> {
|
|||||||
Optional<Movie> findByIdAndDeletedAtNull(Long id);
|
Optional<Movie> findByIdAndDeletedAtNull(Long id);
|
||||||
|
|
||||||
@Query(value = "SELECT m "
|
@Query(value = "SELECT m "
|
||||||
+ "FROM movie m "
|
+ "FROM Movie m "
|
||||||
+ "WHERE title = :title "
|
+ "WHERE title = :title "
|
||||||
+ "AND deleted_at IS NULL")
|
+ "AND deleted_at IS NULL")
|
||||||
Optional<Movie> findValidMovieWithTitle(String title);
|
Optional<Movie> findValidMovieWithTitle(String title);
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import static org.mockito.Mockito.when;
|
|||||||
import com.ticketing.server.movie.domain.Movie;
|
import com.ticketing.server.movie.domain.Movie;
|
||||||
import com.ticketing.server.movie.domain.repository.MovieRepository;
|
import com.ticketing.server.movie.domain.repository.MovieRepository;
|
||||||
import com.ticketing.server.movie.service.dto.MovieDTO;
|
import com.ticketing.server.movie.service.dto.MovieDTO;
|
||||||
|
import com.ticketing.server.movie.service.dto.MovieListDTO;
|
||||||
import java.util.ArrayList;
|
import java.util.ArrayList;
|
||||||
import java.util.Collections;
|
import java.util.Collections;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
@@ -38,10 +39,10 @@ public class MovieServiceImplTest {
|
|||||||
.thenReturn(Collections.emptyList());
|
.thenReturn(Collections.emptyList());
|
||||||
|
|
||||||
// when
|
// when
|
||||||
List<MovieDTO> movieDTOList = movieService.getMovies();
|
MovieListDTO movieListDto = movieService.getMovies();
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assertTrue(movieDTOList.isEmpty());
|
assertTrue(movieListDto.getMovieDtos().isEmpty());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
@@ -49,18 +50,16 @@ public class MovieServiceImplTest {
|
|||||||
void shouldAbleToGetMovies() {
|
void shouldAbleToGetMovies() {
|
||||||
// given
|
// given
|
||||||
movie = new Movie("범죄도시2", 106L);
|
movie = new Movie("범죄도시2", 106L);
|
||||||
movieDto = movieDto.from(movie);
|
|
||||||
movies.add(movie);
|
movies.add(movie);
|
||||||
movieDTOS.add(movieDto);
|
|
||||||
|
|
||||||
when(movieRepository.findValidMovies())
|
when(movieRepository.findValidMovies())
|
||||||
.thenReturn(movies);
|
.thenReturn(movies);
|
||||||
|
|
||||||
// when
|
// when
|
||||||
List<MovieDTO> movieDTOList = movieService.getMovies();
|
MovieListDTO movieListDto = movieService.getMovies();
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assertTrue(!movieDTOList.isEmpty());
|
assertTrue(!movieListDto.getMovieDtos().isEmpty());
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user