mindol1004/buckpal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #27 from pat-karakun/master

Browse Source 
replace hardcoded package names with (unused) parameters
This commit is contained in:
Tom Hombergs
2022-10-13 16:28:42 +11:00
committed by GitHub
parent 919ae2de13 83ecaa202b
commit 7e8ea87312
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/java/io/reflectoring/buckpal/archunit/ArchitectureElement.java
View File

@@ -23,10 +23,10 @@ abstract class ArchitectureElement {
static void denyDependency(String fromPackageName, String toPackageName, JavaClasses classes) { static void denyDependency(String fromPackageName, String toPackageName, JavaClasses classes) {
noClasses() noClasses()
.that() .that()
.resideInAPackage("io.reflectoring.reviewapp.domain..") .resideInAPackage(matchAllClassesInPackage(fromPackageName))
.should() .should()
.dependOnClassesThat() .dependOnClassesThat()
.resideInAnyPackage("io.reflectoring.reviewapp.application..") .resideInAnyPackage(matchAllClassesInPackage(toPackageName))
.check(classes); .check(classes);
} }
@@ -34,13 +34,7 @@ abstract class ArchitectureElement {
List<String> fromPackages, List<String> toPackages, JavaClasses classes) { List<String> fromPackages, List<String> toPackages, JavaClasses classes) {
for (String fromPackage : fromPackages) { for (String fromPackage : fromPackages) {
for (String toPackage : toPackages) { for (String toPackage : toPackages) {
noClasses() denyDependency(fromPackage, toPackage, classes);
.that()
.resideInAPackage(matchAllClassesInPackage(fromPackage))
.should()
.dependOnClassesThat()
.resideInAnyPackage(matchAllClassesInPackage(toPackage))
.check(classes);
} }
} }
} }