replace hardcoded package names with (unused) parameters; reduce redundancy

This commit is contained in:
CHE0LIP
2021-04-09 10:50:46 +02:00
parent f5a9be5077
commit 83ecaa202b

View File

@@ -23,10 +23,10 @@ abstract class ArchitectureElement {
static void denyDependency(String fromPackageName, String toPackageName, JavaClasses classes) {
noClasses()
.that()
.resideInAPackage("io.reflectoring.reviewapp.domain..")
.resideInAPackage(matchAllClassesInPackage(fromPackageName))
.should()
.dependOnClassesThat()
.resideInAnyPackage("io.reflectoring.reviewapp.application..")
.resideInAnyPackage(matchAllClassesInPackage(toPackageName))
.check(classes);
}
@@ -34,13 +34,7 @@ abstract class ArchitectureElement {
List<String> fromPackages, List<String> toPackages, JavaClasses classes) {
for (String fromPackage : fromPackages) {
for (String toPackage : toPackages) {
noClasses()
.that()
.resideInAPackage(matchAllClassesInPackage(fromPackage))
.should()
.dependOnClassesThat()
.resideInAnyPackage(matchAllClassesInPackage(toPackage))
.check(classes);
denyDependency(fromPackage, toPackage, classes);
}
}
}