refactoring : data clumps

This commit is contained in:
haerong22
2022-03-22 17:20:19 +09:00
parent a01616f3a3
commit 93e4f929f6
5 changed files with 156 additions and 0 deletions

View File

@@ -0,0 +1,25 @@
package com.example.refactoring._10_data_clumps;
public class Employee {
private String name;
private TelephoneNumber personalPhoneNumber;
public Employee(String name, TelephoneNumber personalPhoneNumber) {
this.name = name;
this.personalPhoneNumber = personalPhoneNumber;
}
public String personalPhoneNumber() {
return this.personalPhoneNumber.toString();
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
}

View File

@@ -0,0 +1,17 @@
package com.example.refactoring._10_data_clumps;
public class Office {
private String location;
private TelephoneNumber officePhoneNumber;
public Office(String location, TelephoneNumber officePhoneNumber) {
this.location = location;
this.officePhoneNumber = officePhoneNumber;
}
public String officePhoneNumber() {
return this.officePhoneNumber.toString();
}
}

View File

@@ -0,0 +1,34 @@
package com.example.refactoring._10_data_clumps;
public class TelephoneNumber {
private String areaCode;
private String number;
public TelephoneNumber(String areaCode, String personalNumber) {
this.areaCode = areaCode;
this.number = personalNumber;
}
public String getAreaCode() {
return areaCode;
}
public void setAreaCode(String areaCode) {
this.areaCode = areaCode;
}
public String getNumber() {
return number;
}
public void setNumber(String number) {
this.number = number;
}
@Override
public String toString() {
return this.areaCode + "-" + this.number;
}
}

View File

@@ -0,0 +1,44 @@
package com.example.refactoring._10_data_clumps._before;
public class Employee {
private String name;
private String personalAreaCode;
private String personalNumber;
public Employee(String name, String personalAreaCode, String personalNumber) {
this.name = name;
this.personalAreaCode = personalAreaCode;
this.personalNumber = personalNumber;
}
public String personalPhoneNumber() {
return personalAreaCode + "-" + personalNumber;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
public String getPersonalAreaCode() {
return personalAreaCode;
}
public void setPersonalAreaCode(String personalAreaCode) {
this.personalAreaCode = personalAreaCode;
}
public String getPersonalNumber() {
return personalNumber;
}
public void setPersonalNumber(String personalNumber) {
this.personalNumber = personalNumber;
}
}

View File

@@ -0,0 +1,36 @@
package com.example.refactoring._10_data_clumps._before;
public class Office {
private String location;
private String officeAreCode;
private String officeNumber;
public Office(String location, String officeAreCode, String officeNumber) {
this.location = location;
this.officeAreCode = officeAreCode;
this.officeNumber = officeNumber;
}
public String officePhoneNumber() {
return officeAreCode + "-" + officeNumber;
}
public String getOfficeAreCode() {
return officeAreCode;
}
public void setOfficeAreCode(String officeAreCode) {
this.officeAreCode = officeAreCode;
}
public String getOfficeNumber() {
return officeNumber;
}
public void setOfficeNumber(String officeNumber) {
this.officeNumber = officeNumber;
}
}