mindol1004/getting-started
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add PR checklist and a 5th module

Browse Source
This commit is contained in:
Tom Hombergs
2020-07-26 09:41:11 +10:00
parent a6dca60d73
commit 68c676fc7f
3 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View File

@@ -11,7 +11,7 @@ jobs:
matrix:
# The MODULE environment variable is evaluated in build-all.sh to run a subset
# of the builds. This way, multiple modules can be built in parallel.
module: [ "module1", "module2", "module3", "module4" ]
module: [ "module1", "module2", "module3", "module4", "module5" ]
steps:

19
build-all.sh
View File

@@ -82,6 +82,22 @@ build_maven_module() {
}
}
if [[ "$MODULE" == "module5" ]]
then
# ADD NEW MODULES HERE
# (add new modules above the rest so you get quicker feedback if it fails)
build_gradle_module "spring-boot/hazelcast/hazelcast-embedded-cache"
build_gradle_module "spring-boot/hazelcast/hazelcast-client-server"
build_gradle_module "spring-boot/cache"
echo ""
echo "+++"
echo "+++ MODULE 5 SUCCESSFUL"
echo "+++"
fi
if [[ "$MODULE" == "module1" ]]
then
build_maven_module "spring-boot/spring-boot-kafka"
@@ -154,9 +170,6 @@ then
build_gradle_module "spring-boot/profiles"
build_gradle_module "spring-boot/password-encoding"
build_gradle_module "spring-boot/testcontainers"
build_gradle_module "spring-boot/hazelcast/hazelcast-embedded-cache"
build_gradle_module "spring-boot/hazelcast/hazelcast-client-server"
build_gradle_module "spring-boot/cache"
echo ""
echo "+++"

14
pull_request_template.md Normal file
View File

@@ -0,0 +1,14 @@
Please review the changes you did in this PR and check these points to make sure that the code examples are of high quality:
- [ ] the source branch for this PR is NOT the master branch of your fork (please create a dedicated branch for the PR)
- [ ] the PR doesn't contain code that is irrelevant to the topic of the article
- [ ] the PR doesn't contain any other files that are irrelevant to the topic of the article
- [ ] the PR contains a README.md file that explains in a sentence or two what the code example is about and links to the article on reflectoring.io (if you added to an existing module, please add the link to the existing README.md file)
- [ ] the code is covered with tests where it makes sense
- [ ] if you have created a new Maven or Gradle module, please add it to the CI build (search for "# ADD NEW MODULES HERE" in `build-all.sh`)
- [ ] the [GitHub Actions build](https://github.com/thombergs/code-examples/actions?query=workflow%3ACI) is successful for your PR branch
**Feel free to raise the PR even if the checklist hasn't been worked through, yet**. But please only flag it to be reviewed after going through the checklist above.
Also feel free to reach out if you have any trouble with any of the steps.