replaced integers with more meaningful Strings

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/ifelse/Service.java

@@ -12,11 +12,11 @@ class Service {
         this.featureFlagService = featureFlagService;
     }
 
-    public int doSomething() {
+    public String doSomething() {
         if (featureFlagService.isNewServiceEnabled()) {
-            return 42;
+            return "new value";
         } else {
-            return 1;
+            return "old value";
         }
     }
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacebean/NewService.java

@@ -2,7 +2,7 @@ package io.reflectoring.featureflags.patterns.replacebean;
 
 class NewService implements Service {
     @Override
-    public int doSomething() {
-        return 42;
+    public String doSomething() {
+        return "new value";
     }
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacebean/OldService.java

@@ -2,7 +2,7 @@ package io.reflectoring.featureflags.patterns.replacebean;
 
 class OldService implements Service {
     @Override
-    public int doSomething() {
-        return 1;
+    public String doSomething() {
+        return "old value";
     }
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacebean/Service.java

@@ -2,6 +2,6 @@ package io.reflectoring.featureflags.patterns.replacebean;
 
 interface Service {
 
-    int doSomething();
+    String doSomething();
 
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemethod/FeatureFlaggedService.java

@@ -19,7 +19,7 @@ class FeatureFlaggedService implements Service {
     }
 
     @Override
-    public int doSomething() {
+    public String doSomething() {
         if (featureFlagService.isNewServiceEnabled()) {
             return newService.doSomething();
         } else {

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemethod/NewService.java

@@ -5,8 +5,8 @@ import org.springframework.stereotype.Component;
 @Component
 class NewService implements Service {
     @Override
-    public int doSomething() {
-        return 42;
+    public String doSomething() {
+        return "new value";
     }
 
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemethod/OldService.java

@@ -5,8 +5,8 @@ import org.springframework.stereotype.Component;
 @Component
 class OldService implements Service {
     @Override
-    public int doSomething() {
-        return 1;
+    public String doSomething() {
+        return "old value";
     }
 
     public int doSomethingElse(){

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemethod/Service.java

@@ -2,6 +2,6 @@ package io.reflectoring.featureflags.patterns.replacemethod;
 
 interface Service {
 
-    int doSomething();
+    String doSomething();
 
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemodule/Service1.java

@@ -2,6 +2,6 @@ package io.reflectoring.featureflags.patterns.replacemodule;
 
 public interface Service1 {
 
-    int doSomething();
+    String doSomething();
 
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemodule/Service2.java

@@ -2,6 +2,6 @@ package io.reflectoring.featureflags.patterns.replacemodule;
 
 public interface Service2 {
 
-    int doSomethingElse();
+    String doSomethingElse();
 
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemodule/newmodule/NewService1.java

@@ -6,7 +6,7 @@ import org.springframework.stereotype.Component;
 @Component
 public class NewService1 implements Service1 {
     @Override
-    public int doSomething() {
-        return 42;
+    public String doSomething() {
+        return "new value";
     }
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemodule/newmodule/NewService2.java

@@ -7,7 +7,7 @@ import org.springframework.stereotype.Component;
 public class NewService2 implements Service2 {
 
     @Override
-    public int doSomethingElse() {
-        return 42;
+    public String doSomethingElse() {
+        return "another nwe value";
     }
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemodule/oldmodule/OldService1.java

@@ -6,7 +6,7 @@ import org.springframework.stereotype.Component;
 @Component
 public class OldService1 implements Service1 {
     @Override
-    public int doSomething() {
-        return 1;
+    public String doSomething() {
+        return "old value";
     }
 }

spring-boot/feature-flags/src/main/java/io/reflectoring/featureflags/patterns/replacemodule/oldmodule/OldService2.java

@@ -7,7 +7,7 @@ import org.springframework.stereotype.Component;
 public class OldService2 implements Service2 {
 
     @Override
-    public int doSomethingElse() {
-        return 1;
+    public String doSomethingElse() {
+        return "another old value";
     }
 }

spring-boot/feature-flags/src/test/java/io/reflectoring/featureflags/patterns/replacebean/ReplaceBeanTest.java

@@ -28,13 +28,13 @@ public class ReplaceBeanTest {
     @Test
     void oldServiceTest() {
         given(featureFlagService.isNewServiceEnabled()).willReturn(false);
-        assertThat(service.doSomething()).isEqualTo(1);
+        assertThat(service.doSomething()).isEqualTo("old value");
     }
 
     @Test
     void newServiceTest() {
         given(featureFlagService.isNewServiceEnabled()).willReturn(true);
-        assertThat(service.doSomething()).isEqualTo(42);
+        assertThat(service.doSomething()).isEqualTo("new value");
     }
 
 }

spring-boot/feature-flags/src/test/java/io/reflectoring/featureflags/patterns/replacemethod/ReplaceMethodTest.java

@@ -31,14 +31,14 @@ public class ReplaceMethodTest {
     @Test
     void oldServiceTest() {
         given(featureFlagService.isNewServiceEnabled()).willReturn(false);
-        assertThat(service.doSomething()).isEqualTo(1);
+        assertThat(service.doSomething()).isEqualTo("old value");
         assertThat(oldService.doSomethingElse()).isEqualTo(2);
     }
 
     @Test
     void newServiceTest() {
         given(featureFlagService.isNewServiceEnabled()).willReturn(true);
-        assertThat(service.doSomething()).isEqualTo(42);
+        assertThat(service.doSomething()).isEqualTo("new value");
         // doSomethingElse() is not behind a feature flag, so it should return the same value independant of the feature flag
         assertThat(oldService.doSomethingElse()).isEqualTo(2);
     }