mindol1004/spring-session
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix SessionRepositoryFilterTests doFilterLastAccessedTime assertion

Browse Source 
Relax the assertion so that it is not exact to avoid timing issues.

Fixes gh-519
This commit is contained in:
Rob Winch
2016-06-29 16:24:52 -05:00
parent 2b4a349b1a
commit dc553104c6
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-session/src/test/java/org/springframework/session/web/http/SessionRepositoryFilterTests.java
View File

@@ -35,6 +35,7 @@ import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
import javax.servlet.http.HttpSessionContext;
import org.assertj.core.data.Offset;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -150,8 +151,8 @@ public class SessionRepositoryFilterTests {
@Override
public void doFilter(HttpServletRequest wrappedRequest) {
long lastAccessed = wrappedRequest.getSession().getLastAccessedTime();
assertThat(lastAccessed)
.isEqualTo(wrappedRequest.getSession().getCreationTime());
assertThat(lastAccessed).isCloseTo(
wrappedRequest.getSession().getCreationTime(), Offset.offset(5L));
SessionRepositoryFilterTests.this.request.setAttribute(ACCESS_ATTR,
lastAccessed);
}