mindol1004/spring-soap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BAEL-3832: Removed logger checks from the test cases

Browse Source
This commit is contained in:
Vikas Ramsingh Rajput
2020-03-18 19:59:02 +03:00
parent b86bda6dba
commit 1a7fb4b9d0
4 changed files with 30 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-core-3/src/main/java/com/baeldung/ioccontainer/bean/CustomBeanFactoryPostProcessor.java
View File

@@ -1,16 +1,14 @@
package com.baeldung.ioccontainer.bean;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
public class CustomBeanFactoryPostProcessor implements BeanFactoryPostProcessor {
static final Logger LOGGER = LogManager.getLogger(CustomBeanPostProcessor.class.getName());
public static boolean isBeanInstantiated = false;
@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
LOGGER.info("BeanFactoryPostProcessor is Registered");
isBeanInstantiated = true;
}
}

11
spring-core-3/src/main/java/com/baeldung/ioccontainer/bean/CustomBeanPostProcessor.java
View File

@@ -1,17 +1,14 @@
package com.baeldung.ioccontainer.bean;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
public class CustomBeanPostProcessor implements BeanPostProcessor {
static final Logger LOGGER = LogManager.getLogger(CustomBeanPostProcessor.class.getName());
public static boolean isBeanInstantiated = false;
@Override
public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
LOGGER.info("BeanPostProcessor is Registered Before Initialization");
isBeanInstantiated = true;
return bean;
}
}

7
spring-core-3/src/main/java/com/baeldung/ioccontainer/bean/Student.java
View File

@@ -1,12 +1,9 @@
package com.baeldung.ioccontainer.bean;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
public class Student {
static final Logger LOGGER = LogManager.getLogger(Student.class.getName());
public static boolean isBeanInstantiated = false;
public void postConstruct() {
LOGGER.info("Student Bean is initialized");
isBeanInstantiated = true;
}
}

91
spring-core-3/src/test/java/com/baeldung/ioccontainer/IOCContainerAppUnitTest.java
View File

@@ -3,12 +3,6 @@ package com.baeldung.ioccontainer;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.util.ArrayList;
import java.util.List;
import org.apache.log4j.AppenderSkeleton;
import org.apache.log4j.Logger;
import org.apache.log4j.spi.LoggingEvent;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
@@ -26,49 +20,37 @@ import com.baeldung.ioccontainer.bean.Student;
public class IOCContainerAppUnitTest {
private LogAppender logAppender;
private List<LoggingEvent> loggingEvents;
@BeforeEach
public void initializeLogAppender() {
logAppender = new LogAppender();
Logger.getRootLogger()
.addAppender(logAppender);
loggingEvents = logAppender.events;
}
@AfterEach
public void removeLogAppender() {
Logger.getRootLogger()
.removeAppender(logAppender);
public void resetInstantiationFlag() {
Student.isBeanInstantiated = false;
CustomBeanPostProcessor.isBeanInstantiated = false;
CustomBeanFactoryPostProcessor.isBeanInstantiated = false;
}
@Test
public void whenBFInitialized_thenNoStudentLogPrinted() {
public void whenBFInitialized_thenStudentNotInitialized() {
Resource res = new ClassPathResource("ioc-container-difference-example.xml");
BeanFactory factory = new XmlBeanFactory(res);
String expected = "Student Bean is initialized";
assertFalse(checkWhetherLoggerContains(expected));
assertFalse(Student.isBeanInstantiated);
}
@Test
public void whenBFInitialized_thenStudentLogPrinted() {
public void whenBFInitialized_thenStudentInitialized() {
Resource res = new ClassPathResource("ioc-container-difference-example.xml");
BeanFactory factory = new XmlBeanFactory(res);
Student student = (Student) factory.getBean("student");
String expected = "Student Bean is initialized";
assertTrue(checkWhetherLoggerContains(expected));
assertTrue(Student.isBeanInstantiated);
}
@Test
public void whenAppContInitialized_thenStudentObjInitialized() {
public void whenAppContInitialized_thenStudentInitialized() {
ApplicationContext context = new ClassPathXmlApplicationContext("ioc-container-difference-example.xml");
String expected = "Student Bean is initialized";
assertTrue(checkWhetherLoggerContains(expected));
assertTrue(Student.isBeanInstantiated);
}
@Test
@@ -76,22 +58,16 @@ public class IOCContainerAppUnitTest {
Resource res = new ClassPathResource("ioc-container-difference-example.xml");
ConfigurableListableBeanFactory factory = new XmlBeanFactory(res);
String beanFactoryPostProcessorExpectedLog = "BeanFactoryPostProcessor is Registered";
assertFalse(checkWhetherLoggerContains(beanFactoryPostProcessorExpectedLog));
String beanPostProcessorExpectedLog = "BeanPostProcessor is Registered Before Initialization";
assertFalse(checkWhetherLoggerContains(beanPostProcessorExpectedLog));
assertFalse(CustomBeanFactoryPostProcessor.isBeanInstantiated);
assertFalse(CustomBeanPostProcessor.isBeanInstantiated);
}
@Test
public void whenAppContInitialized_thenBFPostProcessorAndBPostProcessorRegisteredAutomatically() {
ApplicationContext context = new ClassPathXmlApplicationContext("ioc-container-difference-example.xml");
String beanFactoryPostProcessorExpectedLog = "BeanFactoryPostProcessor is Registered";
assertTrue(checkWhetherLoggerContains(beanFactoryPostProcessorExpectedLog));
String beanPostProcessorExpectedLog = "BeanPostProcessor is Registered Before Initialization";
assertTrue(checkWhetherLoggerContains(beanPostProcessorExpectedLog));
assertTrue(CustomBeanFactoryPostProcessor.isBeanInstantiated);
assertTrue(CustomBeanPostProcessor.isBeanInstantiated);
}
@Test
@@ -101,37 +77,12 @@ public class IOCContainerAppUnitTest {
CustomBeanFactoryPostProcessor beanFactoryPostProcessor = new CustomBeanFactoryPostProcessor();
beanFactoryPostProcessor.postProcessBeanFactory(factory);
String beanFactoryPostProcessorExpectedLog = "BeanFactoryPostProcessor is Registered";
assertTrue(checkWhetherLoggerContains(beanFactoryPostProcessorExpectedLog));
assertTrue(CustomBeanFactoryPostProcessor.isBeanInstantiated);
CustomBeanPostProcessor beanPostProcessor = new CustomBeanPostProcessor();
factory.addBeanPostProcessor(beanPostProcessor);
Student student = (Student) factory.getBean("student");
String beanPostProcessorExpectedLog = "BeanPostProcessor is Registered Before Initialization";
assertTrue(checkWhetherLoggerContains(beanPostProcessorExpectedLog));
assertTrue(CustomBeanPostProcessor.isBeanInstantiated);
}
private boolean checkWhetherLoggerContains(String expectedLogMessge) {
boolean isLogExist = loggingEvents.stream()
.anyMatch(logEvent -> logEvent.getMessage()
.equals(expectedLogMessge));
return isLogExist;
}
public static class LogAppender extends AppenderSkeleton {
public List<LoggingEvent> events = new ArrayList<LoggingEvent>();
public void close() {
}
public boolean requiresLayout() {
return false;
}
@Override
protected void append(LoggingEvent event) {
events.add(event);
}
}
}