Merge pull request #27 from pat-karakun/master

replace hardcoded package names with (unused) parameters

README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/thombergs/buckpal/actions/workflows/ci.yml/badge.svg)](https://github.com/thombergs/buckpal/actions/workflows/ci.yml)
 
-[![Get Your Hands Dirty On Clean Architecture](https://reflectoring.io/assets/img/get-your-hands-dirty-260x336.png)](https://reflectoring.io/book).
+[![Get Your Hands Dirty On Clean Architecture](https://reflectoring.io/assets/img/get-your-hands-dirty-260x336.png)](https://reflectoring.io/book)
 
 This is the companion code to my eBook [Get Your Hands Dirty on Clean Architecture](https://leanpub.com/get-your-hands-dirty-on-clean-architecture).
 

src/main/java/io/reflectoring/buckpal/common/SelfValidating.java

@@ -10,9 +10,9 @@ import java.util.Set;
 public abstract class SelfValidating<T> {
 
   private Validator validator;
+  private static ValidatorFactory factory = Validation.buildDefaultValidatorFactory();
 
   public SelfValidating() {
-    ValidatorFactory factory = Validation.buildDefaultValidatorFactory();
     validator = factory.getValidator();
   }
 

src/test/java/io/reflectoring/buckpal/archunit/ArchitectureElement.java

@@ -23,10 +23,10 @@ abstract class ArchitectureElement {
   static void denyDependency(String fromPackageName, String toPackageName, JavaClasses classes) {
     noClasses()
         .that()
-        .resideInAPackage("io.reflectoring.reviewapp.domain..")
+        .resideInAPackage(matchAllClassesInPackage(fromPackageName))
         .should()
         .dependOnClassesThat()
-        .resideInAnyPackage("io.reflectoring.reviewapp.application..")
+        .resideInAnyPackage(matchAllClassesInPackage(toPackageName))
         .check(classes);
   }
 
@@ -34,13 +34,7 @@ abstract class ArchitectureElement {
       List<String> fromPackages, List<String> toPackages, JavaClasses classes) {
     for (String fromPackage : fromPackages) {
       for (String toPackage : toPackages) {
-        noClasses()
-            .that()
-            .resideInAPackage(matchAllClassesInPackage(fromPackage))
-            .should()
-            .dependOnClassesThat()
-            .resideInAnyPackage(matchAllClassesInPackage(toPackage))
-            .check(classes);
+        denyDependency(fromPackage, toPackage, classes);
       }
     }
   }